mambax7/adslight

View on GitHub
class/PicturesHandler.php

Summary

Maintainability
D
1 day
Test Coverage

renderFormSubmit accesses the super-global variable $GLOBALS.
Open

    public function renderFormSubmit(
        $uid,
        $lid,
        $maxbytes,
        $xoopsTpl
Severity: Minor
Found in class/PicturesHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

renderFormEdit accesses the super-global variable $GLOBALS.
Open

    public function renderFormEdit(
        $caption,
        $cod_img,
        $filename
    ): bool {
Severity: Minor
Found in class/PicturesHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

receivePicture accesses the super-global variable $GLOBALS.
Open

    public function receivePicture(
        $title,
        $pathUpload,
        $thumbwidth,
        $thumbheight,
Severity: Minor
Found in class/PicturesHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

receivePicture accesses the super-global variable $GLOBALS.
Open

    public function receivePicture(
        $title,
        $pathUpload,
        $thumbwidth,
        $thumbheight,
Severity: Minor
Found in class/PicturesHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

receivePicture accesses the super-global variable $_POST.
Open

    public function receivePicture(
        $title,
        $pathUpload,
        $thumbwidth,
        $thumbheight,
Severity: Minor
Found in class/PicturesHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

File PicturesHandler.php has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace XoopsModules\Adslight;

/*
Severity: Minor
Found in class/PicturesHandler.php - About 3 hrs to fix

    Method insert has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function insert(\XoopsObject $object, $force = false): bool
        {
            global $lid;
            if (!$object instanceof Pictures) {
                return false;
    Severity: Minor
    Found in class/PicturesHandler.php - About 1 hr to fix

      Method resizeImage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function resizeImage(
              $img,
              $thumbwidth,
              $thumbheight,
              $pictwidth,
      Severity: Minor
      Found in class/PicturesHandler.php - About 1 hr to fix

        Method receivePicture has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function receivePicture(
                $title,
                $pathUpload,
                $thumbwidth,
                $thumbheight,
        Severity: Minor
        Found in class/PicturesHandler.php - About 1 hr to fix

          Function resizeImage has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function resizeImage(
                  $img,
                  $thumbwidth,
                  $thumbheight,
                  $pictwidth,
          Severity: Minor
          Found in class/PicturesHandler.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method receivePicture has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $title,
                  $pathUpload,
                  $thumbwidth,
                  $thumbheight,
                  $pictwidth,
          Severity: Major
          Found in class/PicturesHandler.php - About 1 hr to fix

            Function insert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function insert(\XoopsObject $object, $force = false): bool
                {
                    global $lid;
                    if (!$object instanceof Pictures) {
                        return false;
            Severity: Minor
            Found in class/PicturesHandler.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getObjects has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                {
                    $ret   = [];
                    $limit = $start = 0;
                    $sql   = 'SELECT * FROM ' . $this->db->prefix('adslight_pictures');
            Severity: Minor
            Found in class/PicturesHandler.php - About 1 hr to fix

              Function getObjects has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                  {
                      $ret   = [];
                      $limit = $start = 0;
                      $sql   = 'SELECT * FROM ' . $this->db->prefix('adslight_pictures');
              Severity: Minor
              Found in class/PicturesHandler.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method resizeImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $img,
                      $thumbwidth,
                      $thumbheight,
                      $pictwidth,
                      $pictheight,
              Severity: Minor
              Found in class/PicturesHandler.php - About 45 mins to fix

                Avoid too many return statements within this method.
                Open

                        return true;
                Severity: Major
                Found in class/PicturesHandler.php - About 30 mins to fix

                  The method insert() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  NPathComplexity

                  Since: 0.1

                  The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                  Example

                  class Foo {
                      function bar() {
                          // lots of complicated code
                      }
                  }

                  Source https://phpmd.org/rules/codesize.html#npathcomplexity

                  Avoid using undefined variables such as '$url' which will lead to PHP notices.
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$title' which will lead to PHP notices.
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$uid_owner' which will lead to PHP notices.
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$title' which will lead to PHP notices.
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url), $cod_img);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$url' which will lead to PHP notices.
                  Open

                                                  'url'     => $url,
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$uid_owner' which will lead to PHP notices.
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url), $cod_img);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$url' which will lead to PHP notices.
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url), $cod_img);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  The method getObjects has a boolean flag argument $id_as_key, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  The method insert has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '300', column '27').
                  Open

                          $field_url  = new \XoopsFormFile(\_ADSLIGHT_SELECT_PHOTO, 'sel_photo', 2000000);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method create has a boolean flag argument $isNew, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function create($isNew = true)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '301', column '27').
                  Open

                          $field_desc = new \XoopsFormText(\_ADSLIGHT_CAPTION, 'caption', 35, 55);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method deleteAll has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function deleteAll(\CriteriaElement $criteria = null, $force = true, $asObject = false)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '343', column '27').
                  Open

                          $field_desc = new \XoopsFormText($caption, 'caption', 35, 55);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '304', column '30').
                  Open

                          $button_send   = new \XoopsFormButton('', 'submit_button', \_ADSLIGHT_UPLOADPICTURE, 'submit');
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '305', column '30').
                  Open

                          $field_warning = new \XoopsFormLabel(\sprintf(\_ADSLIGHT_YOUCANUPLOAD, $maxbytes / 1024));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method deleteAll has a boolean flag argument $asObject, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function deleteAll(\CriteriaElement $criteria = null, $force = true, $asObject = false)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '345', column '28').
                  Open

                          $button_send = new \XoopsFormButton(\_ADSLIGHT_EDIT, 'submit_button', \_SUBMIT, 'submit');
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method delete has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function delete(\XoopsObject $object, $force = false): bool
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '348', column '30').
                  Open

                          $field_cod_img = new \XoopsFormHidden('cod_img', $cod_img);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '404', column '25').
                  Open

                          $uploader = new \XoopsMediaUploader($pathUpload, $allowed_mimetypes, $maxfilesize, $maxfilewidth, $maxfileheight);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method getObjects has a boolean flag argument $as_object, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '307', column '30').
                  Open

                          $field_uid     = new \XoopsFormHidden('uid', $uid);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '306', column '30').
                  Open

                          $field_lid     = new \XoopsFormHidden('lid', $lid);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '350', column '29').
                  Open

                          $field_marker = new \XoopsFormHidden('marker', 1);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '299', column '27').
                  Open

                          $form       = new \XoopsThemeForm(\_ADSLIGHT_SUBMIT_PIC_TITLE, 'form_picture', XOOPS_URL . "/modules/adslight/add_photo.php?lid={$lid}&uid=" . $xoopsUser->getVar('uid'), 'post', true);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '347', column '30').
                  Open

                          $field_warning = new \XoopsFormLabel("<img src='{$filename}' alt='sssss'>");
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '342', column '27').
                  Open

                          $form       = new \XoopsThemeForm(\_ADSLIGHT_EDIT_CAPTION, 'form_picture', 'editdesc.php', 'post', true);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Avoid assigning values to variables in if clauses and the like (line '272', column '14').
                  Open

                      public function deleteAll(\CriteriaElement $criteria = null, $force = true, $asObject = false)
                      {
                          $sql = 'DELETE FROM ' . $this->db->prefix('adslight_pictures');
                           if (\is_object($criteria) && \is_subclass_of($criteria, \CriteriaElement::class)) {
                              $sql .= ' ' . $criteria->renderWhere();
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  IfStatementAssignment

                  Since: 2.7.0

                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($foo = 'bar') { // possible typo
                              // ...
                          }
                          if ($baz = 0) { // always false
                              // ...
                          }
                      }
                  }

                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                  The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              $format = 'UPDATE `%s` SET ';
                              $format .= 'cod_img=%u, title=%s, date_created=%s, date_updated=%s, lid=%s, uid_owner=%s, url=%s';
                              $format .= ' WHERE cod_img = %u';
                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url), $cod_img);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method create uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              $adslightPictures->unsetNew();
                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              $result = $this->db->query($sql);
                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method receivePicture uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              echo '<div style="color:#FF0000; background-color:#FFEAF4; border-color:#FF0000; border-width:thick; border-style:solid; text-align:center;"><p>' . $uploader->getErrors() . '</p></div>';
                  
                              return false;
                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              \imagejpeg($img, "{$pathUpload}/thumbs/thumb_{$path['basename']}");
                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              $result = $this->db->query($sql);
                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                              } else {
                                  $resized = \imagecreatetruecolor((int)\floor(\imagesx($img) * $yratio), $thumbheight);
                              }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  Avoid using static access to class '\Xmf\Request' in method 'receivePicture'.
                  Open

                          $lid = Request::getInt('lid', 0, 'POST');
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
                  {
                      public function bar()
                      {
                          Bar::baz();
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                              } else {
                                  $resized2 = \imagecreatetruecolor((int)\floor(\imagesx($img2) * $yratio2), (int)$pictheight);
                              }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              \imagejpeg($img2, "{$pathUpload}/midsize/resized_{$path2['basename']}");
                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method getObjects uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                              } else {
                                  $ret[] = $adslightPictures;
                              }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  The method renderFormSubmit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              $form->display();
                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  Avoid unused parameters such as '$force'.
                  Open

                      public function deleteAll(\CriteriaElement $criteria = null, $force = true, $asObject = false)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UnusedFormalParameter

                  Since: 0.2

                  Avoid passing parameters to methods or constructors and then not using those parameters.

                  Example

                  class Foo
                  {
                      private function bar($howdy)
                      {
                          // $howdy is not used
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                  Avoid unused local variables such as '$result'.
                  Open

                          if (!$result = $this->db->query($sql)) {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UnusedLocalVariable

                  Since: 0.2

                  Detects when a local variable is declared and/or assigned, but not used.

                  Example

                  class Foo {
                      public function doSomething()
                      {
                          $i = 5; // Unused
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                  Avoid unused parameters such as '$fields'.
                  Open

                      public function get($id = null, $fields = null)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UnusedFormalParameter

                  Since: 0.2

                  Avoid passing parameters to methods or constructors and then not using those parameters.

                  Example

                  class Foo
                  {
                      private function bar($howdy)
                      {
                          // $howdy is not used
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                  Avoid unused parameters such as '$as_object'.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UnusedFormalParameter

                  Since: 0.2

                  Avoid passing parameters to methods or constructors and then not using those parameters.

                  Example

                  class Foo
                  {
                      private function bar($howdy)
                      {
                          // $howdy is not used
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                  Avoid unused local variables such as '$hash'.
                  Open

                          $hash  = \mb_substr((string)$hash1, 0, 4);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UnusedLocalVariable

                  Since: 0.2

                  Detects when a local variable is declared and/or assigned, but not used.

                  Example

                  class Foo {
                      public function doSomething()
                      {
                          $i = 5; // Unused
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                  Avoid unused parameters such as '$asObject'.
                  Open

                      public function deleteAll(\CriteriaElement $criteria = null, $force = true, $asObject = false)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  UnusedFormalParameter

                  Since: 0.2

                  Avoid passing parameters to methods or constructors and then not using those parameters.

                  Example

                  class Foo
                  {
                      private function bar($howdy)
                      {
                          // $howdy is not used
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                  Avoid variables with short names like $id. Configured minimum length is 3.
                  Open

                      public function get($id = null, $fields = null)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  The parameter $as_object is not named in camelCase.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                      {
                          $ret   = [];
                          $limit = $start = 0;
                          $sql   = 'SELECT * FROM ' . $this->db->prefix('adslight_pictures');
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseParameterName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name parameters.

                  Example

                  class ClassName {
                      public function doSomething($user_name) {
                      }
                  }

                  Source

                  Avoid variables with short names like $db. Configured minimum length is 3.
                  Open

                      public function __construct(\XoopsDatabase $db)
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  The parameter $id_as_key is not named in camelCase.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                      {
                          $ret   = [];
                          $limit = $start = 0;
                          $sql   = 'SELECT * FROM ' . $this->db->prefix('adslight_pictures');
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseParameterName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name parameters.

                  Example

                  class ClassName {
                      public function doSomething($user_name) {
                      }
                  }

                  Source

                  The parameter $cod_img is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseParameterName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name parameters.

                  Example

                  class ClassName {
                      public function doSomething($user_name) {
                      }
                  }

                  Source

                  A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 51 and the first side effect is on line 34.
                  Open

                  <?php declare(strict_types=1);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 192 characters
                  Open

                          $form       = new \XoopsThemeForm(\_ADSLIGHT_SUBMIT_PIC_TITLE, 'form_picture', XOOPS_URL . "/modules/adslight/add_photo.php?lid={$lid}&uid=" . $xoopsUser->getVar('uid'), 'post', true);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 202 characters
                  Open

                                  echo '<div style="color:#FF0000; background-color:#FFEAF4; border-color:#FF0000; border-width:thick; border-style:solid; text-align:center;"><p>' . $uploader->getErrors() . '</p></div>';
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 140 characters
                  Open

                              \imagecopyresampled($resized, $img, 0, 0, 0, 0, \imagesx($resized) + 1, \imagesy($resized) + 1, \imagesx($img), \imagesy($img));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 230 characters
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 122 characters
                  Open

                          $uploader = new \XoopsMediaUploader($pathUpload, $allowed_mimetypes, $maxfilesize, $maxfilewidth, $maxfileheight);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 131 characters
                  Open

                          $sql = \sprintf('DELETE FROM `%s` WHERE cod_img = %u', $this->db->prefix('adslight_pictures'), $object->getVar('cod_img'));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 198 characters
                  Open

                              echo '<div style="color:#FF0000; background-color:#FFEAF4; border-color:#FF0000; border-width:thick; border-style:solid; text-align:center;"><p>' . $uploader->getErrors() . '</p></div>';
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 146 characters
                  Open

                              \imagecopyresampled($resized2, $img2, 0, 0, 0, 0, \imagesx($resized2) + 1, \imagesy($resized2) + 1, \imagesx($img2), \imagesy($img2));
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 136 characters
                  Open

                          //        $sql = 'SELECT * FROM ' . $this->db->prefix('adslight_pictures') . ' WHERE cod_img=' . $id . ' AND lid=' . $lid . ' ';
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 240 characters
                  Open

                              $sql    = \sprintf($format, $this->db->prefix('adslight_pictures'), $cod_img, $this->db->quoteString($title), $now, $now, $this->db->quoteString($lid), $this->db->quoteString($uid_owner), $this->db->quoteString($url), $cod_img);
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 165 characters
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Closing brace indented incorrectly; expected 9 spaces, found 8
                  Open

                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line indented incorrectly; expected 8 spaces, found 9
                  Open

                           if (\is_object($criteria) && \is_subclass_of($criteria, \CriteriaElement::class)) {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Line indented incorrectly; expected 8 spaces, found 9
                  Open

                           if (\is_object($criteria) && \is_subclass_of($criteria, \CriteriaElement::class)) {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  Closing brace indented incorrectly; expected 9 spaces, found 8
                  Open

                          }
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpcodesniffer

                  The variable $button_send is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_token is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_url is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $cod_img is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $cod_img is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_url is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_uid is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_warning is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_lid is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_warning is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_token is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $id_as_key is not named in camelCase.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects(?\CriteriaElement $criteria = null, $id_as_key = false): array
                      {
                          $ret   = [];
                          $limit = $start = 0;
                          $sql   = 'SELECT * FROM ' . $this->db->prefix('adslight_pictures');
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_desc is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_desc is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_marker is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_lid is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $saved_destination is not named in camelCase.
                  Open

                      public function receivePicture(
                          $title,
                          $pathUpload,
                          $thumbwidth,
                          $thumbheight,
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $cod_img is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_uid is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $button_send is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_warning is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_warning is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_cod_img is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $allowed_mimetypes is not named in camelCase.
                  Open

                      public function receivePicture(
                          $title,
                          $pathUpload,
                          $thumbwidth,
                          $thumbheight,
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $saved_destination is not named in camelCase.
                  Open

                      public function receivePicture(
                          $title,
                          $pathUpload,
                          $thumbwidth,
                          $thumbheight,
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_marker is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $button_send is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_desc is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $allowed_mimetypes is not named in camelCase.
                  Open

                      public function receivePicture(
                          $title,
                          $pathUpload,
                          $thumbwidth,
                          $thumbheight,
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $uid_owner is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $uid_owner is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $cod_img is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $button_send is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_token is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $cod_img is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $cod_img is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_desc is not named in camelCase.
                  Open

                      public function renderFormSubmit(
                          $uid,
                          $lid,
                          $maxbytes,
                          $xoopsTpl
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_cod_img is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $cod_img is not named in camelCase.
                  Open

                      public function insert(\XoopsObject $object, $force = false): bool
                      {
                          global $lid;
                          if (!$object instanceof Pictures) {
                              return false;
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $field_token is not named in camelCase.
                  Open

                      public function renderFormEdit(
                          $caption,
                          $cod_img,
                          $filename
                      ): bool {
                  Severity: Minor
                  Found in class/PicturesHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  There are no issues that match your filters.

                  Category
                  Status