File `Tree.php` has 362 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace XoopsModules\Adslight;

/*

Found in class/Tree.php - About 4 hrs to fix

The class Tree has an overall complexity of 86 which is very high. The configured complexity threshold is 50.
Open

class Tree
{
    public $table;
    public $id;
    public $pid;

Found in class/Tree.php by phpmd

Exclude checks
- Disable engine
- Disable check

Function `makeMySelBox` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method makeMySelBox() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getFirstChildId'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getAllChildId'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getChildTreeMapArray'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getFirstChild'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getPathFromId'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Xmf\Module\Admin' in method 'makeAdSelBox'.
Open

        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\MyTextSanitizer' in method 'makeMySelBox'.
Open

        $myts = \MyTextSanitizer::getInstance();

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getAllChild'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Helper' in method 'makeAdSelBox'.
Open

        $helper     = Helper::getInstance();

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'makeMySelBox'.
Open

        $categories = Utility::getMyItemIds('adslight_submit');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\MyTextSanitizer' in method 'getPathFromId'.
Open

        \MyTextSanitizer::getInstance();

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getChildTreeArray'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\XoopsDatabaseFactory' in method '__construct'.
Open

        $this->db    = \XoopsDatabaseFactory::getDatabaseConnection();

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\MyTextSanitizer' in method 'getCategoryList'.
Open

        \MyTextSanitizer::getInstance();

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getAllParentId'.
Open

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\MyTextSanitizer' in method 'getNicePathFromId'.
Open

        \MyTextSanitizer::getInstance();

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$onchange'.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused local variables such as '$myts'.
Open

        global $myts, $xoopsDB;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$none'.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$preset_id'.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The parameter $sel_id is not named in camelCase.
Open

    public function getChildTreeMapArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        global $xoopsDB;
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id . ' ';

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getFirstChild($sel_id, $order = ''): array
    {
        $arr = [];
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id . ' ';

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getIdPathFromId($sel_id, $path = ''): string
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $sel_id;
        $result = $this->db->query($sql);

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $r_prefix is not named in camelCase.
Open

    public function getChildTreeArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $id_name is not named in camelCase.
Open

    public function __construct(
        $table_name,
        $id_name,
        $pid_name
    ) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $preset_id is not named in camelCase.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getNicePathFromId($sel_id, $title, $funcURL, $path = ''): string
    {
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ", {$title} FROM " . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;
        $result = $this->db->query($sql);
        if (!$this->db->isResultSet($result)) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getAllChildId($sel_id, $order = '', $idarray = []): array
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public $id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public $db;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $r_prefix is not named in camelCase.
Open

    public function getChildTreeMapArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        global $xoopsDB;
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id . ' ';

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getFirstChildId($sel_id): array
    {
        $idarray = [];
        $sel_id  = (int)$sel_id;
        $sql     = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        while (false !== [$id] = $this->db->fetchRow($result)) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $sel_id is not named in camelCase.
Open

    public function getChildTreeArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $preset_id is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_name is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $table_name is not named in camelCase.
Open

    public function __construct(
        $table_name,
        $id_name,
        $pid_name
    ) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getAllChild($sel_id = 0, $order = '', $parray = []): array
    {
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $pid_name is not named in camelCase.
Open

    public function __construct(
        $table_name,
        $id_name,
        $pid_name
    ) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getAllParentId($sel_id, $order = '', $idarray = []): array
    {
        $sql = 'SELECT ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_id is not named in camelCase.
Open

    public function getPathFromId($sel_id, $title, $path = ''): string
    {
        $sql = 'SELECT ' . $this->pid . ', ' . $title . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;
        //        $result = $this->db->query('SELECT ' . $this->pid . ', ' . $title . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $this->db->escape($sel_id) . "'");

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $sel_name is not named in camelCase.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Line exceeds 120 characters; contains 268 characters
Open

                    <td align="center"><a href="category.php?op=AdsNewCat&amp;cid=' . $option[$this->id] . '"><img src="' . $pathIcon16 . '/add.png' . '" border=0 width=18 height=18 alt="' . \_AM_ADSLIGHT_ADDSUBCAT . '"title="' . \_AM_ADSLIGHT_ADDSUBCAT . '"></a></td>

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 122 characters
Open

        $sql = 'SELECT ' . $this->id . ', ' . $title . ', cat_order FROM ' . $this->table . ' WHERE ' . $this->pid . '=0';

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 264 characters
Open

                <th class=\"center width10\"><a href=\"category.php?op=AdsNewCat&amp;cid={$catid}\"><img src=\"{$pathIcon16}/add.png\" border=\"0\" width=\"18\" height=\"18\" alt=\"" . \_AM_ADSLIGHT_ADDSUBCAT . '" title="' . \_AM_ADSLIGHT_ADDSUBCAT . "\"></a></th>

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 269 characters
Open

                <th class=\"center width10\"><a href=\"category.php?op=AdsModCat&amp;cid={$catid}\"><img src=\"{$pathIcon16}/edit.png\" border=\"0\" width=\"18\" height=\"18\" alt=\"" . \_AM_ADSLIGHT_MODIFSUBCAT . '" title="' . \_AM_ADSLIGHT_MODIFSUBCAT . "\"></a></th>

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 266 characters
Open

                <th class=\"center width10\"><a href=\"category.php?op=AdsDelCat&amp;cid={$catid}\"><img src=\"{$pathIcon16}/delete.png\" border=\"0\" width=\"18\" height=\"18\" alt=\"" . \_AM_ADSLIGHT_DELSUBCAT . '" title="' . \_AM_ADSLIGHT_DELSUBCAT . '"></a></th>

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 176 characters
Open

        $path = "&nbsp;&nbsp;{$arrow}&nbsp;&nbsp;<a title=\"" . \_ADSLIGHT_ANNONCES . " {$name}\" href=\"{$funcURL}" . $this->id . '=' . (int)$sel_id . "\">{$name}</a>{$path}";

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 134 characters
Open

                $catpath          = $option['prefix'] . '&nbsp;&nbsp;' . \htmlspecialchars($option[$title], \ENT_QUOTES | \ENT_HTML5);

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 274 characters
Open

                    <td align="center"><a href="category.php?op=AdsDelCat&amp;cid=' . $option[$this->id] . '"><img src="' . $pathIcon16 . '/delete.png' . '" border=0 width=18 height=18 alt="' . \_AM_ADSLIGHT_DELSUBCAT . '" title="' . \_AM_ADSLIGHT_DELSUBCAT . '"></a></td>';

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 132 characters
Open

        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ", {$title} FROM " . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 176 characters
Open

        //        $result = $this->db->query('SELECT ' . $this->pid . ', ' . $title . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $this->db->escape($sel_id) . "'");

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 275 characters
Open

                    <td align="center"><a href="category.php?op=AdsModCat&amp;cid=' . $option[$this->id] . '"><img src="' . $pathIcon16 . '/edit.png' . '" border=0 width=18 height=18 alt="' . \_AM_ADSLIGHT_MODIFSUBCAT . '" title ="' . \_AM_ADSLIGHT_MODIFSUBCAT . '"></a></td>

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 125 characters
Open

        $sql = 'SELECT ' . $this->pid . ', ' . $title . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

Found in class/Tree.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

The variable $sel_id is not named in camelCase.
Open

    public function getAllChildId($sel_id, $order = '', $idarray = []): array
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_id is not named in camelCase.
Open

    public function getAllParentId($sel_id, $order = '', $idarray = []): array
    {
        $sql = 'SELECT ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getChildTreeArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cat_orderS is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $pid_name is not named in camelCase.
Open

    public function __construct(
        $table_name,
        $id_name,
        $pid_name
    ) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getFirstChildId($sel_id): array
    {
        $idarray = [];
        $sel_id  = (int)$sel_id;
        $sql     = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_id is not named in camelCase.
Open

    public function getAllChildId($sel_id, $order = '', $idarray = []): array
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cat_order is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_id is not named in camelCase.
Open

    public function getAllParentId($sel_id, $order = '', $idarray = []): array
    {
        $sql = 'SELECT ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $table_name is not named in camelCase.
Open

    public function __construct(
        $table_name,
        $id_name,
        $pid_name
    ) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getFirstChildId($sel_id): array
    {
        $idarray = [];
        $sel_id  = (int)$sel_id;
        $sql     = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_id is not named in camelCase.
Open

    public function getAllChildId($sel_id, $order = '', $idarray = []): array
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getNicePathFromId($sel_id, $title, $funcURL, $path = ''): string
    {
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ", {$title} FROM " . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;
        $result = $this->db->query($sql);
        if (!$this->db->isResultSet($result)) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_name is not named in camelCase.
Open

    public function __construct(
        $table_name,
        $id_name,
        $pid_name
    ) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_id is not named in camelCase.
Open

    public function getAllParentId($sel_id, $order = '', $idarray = []): array
    {
        $sql = 'SELECT ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_name is not named in camelCase.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cat_orderS is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_prefix is not named in camelCase.
Open

    public function getChildTreeMapArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        global $xoopsDB;
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id . ' ';

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_name is not named in camelCase.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $preset_id is not named in camelCase.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getAllChildId($sel_id, $order = '', $idarray = []): array
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getAllParentId($sel_id, $order = '', $idarray = []): array
    {
        $sql = 'SELECT ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getNicePathFromId($sel_id, $title, $funcURL, $path = ''): string
    {
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ", {$title} FROM " . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;
        $result = $this->db->query($sql);
        if (!$this->db->isResultSet($result)) {

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_id is not named in camelCase.
Open

    public function getAllChildId($sel_id, $order = '', $idarray = []): array
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_name is not named in camelCase.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getIdPathFromId($sel_id, $path = ''): string
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $sel_id;
        $result = $this->db->query($sql);

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getFirstChild($sel_id, $order = ''): array
    {
        $arr = [];
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id . ' ';

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getAllChildId($sel_id, $order = '', $idarray = []): array
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getAllChild($sel_id = 0, $order = '', $parray = []): array
    {
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_id is not named in camelCase.
Open

    public function getAllParentId($sel_id, $order = '', $idarray = []): array
    {
        $sql = 'SELECT ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $r_prefix is not named in camelCase.
Open

    public function getChildTreeArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

        $categories = Utility::getMyItemIds('adslight_view');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getFirstChildId($sel_id): array
    {
        $idarray = [];
        $sel_id  = (int)$sel_id;
        $sql     = 'SELECT SQL_CACHE ' . $this->id . ' FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id;

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getPathFromId($sel_id, $title, $path = ''): string
    {
        $sql = 'SELECT ' . $this->pid . ', ' . $title . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . (int)$sel_id;
        //        $result = $this->db->query('SELECT ' . $this->pid . ', ' . $title . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $this->db->escape($sel_id) . "'");

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $preset_id is not named in camelCase.
Open

    public function makeMySelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        if ('' === $sel_name) {
            $sel_name = $this->id;
        }

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getIdPathFromId($sel_id, $path = ''): string
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $sel_id;
        $result = $this->db->query($sql);

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cat_order is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getIdPathFromId($sel_id, $path = ''): string
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $sel_id;
        $result = $this->db->query($sql);

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_name is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_name is not named in camelCase.
Open

    public function makeAdSelBox($title, $order = '', $preset_id = 0, $none = 0, $sel_name = '', $onchange = ''): void
    {
        global $myts, $xoopsDB;
        $helper     = Helper::getInstance();
        $pathIcon16 = Admin::iconUrl('', '16');

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getIdPathFromId($sel_id, $path = ''): string
    {
        $sel_id = (int)$sel_id;
        $sql    = 'SELECT SQL_CACHE ' . $this->pid . ' FROM ' . $this->table . ' WHERE ' . $this->id . '=' . $sel_id;
        $result = $this->db->query($sql);

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $sel_id is not named in camelCase.
Open

    public function getChildTreeMapArray($sel_id = 0, $order = '', $parray = [], $r_prefix = ''): array
    {
        global $xoopsDB;
        $sql = 'SELECT SQL_CACHE * FROM ' . $this->table . ' WHERE ' . $this->pid . '=' . $sel_id . ' ';

Found in class/Tree.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

mambax7/adslight

Summary

Maintainability

Test Coverage

File Tree.php has 362 lines of code (exceeds 250 allowed). Consider refactoring. Open

The class Tree has an overall complexity of 86 which is very high. The configured complexity threshold is 50. Open

Function makeMySelBox has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Method makeAdSelBox has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open

Method makeMySelBox has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open

Function makeAdSelBox has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Method makeAdSelBox has 6 arguments (exceeds 4 allowed). Consider refactoring. Open

Method makeMySelBox has 6 arguments (exceeds 4 allowed). Consider refactoring. Open

Function getAllChildId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function getFirstChild has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function getAllChild has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function getChildTreeArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function getChildTreeMapArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

The method makeMySelBox() has an NPath complexity of 672. The configured NPath complexity threshold is 200. Open

NPathComplexity

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method makeMySelBox() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open

CyclomaticComplexity

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getFirstChildId'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getAllChildId'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getChildTreeMapArray'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getFirstChild'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getPathFromId'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Xmf\Module\Admin' in method 'makeAdSelBox'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\MyTextSanitizer' in method 'makeMySelBox'. Open

StaticAccess

File `Tree.php` has 362 lines of code (exceeds 250 allowed). Consider refactoring.
Open

The class Tree has an overall complexity of 86 which is very high. The configured complexity threshold is 50.
Open

Function `makeMySelBox` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

Method `makeAdSelBox` has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Method `makeMySelBox` has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Function `makeAdSelBox` has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

Method `makeAdSelBox` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

Method `makeMySelBox` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

Function `getAllChildId` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

Function `getFirstChild` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

Function `getAllChild` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

Function `getChildTreeArray` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

Function `getChildTreeMapArray` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

The method makeMySelBox() has an NPath complexity of 672. The configured NPath complexity threshold is 200.
Open

The method makeMySelBox() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getFirstChildId'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getAllChildId'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getChildTreeMapArray'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getFirstChild'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getPathFromId'.
Open

Avoid using static access to class '\Xmf\Module\Admin' in method 'makeAdSelBox'.
Open

Avoid using static access to class '\MyTextSanitizer' in method 'makeMySelBox'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getAllChild'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Helper' in method 'makeAdSelBox'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'makeMySelBox'.
Open

Avoid using static access to class '\MyTextSanitizer' in method 'getPathFromId'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getChildTreeArray'.
Open

Avoid using static access to class '\XoopsDatabaseFactory' in method '__construct'.
Open

Avoid using static access to class '\MyTextSanitizer' in method 'getCategoryList'.
Open

Avoid using static access to class 'XoopsModules\Adslight\Utility' in method 'getAllParentId'.
Open

Avoid using static access to class '\MyTextSanitizer' in method 'getNicePathFromId'.
Open

Avoid unused parameters such as '$onchange'.
Open

Avoid unused local variables such as '$myts'.
Open

Avoid unused parameters such as '$none'.
Open

Avoid unused parameters such as '$preset_id'.
Open

The parameter $sel_id is not named in camelCase.
Open