Sign upLogin

mambax7/adslight

View on GitHub
Star
class/Type.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused private fields such as '$id_type'.
Open

    private $id_type;
Severity: Minor
Found in class/Type.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid unused private fields such as '$nom_type'.
Open

    private $nom_type;
Severity: Minor
Found in class/Type.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid using static access to class 'XoopsModules\Adslight\Helper' in method '__construct'.
Open

        $this->helper     = Helper::getInstance();
Severity: Minor
Found in class/Type.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The property $id_type is not named in camelCase.
Open

class Type extends \XoopsObject
{
    private $id_type;
    private $nom_type;
    public  $helper;
Severity: Minor
Found in class/Type.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $nom_type is not named in camelCase.
Open

class Type extends \XoopsObject
{
    private $id_type;
    private $nom_type;
    public  $helper;
Severity: Minor
Found in class/Type.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Scope keyword "public" must be followed by a single space
Open

    public  $helper;
Severity: Minor
Found in class/Type.php by phpcodesniffer

Scope keyword "public" must be followed by a single space
Open

    public  $permHelper;
Severity: Minor
Found in class/Type.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Adslight\{
Severity: Minor
Found in class/Type.php by phpcodesniffer

There are no issues that match your filters.

Category
Status