mambax7/adslight

View on GitHub
class/Utility.php

Summary

Maintainability
F
1 wk
Test Coverage

getModuleOption accesses the super-global variable $GLOBALS.
Open

    public static function getModuleOption($option, $repmodule = 'adslight')
    {
        global $xoopsModule;
        $helper = \XoopsModules\Adslight\Helper::getInstance();
        static $tbloptions = [];
Severity: Minor
Found in class/Utility.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getModuleOption accesses the super-global variable $GLOBALS.
Open

    public static function getModuleOption($option, $repmodule = 'adslight')
    {
        global $xoopsModule;
        $helper = \XoopsModules\Adslight\Helper::getInstance();
        static $tbloptions = [];
Severity: Minor
Found in class/Utility.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getModuleOption accesses the super-global variable $GLOBALS.
Open

    public static function getModuleOption($option, $repmodule = 'adslight')
    {
        global $xoopsModule;
        $helper = \XoopsModules\Adslight\Helper::getInstance();
        static $tbloptions = [];
Severity: Minor
Found in class/Utility.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getMyItemIds accesses the super-global variable $GLOBALS.
Open

    public static function getMyItemIds($permtype)
    {
        static $permissions = [];
        if (\is_array($permissions)
            && \array_key_exists($permtype, $permissions)) {
Severity: Minor
Found in class/Utility.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getMyItemIds accesses the super-global variable $GLOBALS.
Open

    public static function getMyItemIds($permtype)
    {
        static $permissions = [];
        if (\is_array($permissions)
            && \array_key_exists($permtype, $permissions)) {
Severity: Minor
Found in class/Utility.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getModuleOption accesses the super-global variable $GLOBALS.
Open

    public static function getModuleOption($option, $repmodule = 'adslight')
    {
        global $xoopsModule;
        $helper = \XoopsModules\Adslight\Helper::getInstance();
        static $tbloptions = [];
Severity: Minor
Found in class/Utility.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

File Utility.php has 585 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace XoopsModules\Adslight;

/*
Severity: Major
Found in class/Utility.php - About 1 day to fix

    Function expireAd has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function expireAd(): void
        {
            global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $meta;
            $helper = Helper::getInstance();
    
    
    Severity: Minor
    Found in class/Utility.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method expireAd has 115 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function expireAd(): void
        {
            global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $meta;
            $helper = Helper::getInstance();
    
    
    Severity: Major
    Found in class/Utility.php - About 4 hrs to fix

      Method getMoneyFormat has 84 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function getMoneyFormat(
              $format,
              $number
          ) {
              $regex = '/%((?:[\^!\-]|\+|\(|\=.)*)(\d+)?' . '(?:#(\d+))?(?:\.(\d+))?([in%])/';
      Severity: Major
      Found in class/Utility.php - About 3 hrs to fix

        The class Utility has 17 public methods. Consider refactoring Utility to keep number of public methods under 10.
        Open

        class Utility extends Common\SysUtility
        {
            //--------------- Custom module methods -----------------------------
            /**
             * @return void
        Severity: Minor
        Found in class/Utility.php by phpmd

        TooManyPublicMethods

        Since: 0.1

        A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

        By default it ignores methods starting with 'get' or 'set'.

        Example

        Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

        The class Utility has an overall complexity of 130 which is very high. The configured complexity threshold is 50.
        Open

        class Utility extends Common\SysUtility
        {
            //--------------- Custom module methods -----------------------------
            /**
             * @return void
        Severity: Minor
        Found in class/Utility.php by phpmd

        Function getMoneyFormat has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function getMoneyFormat(
                $format,
                $number
            ) {
                $regex = '/%((?:[\^!\-]|\+|\(|\=.)*)(\d+)?' . '(?:#(\d+))?(?:\.(\d+))?([in%])/';
        Severity: Minor
        Found in class/Utility.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Utility has 23 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Utility extends Common\SysUtility
        {
            //--------------- Custom module methods -----------------------------
            /**
             * @return void
        Severity: Minor
        Found in class/Utility.php - About 2 hrs to fix

          Method displayCategory has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function displayCategory(Categories $categoryObj, $level = 0): void
              {
                  $helper       = Helper::getInstance();
                  $configurator = new Common\Configurator();
                  $icons        = $configurator->icons;
          Severity: Minor
          Found in class/Utility.php - About 1 hr to fix

            Function getTotalItems has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function getTotalItems($sel_id, $status = ''): int
                {
                    global $xoopsDB, $mytree;
                    $categories = self::getMyItemIds('adslight_view');
                    $count      = 0;
            Severity: Minor
            Found in class/Utility.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getModuleOption has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function getModuleOption($option, $repmodule = 'adslight')
                {
                    global $xoopsModule;
                    $helper = \XoopsModules\Adslight\Helper::getInstance();
                    static $tbloptions = [];
            Severity: Minor
            Found in class/Utility.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method convertOrderByIn has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function convertOrderByIn($orderby): string
                {
                    switch (\trim($orderby)) {
                        case 'titleA':
                            $orderby = 'title ASC';
            Severity: Minor
            Found in class/Utility.php - About 1 hr to fix

              Method getModuleOption has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function getModuleOption($option, $repmodule = 'adslight')
                  {
                      global $xoopsModule;
                      $helper = \XoopsModules\Adslight\Helper::getInstance();
                      static $tbloptions = [];
              Severity: Minor
              Found in class/Utility.php - About 1 hr to fix

                Method convertOrderByTrans has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function convertOrderByTrans($orderby): string
                    {
                        $orderbyTrans = '';
                        if ('hits ASC' === $orderby) {
                            $orderbyTrans = \_ADSLIGHT_POPULARITYLTOM;
                Severity: Minor
                Found in class/Utility.php - About 1 hr to fix

                  Method getTotalItems has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function getTotalItems($sel_id, $status = ''): int
                      {
                          global $xoopsDB, $mytree;
                          $categories = self::getMyItemIds('adslight_view');
                          $count      = 0;
                  Severity: Minor
                  Found in class/Utility.php - About 1 hr to fix

                    Function convertOrderByIn has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function convertOrderByIn($orderby): string
                        {
                            switch (\trim($orderby)) {
                                case 'titleA':
                                    $orderby = 'title ASC';
                    Severity: Minor
                    Found in class/Utility.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function convertOrderByOut has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function convertOrderByOut($orderby): string
                        {
                            if ('title ASC' === $orderby) {
                                $orderby = 'titleA';
                            }
                    Severity: Minor
                    Found in class/Utility.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                            if (\is_file("{$destination}/{$url}")) {
                                                \unlink("{$destination}/{$url}");
                                            }
                    Severity: Major
                    Found in class/Utility.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if (\is_file("{$destination2}/thumb_{$url}")) {
                                                  \unlink("{$destination2}/thumb_{$url}");
                                              }
                      Severity: Major
                      Found in class/Utility.php - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if (\is_file("{$destination3}/resized_{$url}")) {
                                                    \unlink("{$destination3}/resized_{$url}");
                                                }
                        Severity: Major
                        Found in class/Utility.php - About 45 mins to fix

                          Function convertOrderByTrans has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function convertOrderByTrans($orderby): string
                              {
                                  $orderbyTrans = '';
                                  if ('hits ASC' === $orderby) {
                                      $orderbyTrans = \_ADSLIGHT_POPULARITYLTOM;
                          Severity: Minor
                          Found in class/Utility.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function displayCategory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function displayCategory(Categories $categoryObj, $level = 0): void
                              {
                                  $helper       = Helper::getInstance();
                                  $configurator = new Common\Configurator();
                                  $icons        = $configurator->icons;
                          Severity: Minor
                          Found in class/Utility.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          The method convertOrderByTrans() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
                          Open

                              public static function convertOrderByTrans($orderby): string
                              {
                                  $orderbyTrans = '';
                                  if ('hits ASC' === $orderby) {
                                      $orderbyTrans = \_ADSLIGHT_POPULARITYLTOM;
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          NPathComplexity

                          Since: 0.1

                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                          Example

                          class Foo {
                              function bar() {
                                  // lots of complicated code
                              }
                          }

                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                          The method getMoneyFormat() has an NPath complexity of 663554. The configured NPath complexity threshold is 200.
                          Open

                              public static function getMoneyFormat(
                                  $format,
                                  $number
                              ) {
                                  $regex = '/%((?:[\^!\-]|\+|\(|\=.)*)(\d+)?' . '(?:#(\d+))?(?:\.(\d+))?([in%])/';
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          NPathComplexity

                          Since: 0.1

                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                          Example

                          class Foo {
                              function bar() {
                                  // lots of complicated code
                              }
                          }

                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                          The method expireAd() has 132 lines of code. Current threshold is set to 100. Avoid really long methods.
                          Open

                              public static function expireAd(): void
                              {
                                  global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $meta;
                                  $helper = Helper::getInstance();
                          
                          
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          The method convertOrderByOut() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
                          Open

                              public static function convertOrderByOut($orderby): string
                              {
                                  if ('title ASC' === $orderby) {
                                      $orderby = 'titleA';
                                  }
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          NPathComplexity

                          Since: 0.1

                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                          Example

                          class Foo {
                              function bar() {
                                  // lots of complicated code
                              }
                          }

                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                          The method expireAd() has an NPath complexity of 470. The configured NPath complexity threshold is 200.
                          Open

                              public static function expireAd(): void
                              {
                                  global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $meta;
                                  $helper = Helper::getInstance();
                          
                          
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          NPathComplexity

                          Since: 0.1

                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                          Example

                          class Foo {
                              function bar() {
                                  // lots of complicated code
                              }
                          }

                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                          The method getMoneyFormat() has a Cyclomatic Complexity of 30. The configured cyclomatic complexity threshold is 10.
                          Open

                              public static function getMoneyFormat(
                                  $format,
                                  $number
                              ) {
                                  $regex = '/%((?:[\^!\-]|\+|\(|\=.)*)(\d+)?' . '(?:#(\d+))?(?:\.(\d+))?([in%])/';
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CyclomaticComplexity

                          Since: 0.1

                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                          Example

                          // Cyclomatic Complexity = 11
                          class Foo {
                          1   public function example() {
                          2       if ($a == $b) {
                          3           if ($a1 == $b1) {
                                          fiddle();
                          4           } elseif ($a2 == $b2) {
                                          fiddle();
                                      } else {
                                          fiddle();
                                      }
                          5       } elseif ($c == $d) {
                          6           while ($c == $d) {
                                          fiddle();
                                      }
                          7        } elseif ($e == $f) {
                          8           for ($n = 0; $n < $h; $n++) {
                                          fiddle();
                                      }
                                  } else {
                                      switch ($z) {
                          9               case 1:
                                              fiddle();
                                              break;
                          10              case 2:
                                              fiddle();
                                              break;
                          11              case 3:
                                              fiddle();
                                              break;
                                          default:
                                              fiddle();
                                              break;
                                      }
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                          The method expireAd() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
                          Open

                              public static function expireAd(): void
                              {
                                  global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $meta;
                                  $helper = Helper::getInstance();
                          
                          
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CyclomaticComplexity

                          Since: 0.1

                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                          Example

                          // Cyclomatic Complexity = 11
                          class Foo {
                          1   public function example() {
                          2       if ($a == $b) {
                          3           if ($a1 == $b1) {
                                          fiddle();
                          4           } elseif ($a2 == $b2) {
                                          fiddle();
                                      } else {
                                          fiddle();
                                      }
                          5       } elseif ($c == $d) {
                          6           while ($c == $d) {
                                          fiddle();
                                      }
                          7        } elseif ($e == $f) {
                          8           for ($n = 0; $n < $h; $n++) {
                                          fiddle();
                                      }
                                  } else {
                                      switch ($z) {
                          9               case 1:
                                              fiddle();
                                              break;
                          10              case 2:
                                              fiddle();
                                              break;
                          11              case 3:
                                              fiddle();
                                              break;
                                          default:
                                              fiddle();
                                              break;
                                      }
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                          The method getModuleOption() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                          Open

                              public static function getModuleOption($option, $repmodule = 'adslight')
                              {
                                  global $xoopsModule;
                                  $helper = \XoopsModules\Adslight\Helper::getInstance();
                                  static $tbloptions = [];
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CyclomaticComplexity

                          Since: 0.1

                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                          Example

                          // Cyclomatic Complexity = 11
                          class Foo {
                          1   public function example() {
                          2       if ($a == $b) {
                          3           if ($a1 == $b1) {
                                          fiddle();
                          4           } elseif ($a2 == $b2) {
                                          fiddle();
                                      } else {
                                          fiddle();
                                      }
                          5       } elseif ($c == $d) {
                          6           while ($c == $d) {
                                          fiddle();
                                      }
                          7        } elseif ($e == $f) {
                          8           for ($n = 0; $n < $h; $n++) {
                                          fiddle();
                                      }
                                  } else {
                                      switch ($z) {
                          9               case 1:
                                              fiddle();
                                              break;
                          10              case 2:
                                              fiddle();
                                              break;
                          11              case 3:
                                              fiddle();
                                              break;
                                          default:
                                              fiddle();
                                              break;
                                      }
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                          Avoid using undefined variables such as '$block' which will lead to PHP notices.
                          Open

                                  return $block;
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UndefinedVariable

                          Since: 2.8.0

                          Detects when a variable is used that has not been defined before.

                          Example

                          class Foo
                          {
                              private function bar()
                              {
                                  // $message is undefined
                                  echo $message;
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                          Avoid using undefined variables such as '$key' which will lead to PHP notices.
                          Open

                                      unset($key);
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UndefinedVariable

                          Since: 2.8.0

                          Detects when a variable is used that has not been defined before.

                          Example

                          class Foo
                          {
                              private function bar()
                              {
                                  // $message is undefined
                                  echo $message;
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                          Avoid using undefined variables such as '$block' which will lead to PHP notices.
                          Open

                                  $block['selectbox'] = \ob_get_clean();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UndefinedVariable

                          Since: 2.8.0

                          Detects when a variable is used that has not been defined before.

                          Example

                          class Foo
                          {
                              private function bar()
                              {
                                  // $message is undefined
                                  echo $message;
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                          Missing class import via use statement (line '512', column '26').
                          Open

                                  $xoopsTree = new \XoopsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          MissingImport

                          Since: 2.7.0

                          Importing all external classes in a file through use statements makes them clearly visible.

                          Example

                          function make() {
                              return new \stdClass();
                          }

                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                          Missing class import via use statement (line '815', column '32').
                          Open

                                  $fmt             = new \NumberFormatter($currentDefault, \NumberFormatter::DECIMAL);
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          MissingImport

                          Since: 2.7.0

                          Importing all external classes in a file through use statements makes them clearly visible.

                          Example

                          function make() {
                              return new \stdClass();
                          }

                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                          Remove error control operator '@' on line 666.
                          Open

                              public static function getMoneyFormat(
                                  $format,
                                  $number
                              ) {
                                  $regex = '/%((?:[\^!\-]|\+|\(|\=.)*)(\d+)?' . '(?:#(\d+))?(?:\.(\d+))?([in%])/';
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          ErrorControlOperator

                          Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                          Example

                          function foo($filePath) {
                              $file = @fopen($filPath); // hides exceptions
                              $key = @$array[$notExistingKey]; // assigns null to $key
                          }

                          Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                          Missing class import via use statement (line '798', column '20').
                          Open

                                  $fmt = new \NumberFormatter($localeCode, \NumberFormatter::CURRENCY);
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          MissingImport

                          Since: 2.7.0

                          Importing all external classes in a file through use statements makes them clearly visible.

                          Example

                          function make() {
                              return new \stdClass();
                          }

                          Source http://phpmd.org/rules/cleancode.html#MissingImport

                          Avoid using static access to class 'XoopsModules\Adslight\Helper' in method 'expireAd'.
                          Open

                                  $helper = Helper::getInstance();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          Avoid using static access to class '\Xmf\Request' in method 'updateItemRating'.
                          Open

                                  $lid = Request::getInt('lid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          The method getMoneyFormat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                          Open

                                      } else {
                                          $value = $prefix . $value . $space . $currency . $suffix;
                                      }
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          ElseExpression

                          Since: 1.4.0

                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                          Example

                          class Foo
                          {
                              public function bar($flag)
                              {
                                  if ($flag) {
                                      // one branch
                                  } else {
                                      // another branch
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                          Avoid using static access to class '\XoopsModules\Adslight\Helper' in method 'saveCategoryPermissions'.
                          Open

                                  $helper = \XoopsModules\Adslight\Helper::getInstance();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          Avoid using static access to class 'XoopsModules\Adslight\Helper' in method 'loadLightbox'.
                          Open

                                  $helper = Helper::getInstance();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          Avoid assigning values to variables in if clauses and the like (line '498', column '14').
                          Open

                              public static function getCatNameFromId($cid): bool
                              {
                                  global $xoopsDB, $myts;
                          
                                  $sql = 'SELECT SQL_CACHE title FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid = '{$cid}'";
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          IfStatementAssignment

                          Since: 2.7.0

                          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                          Example

                          class Foo
                          {
                              public function bar($flag)
                              {
                                  if ($foo = 'bar') { // possible typo
                                      // ...
                                  }
                                  if ($baz = 0) { // always false
                                      // ...
                                  }
                              }
                          }

                          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                          Avoid using static access to class '\Xmf\Request' in method 'returnAllAdsRss'.
                          Open

                                  $cid = Request::getInt('cid', null, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          Avoid using static access to class 'XoopsModules\Adslight\Helper' in method 'displayCategory'.
                          Open

                                  $helper       = Helper::getInstance();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          The method getModuleOption uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                          Open

                                  } else {
                                      /** @var \XoopsModuleHandler $moduleHandler */
                                      $moduleHandler = \xoops_getHandler('module');
                                      $module        = $moduleHandler->getByDirname($repmodule);
                                      /** @var \XoopsConfigHandler $configHandler */
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          ElseExpression

                          Since: 1.4.0

                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                          Example

                          class Foo
                          {
                              public function bar($flag)
                              {
                                  if ($flag) {
                                      // one branch
                                  } else {
                                      // another branch
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                          The method getMoneyFormat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                          Open

                                      } else {
                                          $currency = $cprefix . ('i' === $conversion ? $locale['int_curr_symbol'] : $locale['currency_symbol']) . $csuffix;
                                      }
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          ElseExpression

                          Since: 1.4.0

                          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                          Example

                          class Foo
                          {
                              public function bar($flag)
                              {
                                  if ($flag) {
                                      // one branch
                                  } else {
                                      // another branch
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#elseexpression

                          Avoid using static access to class '\Xmf\Request' in method 'updateUserRating'.
                          Open

                                  $usid = Request::getInt('usid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          Avoid using static access to class '\XoopsModules\Adslight\Helper' in method 'getModuleOption'.
                          Open

                                  $helper = \XoopsModules\Adslight\Helper::getInstance();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          StaticAccess

                          Since: 1.4.0

                          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                          Example

                          class Foo
                          {
                              public function bar()
                              {
                                  Bar::baz();
                              }
                          }

                          Source https://phpmd.org/rules/cleancode.html#staticaccess

                          Avoid unused local variables such as '$usid'.
                          Open

                                  $usid = Request::getInt('usid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedLocalVariable

                          Since: 0.2

                          Detects when a local variable is declared and/or assigned, but not used.

                          Example

                          class Foo {
                              public function doSomething()
                              {
                                  $i = 5; // Unused
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                          Avoid unused parameters such as '$status'.
                          Open

                              public static function getTotalItems($sel_id, $status = ''): int
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedFormalParameter

                          Since: 0.2

                          Avoid passing parameters to methods or constructors and then not using those parameters.

                          Example

                          class Foo
                          {
                              private function bar($howdy)
                              {
                                  // $howdy is not used
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                          Avoid unused parameters such as '$currency'.
                          Open

                              public static function formatCurrencyTemp($number, $currency = 'USD', $currencySymbol = '$', $currencyPosition = 0): string
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedFormalParameter

                          Since: 0.2

                          Avoid passing parameters to methods or constructors and then not using those parameters.

                          Example

                          class Foo
                          {
                              private function bar($howdy)
                              {
                                  // $howdy is not used
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                          Avoid unused local variables such as '$helper'.
                          Open

                                  $helper = \XoopsModules\Adslight\Helper::getInstance();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedLocalVariable

                          Since: 0.2

                          Detects when a local variable is declared and/or assigned, but not used.

                          Example

                          class Foo {
                              public function doSomething()
                              {
                                  $i = 5; // Unused
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                          Avoid unused local variables such as '$comments'.
                          Open

                                  while (false !== [$lids, $title, $expire, $type, $desctext, $dateann, $email, $submitter, $photo, $valid, $hits, $comments, $remind] = $xoopsDB->fetchRow($result5)) {
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedLocalVariable

                          Since: 0.2

                          Detects when a local variable is declared and/or assigned, but not used.

                          Example

                          class Foo {
                              public function doSomething()
                              {
                                  $i = 5; // Unused
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                          The method updateItemRating() contains an exit expression.
                          Open

                                  $xoopsDB->query($sql) || exit();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          ExitExpression

                          Since: 0.2

                          An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

                          Example

                          class Foo {
                              public function bar($param)  {
                                  if ($param === 42) {
                                      exit(23);
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/design.html#exitexpression

                          Avoid unused local variables such as '$myts'.
                          Open

                                  global $xoopsDB, $myts;
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedLocalVariable

                          Since: 0.2

                          Detects when a local variable is declared and/or assigned, but not used.

                          Example

                          class Foo {
                              public function doSomething()
                              {
                                  $i = 5; // Unused
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                          The method updateUserRating() contains an exit expression.
                          Open

                                  $xoopsDB->query($sql) || exit();
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          ExitExpression

                          Since: 0.2

                          An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

                          Example

                          class Foo {
                              public function bar($param)  {
                                  if ($param === 42) {
                                      exit(23);
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/design.html#exitexpression

                          Avoid unused local variables such as '$moduleConfig'.
                          Open

                                          $moduleConfig = $configHandler->getConfigsByCat(0, $GLOBALS['xoopsModule']->getVar('mid'));
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedLocalVariable

                          Since: 0.2

                          Detects when a local variable is declared and/or assigned, but not used.

                          Example

                          class Foo {
                              public function doSomething()
                              {
                                  $i = 5; // Unused
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                          Avoid unused local variables such as '$lid'.
                          Open

                                  $lid = Request::getInt('lid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedLocalVariable

                          Since: 0.2

                          Detects when a local variable is declared and/or assigned, but not used.

                          Example

                          class Foo {
                              public function doSomething()
                              {
                                  $i = 5; // Unused
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                          Avoid unused local variables such as '$key'.
                          Open

                                      unset($key);
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          UnusedLocalVariable

                          Since: 0.2

                          Detects when a local variable is declared and/or assigned, but not used.

                          Example

                          class Foo {
                              public function doSomething()
                              {
                                  $i = 5; // Unused
                              }
                          }

                          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public static function updateItemRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $lid = Request::getInt('lid', 0, 'GET');
                          Severity: Major
                          Found in class/Utility.php and 1 other location - About 1 day to fix
                          class/Utility.php on lines 177..199

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 249.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public static function updateUserRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $usid = Request::getInt('usid', 0, 'GET');
                          Severity: Major
                          Found in class/Utility.php and 1 other location - About 1 day to fix
                          class/Utility.php on lines 206..228

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 249.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          The parameter $sel_id is not named in camelCase.
                          Open

                              public static function getTotalItems($sel_id, $status = ''): int
                              {
                                  global $xoopsDB, $mytree;
                                  $categories = self::getMyItemIds('adslight_view');
                                  $count      = 0;
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseParameterName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name parameters.

                          Example

                          class ClassName {
                              public function doSomething($user_name) {
                              }
                          }

                          Source

                          The parameter $sel_id is not named in camelCase.
                          Open

                              public static function updateItemRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $lid = Request::getInt('lid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseParameterName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name parameters.

                          Example

                          class ClassName {
                              public function doSomething($user_name) {
                              }
                          }

                          Source

                          The parameter $sel_id is not named in camelCase.
                          Open

                              public static function updateUserRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $usid = Request::getInt('usid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseParameterName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name parameters.

                          Example

                          class ClassName {
                              public function doSomething($user_name) {
                              }
                          }

                          Source

                          Avoid variables with short names like $n. Configured minimum length is 3.
                          Open

                                      $n     = \mb_strlen($prefix) + \mb_strlen($currency) + \mb_strlen($value[0]);
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          ShortVariable

                          Since: 0.2

                          Detects when a field, local, or parameter has a very short name.

                          Example

                          class Something {
                              private $q = 15; // VIOLATION - Field
                              public static function main( array $as ) { // VIOLATION - Formal
                                  $r = 20 + $this->q; // VIOLATION - Local
                                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                      $r += $this->q;
                                  }
                              }
                          }

                          Source https://phpmd.org/rules/naming.html#shortvariable

                          There must be one USE keyword per declaration
                          Open

                          use XoopsModules\Adslight\{
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          The 'getCatNameFromId()' method which returns a boolean should be named 'is...()' or 'has...()'
                          Open

                              public static function getCatNameFromId($cid): bool
                              {
                                  global $xoopsDB, $myts;
                          
                                  $sql = 'SELECT SQL_CACHE title FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid = '{$cid}'";
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          BooleanGetMethodName

                          Since: 0.2

                          Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

                          Example

                          class Foo {
                              /**
                               * @return boolean
                               */
                              public function getFoo() {} // bad
                              /**
                               * @return bool
                               */
                              public function isFoo(); // ok
                              /**
                               * @return boolean
                               */
                              public function getFoo($bar); // ok, unless checkParameterizedMethods=true
                          }

                          Source https://phpmd.org/rules/naming.html#booleangetmethodname

                          Line exceeds 120 characters; contains 121 characters
                          Open

                                          $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_listing') . " SET remind='1' WHERE lid={$lids}");
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 136 characters
                          Open

                                              $tags['LINK_URL']   = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewads.php?' . '&lid=' . $lids;
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 174 characters
                          Open

                                  while (false !== [$lids, $title, $expire, $type, $desctext, $dateann, $email, $submitter, $photo, $valid, $hits, $comments, $remind] = $xoopsDB->fetchRow($result5)) {
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 201 characters
                          Open

                                  $sql     = 'SELECT lid, title, expire, type, desctext, date_created, email, submitter, photo, valid, hits, comments, remind FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE valid='Yes'";
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 162 characters
                          Open

                                                  $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" >
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 132 characters
                          Open

                                              $sql     = 'SELECT url FROM ' . $xoopsDB->prefix('adslight_pictures') . ' WHERE lid=' . $xoopsDB->escape($lids);
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 169 characters
                          Open

                                              $sql2 = 'SELECT SQL_CACHE count(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE cid=' . (int)$iValue . " AND valid='Yes' AND status!='1'";
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 131 characters
                          Open

                                  $sql    = 'SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE id_type='" . $xoopsDB->escape($type) . "'";
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 131 characters
                          Open

                                  $xoopsTree->makeMySelBox('title', 'title', 0, 1, 'pid', 'location="' . $jump . '"+this.options[this.selectedIndex].value');
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 121 characters
                          Open

                                          $value = \str_pad($value, $width, $flags['fillchar'], $flags['isleft'] ? \STR_PAD_RIGHT : \STR_PAD_LEFT);
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 162 characters
                          Open

                                                  $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" >
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 136 characters
                          Open

                                              $tags['LINK_URL']   = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewads.php?' . '&lid=' . $lids;
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 145 characters
                          Open

                                  $modify = "<a href='category.php?op=mod&amp;cid=" . $categoryObj->cid . '&amp;pid=' . $categoryObj->pid . "'>" . $icons['edit'] . '</a>';
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 133 characters
                          Open

                                  $sql = 'SELECT rating FROM ' . $xoopsDB->prefix('adslight_user_votedata') . ' WHERE usid=' . $xoopsDB->escape($sel_id) . ' ';
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 146 characters
                          Open

                                  echo "'" . XOOPS_URL . "/modules/adslight/assets/images/img_cat/' + document.imcat.img.options[document.imcat.img.selectedIndex].value\n";
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 169 characters
                          Open

                                              $mail->setTemplateDir(XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/language/' . $xoopsConfig['language'] . '/mail_template/');
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 127 characters
                          Open

                              public static function formatCurrencyTemp($number, $currency = 'USD', $currencySymbol = '$', $currencyPosition = 0): string
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 169 characters
                          Open

                                  $sql       = 'UPDATE ' . $xoopsDB->prefix('adslight_listing') . " SET user_rating={$finalrating}, user_votes={$votesDB} WHERE usid=" . $xoopsDB->escape($sel_id);
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 196 characters
                          Open

                                  $sql = 'SELECT lid, title, price, date_created, town FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE valid='yes' AND cid=" . $xoopsDB->escape($cid) . ' ORDER BY date_created DESC';
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 168 characters
                          Open

                                  $sql       = 'UPDATE ' . $xoopsDB->prefix('adslight_listing') . " SET item_rating={$finalrating}, item_votes={$votesDB} WHERE lid=" . $xoopsDB->escape($sel_id);
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 160 characters
                          Open

                                      $sql = 'SELECT SQL_CACHE count(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE cid=' . (int)$sel_id . " AND valid='Yes' AND status!='1'";
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 178 characters
                          Open

                                  $sql = 'SELECT lid, title, price, desctext, date_created, town FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE valid='yes' ORDER BY date_created DESC LIMIT 0,15";
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 169 characters
                          Open

                                              $mail->setTemplateDir(XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/language/' . $xoopsConfig['language'] . '/mail_template/');
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 270 characters
                          Open

                                          //  $message = ""._ADS_HELLO." $submitter,\n\n"._ADS_STOP2."\n $type : $title\n $desctext\n"._ADS_STOP3."\n\n"._ADS_VU." $lu "._ADS_VU2."\n\n"._ADS_OTHER." ".XOOPS_URL."/modules/myAds\n\n"._ADS_THANK."\n\n"._ADS_TEAM." ".$meta['title']."\n".XOOPS_URL."";
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 130 characters
                          Open

                                          $currency = $cprefix . ('i' === $conversion ? $locale['int_curr_symbol'] : $locale['currency_symbol']) . $csuffix;
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 130 characters
                          Open

                                          $xoopsDB->queryF('DELETE FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE lid=' . $xoopsDB->escape($lids));
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          Line exceeds 120 characters; contains 132 characters
                          Open

                                  $sql = 'SELECT rating FROM ' . $xoopsDB->prefix('adslight_item_votedata') . ' WHERE lid=' . $xoopsDB->escape($sel_id) . ' ';
                          Severity: Minor
                          Found in class/Utility.php by phpcodesniffer

                          The variable $sel_id is not named in camelCase.
                          Open

                              public static function getTotalItems($sel_id, $status = ''): int
                              {
                                  global $xoopsDB, $mytree;
                                  $categories = self::getMyItemIds('adslight_view');
                                  $count      = 0;
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $sel_id is not named in camelCase.
                          Open

                              public static function updateUserRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $usid = Request::getInt('usid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $nom_type is not named in camelCase.
                          Open

                              public static function getNameType($type)
                              {
                                  global $xoopsDB;
                                  $sql    = 'SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE id_type='" . $xoopsDB->escape($type) . "'";
                                  $result = $xoopsDB->query($sql);
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $sel_id is not named in camelCase.
                          Open

                              public static function updateUserRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $usid = Request::getInt('usid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $nom_type is not named in camelCase.
                          Open

                              public static function getNameType($type)
                              {
                                  global $xoopsDB;
                                  $sql    = 'SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE id_type='" . $xoopsDB->escape($type) . "'";
                                  $result = $xoopsDB->query($sql);
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $sel_id is not named in camelCase.
                          Open

                              public static function getTotalItems($sel_id, $status = ''): int
                              {
                                  global $xoopsDB, $mytree;
                                  $categories = self::getMyItemIds('adslight_view');
                                  $count      = 0;
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $sel_id is not named in camelCase.
                          Open

                              public static function updateItemRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $lid = Request::getInt('lid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $sel_id is not named in camelCase.
                          Open

                              public static function updateItemRating($sel_id): void
                              {
                                  global $xoopsDB;
                          
                                  $lid = Request::getInt('lid', 0, 'GET');
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          The variable $sel_id is not named in camelCase.
                          Open

                              public static function getTotalItems($sel_id, $status = ''): int
                              {
                                  global $xoopsDB, $mytree;
                                  $categories = self::getMyItemIds('adslight_view');
                                  $count      = 0;
                          Severity: Minor
                          Found in class/Utility.php by phpmd

                          CamelCaseVariableName

                          Since: 0.2

                          It is considered best practice to use the camelCase notation to name variables.

                          Example

                          class ClassName {
                              public function doSomething() {
                                  $data_module = new DataModule();
                              }
                          }

                          Source

                          There are no issues that match your filters.

                          Category
                          Status