adslight_absolutize accesses the super-global variable $_SERVER.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

adslight_absolutize accesses the super-global variable $_SERVER.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

adslight_absolutize accesses the super-global variable $_SERVER.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

adslight_absolutize accesses the super-global variable $_SERVER.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

adslight_absolutize accesses the super-global variable $_SERVER.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

adslight_absolutize accesses the super-global variable $_SERVER.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method `adslight_seo_title` has 132 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function adslight_seo_title($title = '', $withExt = false)
{
    /**
     * if XOOPS ML is present, let's sanitize the title with the current language
     */

Found in seo_url.php - About 5 hrs to fix

File `seo_url.php` has 253 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.

Found in seo_url.php - About 2 hrs to fix

Method `adslight_absolutize` has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php - About 1 hr to fix

Function `replaceLinks` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 311.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 315.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 313.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 312.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

The method adslight_seo_title has a boolean flag argument $withExt, which is a certain sign of a Single Responsibility Principle violation.
Open

function adslight_seo_title($title = '', $withExt = false)

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method replaceLinks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    return $matches['0'];
                }

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\XoopsDatabaseFactory' in method 'adslight_seo_cat'.
Open

    $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\MyTextSanitizer' in method 'adslight_seo_title'.
Open

    $myts = \MyTextSanitizer::getInstance();

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method replaceLinks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    return $matches['0'];
                }

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\XoopsDatabaseFactory' in method 'adslight_seo_titre'.
Open

    $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method adslight_absolutize uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

    } else {
        $req_dir = dirname($_SERVER['REQUEST_URI']);
        $req_php = preg_replace('/.*(\/[a-zA-Z0-9_\-]+)\.php.*/', '\\1.php', $_SERVER['REQUEST_URI']);
    }

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$req_php'.
Open

        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$d5'.
Open

    $d5      = @str_replace('/' . $dir_arr[$m - 4], '', $d4);

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function adslight_seo_cat($cid)
{
    /** @var \XoopsMySQLDatabase $xoopsDB */
    $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();
    $sql     = ' SELECT title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid = ' . $cid . ' ';

Found in seo_url.php and 1 other location - About 2 hrs to fix

Read up
Read up

seo_url.php on lines 123..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 128.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 128.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $d4. Configured minimum length is 3.
Open

    $d4      = @str_replace('/' . $dir_arr[$m - 3], '', $d3);

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $d5. Configured minimum length is 3.
Open

    $d5      = @str_replace('/' . $dir_arr[$m - 4], '', $d4);

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $d1. Configured minimum length is 3.
Open

    $d1      = @str_replace('/' . $dir_arr[$m], '', $req_dir);

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $d2. Configured minimum length is 3.
Open

    $d2      = @str_replace('/' . $dir_arr[$m - 1], '', $d1);

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $in. Configured minimum length is 3.
Open

    $in      = [

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $m. Configured minimum length is 3.
Open

    $m       = count($dir_arr) - 1;

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $s. Configured minimum length is 3.
Open

function adslight_absolutize($s)

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $d3. Configured minimum length is 3.
Open

    $d3      = @str_replace('/' . $dir_arr[$m - 2], '', $d2);

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 26 and the first side effect is on line 29.
Open

<?php declare(strict_types=1);

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 147 characters
Open

        '/<(a|meta)([^>]*)(href|url)=([\'\"]{0,1})' . $XPS_URL . '\/modules\/' . $module_name . '\/(viewcats.php)([^>\'\"]*)([\'\"]{1})([^>]*)>/i',

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 181 characters
Open

    return '<' . $matches[1] . $matches[2] . $matches[3] . '=' . $matches[4] . XOOPS_URL . '/' . SEO_MODULE_NAME . '/' . $add_to_url . $req_string . $matches[7] . $matches[8] . '>';

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 146 characters
Open

        '/<(a|meta)([^>]*)(href|url)=([\'\"]{0,1})' . $XPS_URL . '\/modules\/' . $module_name . '\/(viewads.php)([^>\'\"]*)([\'\"]{1})([^>]*)>/i',

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 285 characters
Open

    //                 Tab     Space      !        "        #        %        &        '        (        )        ,        /        :        ;        <        =        >        ?        @        [        \        ]        ^        {        |        }        ~       .                 +

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 122 characters
Open

        '/<([^>\?\&]*)(href|src|action|background|window\.location)=([\"\']{1})([^#]{1}[^\/\"\'>]*)([\"\']{1})([^>]*)>/i',

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 192 characters
Open

        '/<([^>\?\&]*)(href|src|action|background|window\.location)=([\"\']{1})(?:\.\/)?([^\"\'\/:]*\/*)?([^\"\'\/:]*\/*)?([^\"\'\/:]*\/*)?([a-zA-Z0-9_\-]+)\.([^\"\'>]*)([\"\']{1})([^>]*)>/i',

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 176 characters
Open

    //                  °        è        é        ê        ë        ç        à        â        ä        î        ï        ù        ü        û        ô        ö

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 130 characters
Open

        '/<([^>\?\&]*)(href|src|action|background|window\.location)=([\"\']{1})\.\.\/\.\.\/\.\.\/([^\"\']*)([\"\']{1})([^>]*)>/i',

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 123 characters
Open

        '/<([^>\?\&]*)(href|src|action|background|window\.location)=([\"\']{1})\?([^\"\']*)([\"\']{1})([^>]*)>/i'//This dir

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 144 characters
Open

        '/<(a|meta)([^>]*)(href|url)=([\'\"]{0,1})' . $XPS_URL . '\/modules\/' . $module_name . '\/(index.php)([^>\'\"]*)([\'\"]{1})([^>]*)>/i',

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line exceeds 120 characters; contains 124 characters
Open

        '/<([^>\?\&]*)(href|src|action|background|window\.location)=([\"\']{1})\.\.\/\.\.\/([^\"\']*)([\"\']{1})([^>]*)>/i',

Found in seo_url.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

The variable $add_to_url is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rep_pat is not named in camelCase.
Open

function adslight_seo_title($title = '', $withExt = false)
{
    /**
     * if XOOPS ML is present, let's sanitize the title with the current language
     */

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $module_name is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $XPS_URL is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rep_pat is not named in camelCase.
Open

function adslight_seo_title($title = '', $withExt = false)
{
    /**
     * if XOOPS ML is present, let's sanitize the title with the current language
     */

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $module_name is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $XPS_URL is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rep_pat is not named in camelCase.
Open

function adslight_seo_title($title = '', $withExt = false)
{
    /**
     * if XOOPS ML is present, let's sanitize the title with the current language
     */

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_php is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_php is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_string is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $add_to_url is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $XPS_URL is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $add_to_url is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $add_to_url is not named in camelCase.
Open

function replaceLinks($matches): string
{
    $req_string = [];
    $add_to_url = '';
    switch ($matches[5]) {

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $module_name is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $XPS_URL is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rep_pat is not named in camelCase.
Open

function adslight_seo_title($title = '', $withExt = false)
{
    /**
     * if XOOPS ML is present, let's sanitize the title with the current language
     */

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $module_name is not named in camelCase.
Open

function seo_urls($s)
{
    $XPS_URL = str_replace('/', '\/', quotemeta(XOOPS_URL));
    $s       = adslight_absolutize($s); // Fix URLs and HTML.

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $dir_arr is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $dir_arr is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $dir_arr is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $dir_arr is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $dir_arr is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $dir_arr is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $dir_arr is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $req_dir is not named in camelCase.
Open

function adslight_absolutize($s)
{
    if (preg_match('/\/$/', $_SERVER['REQUEST_URI'])) {
        $req_dir = preg_replace('/\/$/', '', $_SERVER['REQUEST_URI']);
        $req_php = '';

Found in seo_url.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

mambax7/adslight

Summary

Maintainability

Test Coverage

adslight_absolutize accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

adslight_absolutize accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

adslight_absolutize accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

adslight_absolutize accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

adslight_absolutize accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

adslight_absolutize accesses the super-global variable $_SERVER. Open

Superglobals

Since: 0.2

Example

Source

Method adslight_seo_title has 132 lines of code (exceeds 25 allowed). Consider refactoring. Open

File seo_url.php has 253 lines of code (exceeds 250 allowed). Consider refactoring. Open

Method adslight_absolutize has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open

Function replaceLinks has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Method replaceLinks has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open

The function adslight_seo_title() has 150 lines of code. Current threshold is set to 100. Avoid really long methods. Open

Remove error control operator '@' on line 314. Open

ErrorControlOperator

Example

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 311. Open

ErrorControlOperator

Example

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 315. Open

ErrorControlOperator

Example

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 313. Open

ErrorControlOperator

Example

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 312. Open

ErrorControlOperator

Example

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

The method adslight_seo_title has a boolean flag argument $withExt, which is a certain sign of a Single Responsibility Principle violation. Open

BooleanArgumentFlag

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method replaceLinks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open

ElseExpression

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\XoopsDatabaseFactory' in method 'adslight_seo_cat'. Open

StaticAccess

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\MyTextSanitizer' in method 'adslight_seo_title'. Open

StaticAccess

adslight_absolutize accesses the super-global variable $_SERVER.
Open

adslight_absolutize accesses the super-global variable $_SERVER.
Open

adslight_absolutize accesses the super-global variable $_SERVER.
Open

adslight_absolutize accesses the super-global variable $_SERVER.
Open

adslight_absolutize accesses the super-global variable $_SERVER.
Open

adslight_absolutize accesses the super-global variable $_SERVER.
Open

Method `adslight_seo_title` has 132 lines of code (exceeds 25 allowed). Consider refactoring.
Open

File `seo_url.php` has 253 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Method `adslight_absolutize` has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Function `replaceLinks` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

Method `replaceLinks` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

The function adslight_seo_title() has 150 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

Remove error control operator '@' on line 314.
Open

Remove error control operator '@' on line 311.
Open

Remove error control operator '@' on line 315.
Open

Remove error control operator '@' on line 313.
Open

Remove error control operator '@' on line 312.
Open

The method adslight_seo_title has a boolean flag argument $withExt, which is a certain sign of a Single Responsibility Principle violation.
Open

The method replaceLinks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

Avoid using static access to class '\XoopsDatabaseFactory' in method 'adslight_seo_cat'.
Open

Avoid using static access to class '\MyTextSanitizer' in method 'adslight_seo_title'.
Open

The method replaceLinks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

Avoid using static access to class '\XoopsDatabaseFactory' in method 'adslight_seo_titre'.
Open

The method adslight_absolutize uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

Avoid unused local variables such as '$req_php'.
Open

Avoid unused local variables such as '$d5'.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Avoid variables with short names like $s. Configured minimum length is 3.
Open

Avoid variables with short names like $d4. Configured minimum length is 3.
Open

Avoid variables with short names like $d5. Configured minimum length is 3.
Open