mambax7/alumni-26x

View on GitHub
class/form/listing.php

Summary

Maintainability
B
6 hrs
Test Coverage

__construct accesses the super-global variable $_REQUEST.
Open

    public function __construct(AlumniListing $obj)
    {
        $xoops = Xoops::getInstance();

        if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
Severity: Minor
Found in class/form/listing.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_REQUEST.
Open

    public function __construct(AlumniListing $obj)
    {
        $xoops = Xoops::getInstance();

        if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
Severity: Minor
Found in class/form/listing.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method __construct has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(AlumniListing $obj)
    {
        $xoops = Xoops::getInstance();

        if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
Severity: Major
Found in class/form/listing.php - About 4 hrs to fix

    Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method __construct() has 123 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    The method __construct() has an NPath complexity of 4096. The configured NPath complexity threshold is 200.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method __construct() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The class AlumniListingForm has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13.
    Open

    class AlumniListingForm extends Xoops\Form\ThemeForm
    {
        /**
         * @param \AlumniListing $obj
         */
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
        /**
         * @var \foo\bar\X
         */
        private $x = null;
    
        /**
         * @var \foo\bar\Y
         */
        private $y = null;
    
        /**
         * @var \foo\bar\Z
         */
        private $z = null;
    
        public function setFoo(\Foo $foo) {}
        public function setBar(\Bar $bar) {}
        public function setBaz(\Baz $baz) {}
    
        /**
         * @return \SplObjectStorage
         * @throws \OutOfRangeException
         * @throws \InvalidArgumentException
         * @throws \ErrorException
         */
        public function process(\Iterator $it) {}
    
        // ...
    }

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '104', column '44').
    Open

            $fileseltray_photo->addElement(new Xoops\Form\File(AlumniLocale::FORMUPLOAD, 'photo', $xoops->getModuleConfig('alumni_photomax')), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '108', column '37').
    Open

                $imgtray_checkbox = new Xoops\Form\Checkbox('', 'del_photo', 0);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '148', column '35').
    Open

                $this->addElement(new XoopsFormHidden('date', time()));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '76', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::NAME_2, 'name', 50, 255, $obj->getVar('name')), true);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '89', column '31').
    Open

            $this->addElement(new Xoops\Form\Editor(AlumniLocale::ACTIVITIES, 'activities', $editor_configs), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '125', column '38').
    Open

                $imgtray_checkbox2 = new Xoops\Form\Checkbox('', 'del_photo2', 0);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '98', column '31').
    Open

            $this->addElement(new Xoops\Form\Editor(AlumniLocale::EXTRAINFO, 'extrainfo', $editor_configs), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '101', column '37').
    Open

            $imgtray_photo        = new Xoops\Form\ElementTray(AlumniLocale::GRAD_PHOTO, '<br>');
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '103', column '37').
    Open

            $fileseltray_photo    = new Xoops\Form\ElementTray('', '<br>');
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '118', column '38').
    Open

            $imgtray_photo2        = new Xoops\Form\ElementTray(AlumniLocale::NOW_PHOTO, '<br>');
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '120', column '38').
    Open

            $fileseltray_photo2    = new Xoops\Form\ElementTray('', '<br>');
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '137', column '35').
    Open

                $this->addElement(new Xoops\Form\RadioYesNo(AlumniLocale::APPROVE_2, 'valid', $obj->getVar('valid'), XoopsLocale::YES, XoopsLocale::NO));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '140', column '35').
    Open

                $this->addElement(new Xoops\Form\Captcha());
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '153', column '31').
    Open

            $this->addElement(new Xoops\Form\Button('', 'submit', XoopsLocale::A_SUBMIT, 'submit'));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '124', column '49').
    Open

                $fileseltray_photo2->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/now_photo/' . $photo2_old . '">' . $photo2_old . '</a>', false));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '134', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::TOWN_2, 'town', 50, 255, $obj->getVar('town')), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '143', column '31').
    Open

            $this->addElement(new Xoops\Form\Hidden('security', $xoops->security()->createToken()));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '152', column '31').
    Open

            $this->addElement(new Xoops\Form\Hidden('op', 'save_listing'));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '66', column '35').
    Open

            $mytree             = new XoopsObjectTree($categories, 'cid', 'pid');
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '77', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::MNAME_2, 'mname', 50, 255, $obj->getVar('mname')), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '133', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::OCC_2, 'occ', 50, 255, $obj->getVar('occ')), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '79', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::CLASS_OF_2, 'year', 50, 255, $obj->getVar('year')), true);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '107', column '48').
    Open

                $fileseltray_photo->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/grad_photo/' . $photo_old . '">' . $photo_old . '</a>', false));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '132', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::EMAIL_2, 'email', 50, 255, $obj->getVar('email')), true);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '151', column '31').
    Open

            $this->addElement(new Xoops\Form\Hidden('usid', $xoops->user->uid()));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '58', column '32').
    Open

            $mytree          = new XoopsObjectTree($categories, 'cid', 'pid');
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '131', column '31').
    Open

            $this->addElement(new Xoops\Form\Hidden('photo2_old', $photo2_old));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '68', column '31').
    Open

            $this->addElement(new Xoops\Form\Label(AlumniLocale::SCHOOL, $category_select), true);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '80', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::STUDIES_2, 'studies', 50, 255, $obj->getVar('studies')), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '74', column '31').
    Open

            $this->addElement(new Xoops\Form\Hidden('school', $cat_name));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '114', column '31').
    Open

            $this->addElement(new Xoops\Form\Hidden('photo_old', $photo_old));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '150', column '31').
    Open

            $this->addElement(new Xoops\Form\Hidden('submitter', $xoops->user->uname()));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '54', column '31').
    Open

            $this->addElement(new Xoops\Form\Label(AlumniLocale::SUBMITTER, $xoops->user->uname()));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '78', column '31').
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::LNAME_2, 'lname', 50, 255, $obj->getVar('lname')), true);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '121', column '45').
    Open

            $fileseltray_photo2->addElement(new Xoops\Form\File(AlumniLocale::FORMUPLOAD, 'photo2', $xoops->getModuleConfig('alumni_photomax')), false);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '146', column '35').
    Open

                $this->addElement(new Xoops\Form\Hidden('date', $_REQUEST['date']));
    Severity: Minor
    Found in class/form/listing.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                $this->addElement(new XoopsFormHidden('date', time()));
            }
    Severity: Minor
    Found in class/form/listing.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Xoops' in method '__construct'.
    Open

            $xoops = Xoops::getInstance();
    Severity: Minor
    Found in class/form/listing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                $this_cid = $obj->getVar('cid');
            }
    Severity: Minor
    Found in class/form/listing.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Xoops\Core\Request' in method '__construct'.
    Open

                $this_cid = Request::getInt('cid', 0);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                $title = sprintf($obj->isNew() ? AlumniLocale::ADD_LISTING : AlumniLocale::EDIT_LISTING);
            }
    Severity: Minor
    Found in class/form/listing.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Xoops\Core\Request' in method '__construct'.
    Open

            $lid = Request::getInt('lid', 0);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused local variables such as '$imgpath_photo2'.
    Open

            $imgpath_photo2        = sprintf(AlumniLocale::FORMIMAGE_PATH, $uploadirectory_photo2);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$lid'.
    Open

            $lid = Request::getInt('lid', 0);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$imgpath_photo'.
    Open

            $imgpath_photo        = sprintf(AlumniLocale::FORMIMAGE_PATH, $uploadirectory_photo);
    Severity: Minor
    Found in class/form/listing.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$userGroups'.
    Open

            $userGroups     = $member_handler->getGroupList();
    Severity: Minor
    Found in class/form/listing.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if ($photo_old) {
                $fileseltray_photo->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/grad_photo/' . $photo_old . '">' . $photo_old . '</a>', false));
                $imgtray_checkbox = new Xoops\Form\Checkbox('', 'del_photo', 0);
                $imgtray_checkbox->addOption(1, AlumniLocale::DELPICT);
                $fileseltray_photo->addElement($imgtray_checkbox);
    Severity: Minor
    Found in class/form/listing.php and 2 other locations - About 40 mins to fix
    class/form/category.php on lines 83..88
    class/form/listing.php on lines 123..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if ($photo2_old) {
                $fileseltray_photo2->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/now_photo/' . $photo2_old . '">' . $photo2_old . '</a>', false));
                $imgtray_checkbox2 = new Xoops\Form\Checkbox('', 'del_photo2', 0);
                $imgtray_checkbox2->addOption(1, AlumniLocale::DELPICT);
                $fileseltray_photo2->addElement($imgtray_checkbox2);
    Severity: Minor
    Found in class/form/listing.php and 2 other locations - About 40 mins to fix
    class/form/category.php on lines 83..88
    class/form/listing.php on lines 106..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid excessively long variable names like $uploadirectory_photo2. Keep variable name length under 20.
    Open

            $uploadirectory_photo2 = XOOPS_ROOT_PATH . '/modules/alumni/photos/now_photo';
    Severity: Minor
    Found in class/form/listing.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class AlumniListingForm extends Xoops\Form\ThemeForm
    Severity: Minor
    Found in class/form/listing.php by phpcodesniffer

    Line exceeds 120 characters; contains 167 characters
    Open

                $fileseltray_photo->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/grad_photo/' . $photo_old . '">' . $photo_old . '</a>', false));
    Severity: Minor
    Found in class/form/listing.php by phpcodesniffer

    Line exceeds 120 characters; contains 169 characters
    Open

                $fileseltray_photo2->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/now_photo/' . $photo2_old . '">' . $photo2_old . '</a>', false));
    Severity: Minor
    Found in class/form/listing.php by phpcodesniffer

    Line exceeds 120 characters; contains 149 characters
    Open

                $this->addElement(new Xoops\Form\RadioYesNo(AlumniLocale::APPROVE_2, 'valid', $obj->getVar('valid'), XoopsLocale::YES, XoopsLocale::NO));
    Severity: Minor
    Found in class/form/listing.php by phpcodesniffer

    Line exceeds 120 characters; contains 146 characters
    Open

            $fileseltray_photo->addElement(new Xoops\Form\File(AlumniLocale::FORMUPLOAD, 'photo', $xoops->getModuleConfig('alumni_photomax')), false);
    Severity: Minor
    Found in class/form/listing.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

            $this->addElement(new Xoops\Form\Text(AlumniLocale::STUDIES_2, 'studies', 50, 255, $obj->getVar('studies')), false);
    Severity: Minor
    Found in class/form/listing.php by phpcodesniffer

    Line exceeds 120 characters; contains 148 characters
    Open

            $fileseltray_photo2->addElement(new Xoops\Form\File(AlumniLocale::FORMUPLOAD, 'photo2', $xoops->getModuleConfig('alumni_photomax')), false);
    Severity: Minor
    Found in class/form/listing.php by phpcodesniffer

    The variable $categories_Handler is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $uploadirectory_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgpath_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo2_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $cat_name is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $uploadirectory_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_checkbox2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $member_handler is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $this_cid is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_checkbox is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $category_select is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $this_cid is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo2_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $this_cid is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo2_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $categories_Handler is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_checkbox is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_checkbox is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $uploadirectory_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo2_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $categories_Handler is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $member_handler is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $uploadirectory_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $fileseltray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $photo2_old is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $categories_Handler is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $cat_name is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_checkbox2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $category_select is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $cat_name is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $editor_configs is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_checkbox2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgpath_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_photo is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $imgtray_photo2 is not named in camelCase.
    Open

        public function __construct(AlumniListing $obj)
        {
            $xoops = Xoops::getInstance();
    
            if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
    Severity: Minor
    Found in class/form/listing.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status