Sign upLogin

mambax7/alumni-26x

View on GitHub
Star
class/groupperm.php

Summary

Maintainability
D
1 day
Test Coverage

Function updatePerms has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
Severity: Minor
Found in class/groupperm.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updatePerms has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
Severity: Major
Found in class/groupperm.php - About 2 hrs to fix

    Method checkRight has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    Severity: Minor
    Found in class/groupperm.php - About 35 mins to fix

      The method updatePerms() has an NPath complexity of 729. The configured NPath complexity threshold is 200.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method updatePerms() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '97', column '32').
      Open

                  $criteria->add(new Criteria('gperm_itemid', $cid));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '86', column '32').
      Open

                  $criteria->add(new Criteria('gperm_itemid', $cid));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '96', column '41').
      Open

                  $criteria = $criteria = new CriteriaCompo();
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '89', column '32').
      Open

                  $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups1_delete) . ')', 'IN'));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '85', column '41').
      Open

                  $criteria = $criteria = new CriteriaCompo();
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '98', column '32').
      Open

                  $criteria->add(new Criteria('gperm_modid', $module_id));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '99', column '32').
      Open

                  $criteria->add(new Criteria('gperm_name', 'alumni_premium', '='));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '76', column '32').
      Open

                  $criteria->add(new Criteria('gperm_modid', $module_id));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '75', column '32').
      Open

                  $criteria->add(new Criteria('gperm_itemid', $cid));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '87', column '32').
      Open

                  $criteria->add(new Criteria('gperm_modid', $module_id));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method checkRight has a boolean flag argument $trueifadmin, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
      Severity: Minor
      Found in class/groupperm.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '74', column '41').
      Open

                  $criteria = $criteria = new CriteriaCompo();
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '77', column '32').
      Open

                  $criteria->add(new Criteria('gperm_name', 'alumni_view', '='));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '78', column '32').
      Open

                  $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups_delete) . ')', 'IN'));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '88', column '32').
      Open

                  $criteria->add(new Criteria('gperm_name', 'alumni_submit', '='));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '100', column '32').
      Open

                  $criteria->add(new Criteria('gperm_groupid', '(' . implode(', ', $groups2_delete) . ')', 'IN'));
      Severity: Minor
      Found in class/groupperm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (0 != count($groups1_delete)) {
            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_submit', '='));
      Severity: Major
      Found in class/groupperm.php and 2 other locations - About 3 hrs to fix
      class/groupperm.php on lines 73..81
      class/groupperm.php on lines 95..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (0 != count($groups_delete)) {
            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_view', '='));
      Severity: Major
      Found in class/groupperm.php and 2 other locations - About 3 hrs to fix
      class/groupperm.php on lines 84..92
      class/groupperm.php on lines 95..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (0 != count($groups2_delete)) {
            $criteria = $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('gperm_itemid', $cid));
            $criteria->add(new Criteria('gperm_modid', $module_id));
            $criteria->add(new Criteria('gperm_name', 'alumni_premium', '='));
      Severity: Major
      Found in class/groupperm.php and 2 other locations - About 3 hrs to fix
      class/groupperm.php on lines 73..81
      class/groupperm.php on lines 84..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Each class must be in a namespace of at least one level (a top-level vendor name)
      Open

      class AlumniGroupPermHandler extends XoopsGroupPermHandler
      Severity: Minor
      Found in class/groupperm.php by phpcodesniffer

      The parameter $gperm_groupid is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      The parameter $gperm_name is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      The parameter $gperm_itemid is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      The parameter $gperm_modid is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
    public function doSomething($user_name) {
    }
}

      Source

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 31 and the first side effect is on line 26.
      Open

      <?php
      Severity: Minor
      Found in class/groupperm.php by phpcodesniffer

      The variable $group_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $group_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $gperm_groupid is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $gperm_name is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $group_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $gperm_modid is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $group_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_exists is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $gperm_itemid is not named in camelCase.
      Open

          public function checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid = 1, $trueifadmin = true)
    {
        return parent::checkRight($gperm_name, $gperm_itemid, $gperm_groupid, $gperm_modid, $trueifadmin);
    }
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups1_add is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $group_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $group_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $module_id is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $groups2_delete is not named in camelCase.
      Open

          public function updatePerms($cid, $groups = [])
    {
        $module_id = Alumni::getInstance()->getModule()->getVar('mid');

        $groups_exists = parent::getGroupIds('alumni_view', $cid, $module_id);
      Severity: Minor
      Found in class/groupperm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status