Avoid using static access to class 'Alumni' in method '__construct'. Open
$this->alumni = Alumni::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Xoops' in method 'deletePermissions'. Open
$xoops = Xoops::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Xoops' in method 'saveItemPermissions'. Open
$xoops = Xoops::getInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method isGranted uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return false;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class AlumniPermissionHandler extends XoopsObjectHandler- Exclude checks
Avoid variables with short names like $qb. Configured minimum length is 3. Open
$qb = $this->db2->createXoopsQueryBuilder();- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
public function getGrantedGroupsById($gperm_name, $id)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $gperm_name is not named in camelCase. Open
public function isGranted($gperm_name, $id)
{
if (!$id) {
return false;
}- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 34 and the first side effect is on line 29. Open
<?php- Exclude checks
Avoid variables with short names like $qb. Configured minimum length is 3. Open
$qb = $this->db2->createXoopsQueryBuilder();- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The parameter $perm_name is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $gperm_name is not named in camelCase. Open
public function getGrantedItems($gperm_name)
{
static $items;
if (isset($items[$gperm_name])) {
return $items[$gperm_name];- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $gperm_name is not named in camelCase. Open
public function getGrantedGroupsById($gperm_name, $id)
{
static $items;
if (isset($items[$gperm_name][$id])) {
return $items[$gperm_name][$id];- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $gperm_name is not named in camelCase. Open
public function deletePermissions($itemid, $gperm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$gperm_handler = $xoops->getHandlerGroupPermission();- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
Avoid variables with short names like $id. Configured minimum length is 3. Open
public function isGranted($gperm_name, $id)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The variable $gperm_name is not named in camelCase. Open
public function isGranted($gperm_name, $id)
{
if (!$id) {
return false;
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $group_id is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $group_id is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedItems($gperm_name)
{
static $items;
if (isset($items[$gperm_name])) {
return $items[$gperm_name];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_handler is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $module_id is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedGroupsById($gperm_name, $id)
{
static $items;
if (isset($items[$gperm_name][$id])) {
return $items[$gperm_name][$id];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedGroupsById($gperm_name, $id)
{
static $items;
if (isset($items[$gperm_name][$id])) {
return $items[$gperm_name][$id];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedItems($gperm_name)
{
static $items;
if (isset($items[$gperm_name])) {
return $items[$gperm_name];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_handler is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $perm_name is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedItems($gperm_name)
{
static $items;
if (isset($items[$gperm_name])) {
return $items[$gperm_name];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_handler is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedGroupsById($gperm_name, $id)
{
static $items;
if (isset($items[$gperm_name][$id])) {
return $items[$gperm_name][$id];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $module_id is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedItems($gperm_name)
{
static $items;
if (isset($items[$gperm_name])) {
return $items[$gperm_name];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $group_id is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_handler is not named in camelCase. Open
public function deletePermissions($itemid, $gperm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$gperm_handler = $xoops->getHandlerGroupPermission();- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_handler is not named in camelCase. Open
public function deletePermissions($itemid, $gperm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$gperm_handler = $xoops->getHandlerGroupPermission();- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $module_id is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function deletePermissions($itemid, $gperm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$gperm_handler = $xoops->getHandlerGroupPermission();- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gperm_name is not named in camelCase. Open
public function getGrantedGroupsById($gperm_name, $id)
{
static $items;
if (isset($items[$gperm_name][$id])) {
return $items[$gperm_name][$id];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $perm_name is not named in camelCase. Open
public function saveItemPermissions($groups, $itemid, $perm_name)
{
$xoops = Xoops::getInstance();
$result = true;
$module_id = $this->alumni->getModule()->getVar('mid');- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}