Sign upLogin

mambax7/alumni-26x

View on GitHub
Star
include/functions.php

Summary

Maintainability
C
1 day
Test Coverage

Method alumni_convertorderbyin has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function alumni_convertorderbyin($orderby)
{
    switch (trim($orderby)) {
        case 'nameA':
            $orderby = 'lname ASC';
Severity: Minor
Found in include/functions.php - About 1 hr to fix

    Function alumni_convertorderbyin has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    function alumni_convertorderbyin($orderby)
{
    switch (trim($orderby)) {
        case 'nameA':
            $orderby = 'lname ASC';
    Severity: Minor
    Found in include/functions.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method alumni_convertorderbytrans has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
    Severity: Minor
    Found in include/functions.php - About 1 hr to fix

      Method alumni_convertorderbyout has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function alumni_convertorderbyout($orderby)
{
    if ('lname ASC' === $orderby) {
        $orderby = 'nameA';
    }
      Severity: Minor
      Found in include/functions.php - About 1 hr to fix

        Function alumni_convertorderbytrans has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function alumni_convertorderbyout has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        function alumni_convertorderbyout($orderby)
{
    if ('lname ASC' === $orderby) {
        $orderby = 'nameA';
    }
        Severity: Minor
        Found in include/functions.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The function alumni_convertorderbytrans() has an NPath complexity of 4096. The configured NPath complexity threshold is 200.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The function alumni_convertorderbyout() has an NPath complexity of 4096. The configured NPath complexity threshold is 200.
        Open

        function alumni_convertorderbyout($orderby)
{
    if ('lname ASC' === $orderby) {
        $orderby = 'nameA';
    }
        Severity: Minor
        Found in include/functions.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The function alumni_convertorderbyin() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
        Open

        function alumni_convertorderbyin($orderby)
{
    switch (trim($orderby)) {
        case 'nameA':
            $orderby = 'lname ASC';
        Severity: Minor
        Found in include/functions.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The function alumni_convertorderbytrans() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The function alumni_convertorderbyout() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
        Open

        function alumni_convertorderbyout($orderby)
{
    if ('lname ASC' === $orderby) {
        $orderby = 'nameA';
    }
        Severity: Minor
        Found in include/functions.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 26 and the first side effect is on line 21.
        Open

        <?php
        Severity: Minor
        Found in include/functions.php by phpcodesniffer

        Line exceeds 120 characters; contains 158 characters
        Open

            echo "'" . XOOPS_URL . "/modules/{$moduleDirName}/assets/images/schools/' + document.imcat.scphoto.options[document.imcat.scphoto.selectedIndex].value\n";
        Severity: Minor
        Found in include/functions.php by phpcodesniffer

        Line exceeds 120 characters; contains 146 characters
        Open

            echo "'" . XOOPS_URL . "/modules/{$moduleDirName}/assets/images/cat/' + document.imcat.img.options[document.imcat.img.selectedIndex].value\n";
        Severity: Minor
        Found in include/functions.php by phpcodesniffer

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $main_lang is not named in camelCase.
        Open

        function alumni_convertorderbytrans($orderby)
{
    global $main_lang;

    if ('view ASC' === $orderby) {
        Severity: Minor
        Found in include/functions.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        There are no issues that match your filters.

        Category
        Status