mambax7/cardealer

View on GitHub
class/Common/VersionChecks.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\XoopsModule' in method 'checkVerXoops'.
Open

            $module = \XoopsModule::getByDirname($moduleDirName);
Severity: Minor
Found in class/Common/VersionChecks.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Line exceeds 120 characters; contains 127 characters
Open

            $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_XOOPS'), $requiredVer, $currentVer));

There are no issues that match your filters.

Category
Status