mambax7/cardealer

View on GitHub

Showing 664 of 664 total issues

Blank line found at start of control structure
Open

        if ($servpartCount > $servpartPaginationLimit) {
Severity: Minor
Found in servpart.php by phpcodesniffer

Expected 1 blank line at end of file; 2 found
Open

}
Severity: Minor
Found in class/Workserv.php by phpcodesniffer

The CASE body must start on the line following the statement
Open

    case 'clone':
Severity: Minor
Found in admin/part.php by phpcodesniffer

Blank line found at start of control structure
Open

            foreach (array_keys($vehicleTempArray) as $i) {
Severity: Minor
Found in admin/vehicle.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

Scope keyword "public" must be followed by a single space
Open

    public  $dirname;
Severity: Minor
Found in class/Common/Breadcrumb.php by phpcodesniffer

Missing class import via use statement (line '79', column '24').
Open

    $criteria->add(new Criteria('itemnum', 0, '!='));
Severity: Minor
Found in blocks/service.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '48', column '28').
Open

        $criteria->add(new \Criteria('id', 0, '!='));
Severity: Minor
Found in blocks/workorder.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '81', column '24').
Open

    $criteria->add(new Criteria('id', 0, '!='));
Severity: Minor
Found in blocks/workorder.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '39', column '31').
Open

                    throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
Severity: Minor
Found in class/Common/FilesManagement.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Remove error control operator '@' on line 106.
Open

    public static function xcopy($source, $dest)
    {
        // Check for symlinks
        if (is_link($source)) {
            return symlink(readlink($source), $dest);
Severity: Minor
Found in class/Common/FilesManagement.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Missing class import via use statement (line '151', column '33').
Open

                $fileInfo = new \SplFileInfo("{$src}/{$v}");
Severity: Minor
Found in class/Common/FilesManagement.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '88', column '31').
Open

        $this->addElement(new \XoopsFormButton('', 'submit', _SUBMIT, 'submit'));
Severity: Minor
Found in class/Form/CustomerForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '94', column '28').
Open

        $imgtray     = new \XoopsFormElementTray(AM_CARDEALER_PART_PICTURE, '<br>');
Severity: Minor
Found in class/Form/PartForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '104', column '28').
Open

        $fileseltray = new \XoopsFormElementTray('', '<br>');
Severity: Minor
Found in class/Form/PartForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '78', column '34').
Open

        $service_id_select = new \XoopsFormSelect(AM_CARDEALER_SERVPART_ITEMNUM, 'itemnum', $this->targetObject->getVar('itemnum'));
Severity: Minor
Found in class/Form/ServpartForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '99', column '31').
Open

        $this->addElement(new \XoopsFormText(AM_CARDEALER_VEHICLE_SERIALNUM, 'serialnum', 50, 255, $this->targetObject->getVar('serialnum')), false);
Severity: Minor
Found in class/Form/VehicleForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '101', column '31').
Open

        $this->addElement(new \XoopsFormHidden('op', 'save'));
Severity: Minor
Found in class/Form/VehicleForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '79', column '24').
Open

    $criteria->add(new Criteria('custnum', 0, '!='));
Severity: Minor
Found in blocks/customer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '83', column '31').
Open

            $descEditor = new \XoopsFormDhtmlTextArea(AM_CARDEALER_CUSTOMER_CUSTADDR, 'description', $this->targetObject->getVar('description', 'e'), '100%', '100%');
Severity: Minor
Found in class/Form/CustomerForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language