Sign upLogin

mambax7/extcal

View on GitHub
Star
class/pear/Calendar/Factory.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method create has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function create($type, $y = 2000, $m = 1, $d = 1, $h = 0, $i = 0, $s = 0)
    {
        $firstDay = defined('CALENDAR_FIRST_DAY_OF_WEEK') ? CALENDAR_FIRST_DAY_OF_WEEK : 1;
        switch ($type) {
            case 'Day':
Severity: Minor
Found in class/pear/Calendar/Factory.php - About 1 hr to fix

    Method create has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function create($type, $y = 2000, $m = 1, $d = 1, $h = 0, $i = 0, $s = 0)
    Severity: Major
    Found in class/pear/Calendar/Factory.php - About 50 mins to fix

      Avoid too many return statements within this method.
      Open

                      return false;
      Severity: Major
      Found in class/pear/Calendar/Factory.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return new Calendar_Year($y);
        Severity: Major
        Found in class/pear/Calendar/Factory.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return new Calendar_Second($y, $m, $d, $h, $i, $s);
          Severity: Major
          Found in class/pear/Calendar/Factory.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return new Calendar_Minute($y, $m, $d, $h, $i);
            Severity: Major
            Found in class/pear/Calendar/Factory.php - About 30 mins to fix

              Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function create($type, $y = 2000, $m = 1, $d = 1, $h = 0, $i = 0, $s = 0)
    {
        $firstDay = defined('CALENDAR_FIRST_DAY_OF_WEEK') ? CALENDAR_FIRST_DAY_OF_WEEK : 1;
        switch ($type) {
            case 'Day':
              Severity: Minor
              Found in class/pear/Calendar/Factory.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status