Sign upLogin

mambax7/extgallery

View on GitHub
Star
admin/perm-quota.php

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        foreach ($modulePermArray as $perm) {
            if ($op != $perm['name']) {
                continue;
            }
Severity: Major
Found in admin/perm-quota.php and 1 other location - About 1 day to fix
admin/perm-quota.php on lines 166..198

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 250.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        foreach ($pluginPermArray as $perm) {
            if ($op != $perm['name']) {
                continue;
            }
Severity: Major
Found in admin/perm-quota.php and 1 other location - About 1 day to fix
admin/perm-quota.php on lines 132..164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 250.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        foreach ($modulePermArray as $perm) {
            if ($op == $perm['name']) {
                echo "<option value='" . $perm['name'] . '\' selected>' . constant($perm['title']) . "</option>\n";
            } else {
                echo "<option value='" . $perm['name'] . '\'>' . constant($perm['title']) . "</option>\n";
Severity: Minor
Found in admin/perm-quota.php and 1 other location - About 30 mins to fix
admin/perm-quota.php on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        foreach ($pluginPermArray as $perm) {
            if ($op == $perm['name']) {
                echo "<option value='" . $perm['name'] . '\' selected>' . constant($perm['title']) . "</option>\n";
            } else {
                echo "<option value='" . $perm['name'] . '\'>' . constant($perm['title']) . "</option>\n";
Severity: Minor
Found in admin/perm-quota.php and 1 other location - About 30 mins to fix
admin/perm-quota.php on lines 107..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid variables with short names like $v. Configured minimum length is 3.
Open

        function getChecked($array, $v)
Severity: Minor
Found in admin/perm-quota.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 87 and the first side effect is on line 22.
Open

<?php
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

The DEFAULT body must start on the line following the statement
Open

    default:
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 243 characters
Open

        echo '<fieldset id="defaultBookmark"><legend><a href="#defaultBookmark" style="font-weight:bold; color:#990000;" onClick="toggle(\'default\'); toggleIcon(\'defaultIcon\');"><img id="defaultIcon" src="../assets/images/minus.gif">&nbsp;'
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 227 characters
Open

                echo '<td class="' . $style . '" style="text-align:center;"><input name="perms[extgallery_public_mask][group][' . $k . '][' . $perm['maskId'] . ']" type="checkbox"' . getChecked($permAccessGroup, $k) . '></td>';
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

            echo '<fieldset><legend style="font-weight:bold; color:#0A3760;">' . _AM_EXTGALLERY_INFORMATION . '</legend>';
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 151 characters
Open

            $form = new Extgallery\GroupPermForm(constant($perm['title']), $module_id, $perm['name'], constant($perm['desc']), 'admin/perm-quota.php');
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

            echo '<fieldset><legend style="font-weight:bold; color:#0A3760;">' . _AM_EXTGALLERY_INFORMATION . '</legend>';
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 121 characters
Open

                $permAccessGroup = $grouppermHandler->getGroupIds('extgallery_public_mask', $perm['maskId'], $module_id);
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 152 characters
Open

        echo '<tr><td colspan="' . $nbPerm . '" style="text-align:center;" class="head"><input type="submit" value="' . _SUBMIT . '"></td></tr></form>';
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 151 characters
Open

            $form = new Extgallery\GroupPermForm(constant($perm['title']), $module_id, $perm['name'], constant($perm['desc']), 'admin/perm-quota.php');
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 227 characters
Open

                echo '<td class="' . $style . '" style="text-align:center;"><input name="perms[extgallery_public_mask][group][' . $k . '][' . $perm['maskId'] . ']" type="checkbox"' . getChecked($permAccessGroup, $k) . '></td>';
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

Line exceeds 120 characters; contains 121 characters
Open

                $permAccessGroup = $grouppermHandler->getGroupIds('extgallery_public_mask', $perm['maskId'], $module_id);
Severity: Minor
Found in admin/perm-quota.php by phpcodesniffer

There are no issues that match your filters.

Category
Status