class/Common/Migrate.php
Function convertIPAddresses has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
private function convertIPAddresses($tableName, $columnName)
{
if ($this->tableHandler->useTable($tableName)) {
$attributes = $this->tableHandler->getColumnAttributes($tableName, $columnName);
if (false !== mb_strpos($attributes, ' int(')) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused private methods such as 'convertIPAddresses'. Open
Open
private function convertIPAddresses($tableName, $columnName)
{
if ($this->tableHandler->useTable($tableName)) {
$attributes = $this->tableHandler->getColumnAttributes($tableName, $columnName);
if (false !== mb_strpos($attributes, ' int(')) {- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod
Avoid unused private methods such as 'moveDoColumns'. Open
Open
private function moveDoColumns()
{
//for an example, see newbb 5.0
}- Read upRead up
- Exclude checks
UnusedPrivateMethod
Since: 0.2
Unused Private Method detects when a private method is declared but is unused.
Example
class Something
{
private function foo() {} // unused
}Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod
There must be one blank line after the last USE statement; 2 found; Open
Open
use XoopsModules\Extgallery;- Exclude checks
Line exceeds 120 characters; contains 137 characters Open
Open
$this->tableHandler->update($tableName, [$columnName => "4294967296 + $columnName"], "WHERE $columnName < 0", false);- Exclude checks