mambax7/extgallery

View on GitHub
class/PluginHandler.php

Summary

Maintainability
A
35 mins
Test Coverage

Function triggerEvent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function triggerEvent($event, &$param)
    {
        require XOOPS_ROOT_PATH . '/modules/extgallery/plugin/plugin.php';
        if (is_iterable($extgalleryPlugin)) {
            foreach ($extgalleryPlugin as $plugin => $status) {
Severity: Minor
Found in class/PluginHandler.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused local variables such as '$extgalleryPlugin'.
Open

        foreach ($extgalleryPlugin as $plugin => $status) {
Severity: Minor
Found in class/PluginHandler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$db'.
Open

    public function __construct(XoopsDatabase $db = null)
Severity: Minor
Found in class/PluginHandler.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct(XoopsDatabase $db = null)
Severity: Minor
Found in class/PluginHandler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There must be one blank line after the last USE statement; 2 found;
Open

use XoopsModules\Extgallery;
Severity: Minor
Found in class/PluginHandler.php by phpcodesniffer

There are no issues that match your filters.

Category
Status