Sign upLogin

mambax7/extgallery

View on GitHub
Star
class/pclerror.lib.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused local variables such as '$g_pcl_error_code'.
Open

        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$g_pcl_error_string'.
Open

        global $g_pcl_error_string;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The function PclErrorFatal() contains an exit expression.
Open

        exit($v_message);
Severity: Minor
Found in class/pclerror.lib.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

Avoid unused local variables such as '$g_pcl_error_string'.
Open

        global $g_pcl_error_string;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The parameter $p_error_code is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $p_error_string is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $p_error_string is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $p_file is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $p_line is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 44 and the first side effect is on line 44.
Open

<?php
Severity: Minor
Found in class/pclerror.lib.php by phpcodesniffer

Line exceeds 120 characters; contains 190 characters
Open

        $v_message .= "<p align=center><span bgcolor=white style='color: #ff0000; font-weight: bold;'>PclError Library has detected a fatal error on file '$p_file', line $p_line</span></p>";
Severity: Minor
Found in class/pclerror.lib.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

        $v_message .= "<p align=center><span bgcolor=white style='color: #ff0000; font-weight: bold;'>$p_error_string</span></p>";
Severity: Minor
Found in class/pclerror.lib.php by phpcodesniffer

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $v_message is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $v_message is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorString()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $v_message is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorReset()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $v_message is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorCode()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorString()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorReset()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorCode()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $v_message is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorString()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $p_line is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $p_error_string is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $p_error_code is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $p_file is not named in camelCase.
Open

    function PclErrorFatal($p_file, $p_line, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_string is not named in camelCase.
Open

    function PclErrorReset()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorReset()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorString()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorCode()
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $g_pcl_error_code is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $p_error_string is not named in camelCase.
Open

    function PclErrorLog($p_error_code = 0, $p_error_string = '')
    {
        global $g_pcl_error_string;
        global $g_pcl_error_code;
Severity: Minor
Found in class/pclerror.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status