mambax7/extgallery

View on GitHub
class/pear/Image/Transform/Driver/image_type_to_mime_type.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method image_type_to_mime_type has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function image_type_to_mime_type($type)
{
    switch ($type) {
        case IMAGETYPE_GIF:
            return 'image/gif';
Severity: Minor
Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return 'image/bmp';
    Severity: Major
    Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return 'image/tiff';
      Severity: Major
      Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return 'image/xbm';
        Severity: Major
        Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return 'image/jp2';
          Severity: Major
          Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return 'application/x-shockwave-flash';
            Severity: Major
            Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return 'application/octect-stream';
              Severity: Major
              Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return 'image/iff';
                Severity: Major
                Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return 'image/vnd.wap.wbmp';
                  Severity: Major
                  Found in class/pear/Image/Transform/Driver/image_type_to_mime_type.php - About 30 mins to fix

                    The function image_type_to_mime_type() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
                    Open

                    function image_type_to_mime_type($type)
                    {
                        switch ($type) {
                            case IMAGETYPE_GIF:
                                return 'image/gif';

                    CyclomaticComplexity

                    Since: 0.1

                    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                    Example

                    // Cyclomatic Complexity = 11
                    class Foo {
                    1   public function example() {
                    2       if ($a == $b) {
                    3           if ($a1 == $b1) {
                                    fiddle();
                    4           } elseif ($a2 == $b2) {
                                    fiddle();
                                } else {
                                    fiddle();
                                }
                    5       } elseif ($c == $d) {
                    6           while ($c == $d) {
                                    fiddle();
                                }
                    7        } elseif ($e == $f) {
                    8           for ($n = 0; $n < $h; $n++) {
                                    fiddle();
                                }
                            } else {
                                switch ($z) {
                    9               case 1:
                                        fiddle();
                                        break;
                    10              case 2:
                                        fiddle();
                                        break;
                    11              case 3:
                                        fiddle();
                                        break;
                                    default:
                                        fiddle();
                                        break;
                                }
                            }
                        }
                    }

                    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 15 and the first side effect is on line 8.
                    Open

                    <?php

                    There are no issues that match your filters.

                    Category
                    Status