Sign upLogin

mambax7/extgallery

View on GitHub
Star
class/plugins/plugin.tag.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function extgallery_tag_iteminfo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
Severity: Minor
Found in class/plugins/plugin.tag.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extgallery_tag_iteminfo has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
Severity: Minor
Found in class/plugins/plugin.tag.php - About 1 hr to fix

    Method extgallery_tag_synchronization has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function extgallery_tag_synchronization($mid)
{
    global $XoopsDB;
    /** @var Extgallery\PublicPhotoHandler $itemHandler */
    $itemHandler = Extgallery\Helper::getInstance()->getHandler('PublicPhoto');
    Severity: Minor
    Found in class/plugins/plugin.tag.php - About 1 hr to fix

      Missing class import via use statement (line '26', column '49').
      Open

          $items_obj   = $itemHandler->getObjects(new \Criteria('photo_id', '(' . implode(', ', $items_id) . ')', 'IN'), true);
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method extgallery_tag_synchronization uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          else :
        $sql = "    DELETE {$linkHandler->table} FROM {$linkHandler->table}"
               . "    LEFT JOIN {$itemHandler->table} AS aa ON {$linkHandler->table}.tag_itemid = aa.{$itemHandler->keyName} "
               . '    WHERE '
               . "        tag_modid = {$mid}"
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid assigning values to variables in if clauses and the like (line '81', column '10').
      Open

      function extgallery_tag_synchronization($mid)
{
    global $XoopsDB;
    /** @var Extgallery\PublicPhotoHandler $itemHandler */
    $itemHandler = Extgallery\Helper::getInstance()->getHandler('PublicPhoto');
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid unused local variables such as '$result'.
      Open

          if (!$result = $linkHandler->db->queryF($sql)) {
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Line exceeds 120 characters; contains 121 characters
      Open

          $items_obj   = $itemHandler->getObjects(new \Criteria('photo_id', '(' . implode(', ', $items_id) . ')', 'IN'), true);
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpcodesniffer

      Line exceeds 120 characters; contains 126 characters
      Open

                     . "    LEFT JOIN {$itemHandler->table} AS aa ON {$linkHandler->table}.tag_itemid = aa.{$itemHandler->keyName} "
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpcodesniffer

      The variable $items_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $items_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $cat_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $items_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $cat_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $items_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $cat_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $cat_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $items_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $items_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $XoopsDB is not named in camelCase.
      Open

      function extgallery_tag_synchronization($mid)
{
    global $XoopsDB;
    /** @var Extgallery\PublicPhotoHandler $itemHandler */
    $itemHandler = Extgallery\Helper::getInstance()->getHandler('PublicPhoto');
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $items_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $XoopsDB is not named in camelCase.
      Open

      function extgallery_tag_synchronization($mid)
{
    global $XoopsDB;
    /** @var Extgallery\PublicPhotoHandler $itemHandler */
    $itemHandler = Extgallery\Helper::getInstance()->getHandler('PublicPhoto');
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_obj is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $item_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $cat_id is not named in camelCase.
      Open

      function extgallery_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
      Severity: Minor
      Found in class/plugins/plugin.tag.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status