Sign upLogin

mambax7/extgallery

View on GitHub
Star

Showing 9,653 of 9,653 total issues

The property $strong_regex is not named in camelCase.
Open

class Parsedown
{
    #
    # Multiton (http://en.wikipedia.org/wiki/Multiton_pattern)
    #
Severity: Minor
Found in assets/js/magnific_popup/redaxo/magnific_popup/classes/class.parsedown.inc.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $rm. Configured minimum length is 3.
Open

    $rm = file_exists($path);
Severity: Minor
Found in admin/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db = \XoopsDatabaseFactory::getDatabaseConnection();
Severity: Minor
Found in testdata/index.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $container_height is not named in camelCase.
Open

class MetaSliderImageHelper
{
    private $smart_crop = 'false';
    private $container_width; // slideshow width
    private $container_height; // slideshow height
Severity: Minor
Found in assets/js/ml-slider/inc/metaslider.imagehelper.class.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    private $id; // slide/attachment ID
Severity: Minor
Found in assets/js/ml-slider/inc/metaslider.imagehelper.class.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $em_strong_regex is not named in camelCase.
Open

class Parsedown
{
    #
    # Multiton (http://en.wikipedia.org/wiki/Multiton_pattern)
    #
Severity: Minor
Found in assets/js/magnific_popup/redaxo/magnific_popup/classes/class.parsedown.inc.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $breaks_enabled is not named in camelCase.
Open

    public function set_breaks_enabled($breaks_enabled)
    {
        $this->break_marker = $breaks_enabled ? "\n" : "  \n";

        return $this;
Severity: Minor
Found in assets/js/magnific_popup/redaxo/magnific_popup/classes/class.parsedown.inc.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $f. Configured minimum length is 3.
Open

    while (false !== ($f = readdir($dir))) {
Severity: Minor
Found in admin/watermark-border.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function set_slide($id)
Severity: Minor
Found in assets/js/ml-slider/inc/slide/metaslide.class.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $f. Configured minimum length is 3.
Open

    $f  = @fopen($path, 'ab');
Severity: Minor
Found in admin/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $view_mode is not named in camelCase.
Open

function magnific_popup_field_formatter_settings_summary($field, $instance, $view_mode) {
  $display = $instance['display'][$view_mode];
  $settings = $display['settings'];
  $gallery_options = _magnific_popup_gallery_options();
  $summary = t('Gallery Type: @gallery_type', ['@gallery_type' => $gallery_options[$settings['gallery_style']]]);
Severity: Minor
Found in assets/js/magnific_popup/drupal/magnific_popup/includes/magnific_popup.formatters.inc by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db      = \XoopsDatabaseFactory::getDatabaseConnection();
Severity: Minor
Found in admin/blocksadmin.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $s. Configured minimum length is 3.
Open

    $s     = stat($dir);
Severity: Minor
Found in admin/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $dest_file_name is not named in camelCase.
Open

    private function resize_image($orig_size, $dest_size, $dest_file_name)
    {
        // load image
        $image = wp_get_image_editor($this->path);
Severity: Minor
Found in assets/js/ml-slider/inc/metaslider.imagehelper.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $new_instance is not named in camelCase.
Open

    public function update($new_instance, $old_instance)
    {
        $instance              = [];
        $instance['slider_id'] = strip_tags($new_instance['slider_id']);
        $instance['title']     = strip_tags($new_instance['title']);
Severity: Minor
Found in assets/js/ml-slider/inc/metaslider.widget.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db                 = \XoopsDatabaseFactory::getDatabaseConnection();
Severity: Minor
Found in admin/blocksadmin.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $v2. Configured minimum length is 3.
Open

function compareVersion($v1, $v2)
Severity: Minor
Found in admin/moduleUpdateFunction.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $use_image_editor is not named in camelCase.
Open

class MetaSliderImageHelper
{
    private $smart_crop = 'false';
    private $container_width; // slideshow width
    private $container_height; // slideshow height
Severity: Minor
Found in assets/js/ml-slider/inc/metaslider.imagehelper.class.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $slide_id is not named in camelCase.
Open

    public function __construct($slide_id, $width, $height, $smart_crop, $use_image_editor = true)
    {
        $upload_dir = wp_upload_dir();

        $this->id               = $slide_id;
Severity: Minor
Found in assets/js/ml-slider/inc/metaslider.imagehelper.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $dest_size is not named in camelCase.
Open

    private function get_destination_file_name($dest_size)
    {
        $info           = pathinfo($this->path);
        $dir            = $info['dirname'];
        $ext            = $info['extension'];
Severity: Minor
Found in assets/js/ml-slider/inc/metaslider.imagehelper.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Severity
Category
Status
Source
Language