Sign upLogin

mambax7/gwiki

View on GitHub
Star
ajaxfileedit.php

Summary

Maintainability
D
1 day
Test Coverage

File ajaxfileedit.php has 334 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * ajaxfileedit.php - backend upload attachments and update file info
 *
 * @copyright  Copyright © 2013 geekwright, LLC. All rights reserved.
Severity: Minor
Found in ajaxfileedit.php - About 4 hrs to fix

    Method getExtensionInfo has 87 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getExtensionInfo($filename)
{
    global $whitelist;

    $fi = [];
    Severity: Major
    Found in ajaxfileedit.php - About 3 hrs to fix

      Method updateData has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function updateData(&$input)
{
    global $xoopsDB, $xoopsUser, $wikiPage;

    $q_file_id          = (int)$input['file_id'];
      Severity: Minor
      Found in ajaxfileedit.php - About 1 hr to fix

        Method updateFile has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function updateFile($newfile, &$input)
{
    global $uploadpath, $xoopsDB;
    // For now, images are stored in individual directories for each page.
    // We can change the directory distribution later, as the entire path
        Severity: Minor
        Found in ajaxfileedit.php - About 1 hr to fix

          Function getExtensionInfo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function getExtensionInfo($filename)
{
    global $whitelist;

    $fi = [];
          Severity: Minor
          Found in ajaxfileedit.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function updateFile($newfile, &$input)
{
    global $uploadpath, $xoopsDB;
    // For now, images are stored in individual directories for each page.
    // We can change the directory distribution later, as the entire path
          Severity: Minor
          Found in ajaxfileedit.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function deleteData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          function deleteData(&$input)
{
    global $xoopsDB, $uploadpath, $wikiPage;

    $q_file_id = (int)$input['file_id'];
          Severity: Minor
          Found in ajaxfileedit.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function updateData(&$input)
{
    global $xoopsDB, $xoopsUser, $wikiPage;

    $q_file_id          = (int)$input['file_id'];
          Severity: Minor
          Found in ajaxfileedit.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          function getUserName($uid)
{
    global $xoopsConfig;

    $uid = (int)$uid;
          Severity: Major
          Found in ajaxfileedit.php and 1 other location - About 1 hr to fix
          ajaxfilelist.php on lines 42..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status