mambax7/mymenus

View on GitHub

Showing 93 of 115 total issues

File Blocksadmin.php has 610 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace XoopsModules\Mymenus\Common;

/**
Severity: Major
Found in class/Common/Blocksadmin.php - About 1 day to fix

    Method listBlocks has 229 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function listBlocks()
        : void
        {
            global $xoopsModule, $pathIcon16;
            require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
    Severity: Major
    Found in class/Common/Blocksadmin.php - About 1 day to fix

      Function xoops_module_update_mymenus has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
      Open

      function xoops_module_update_mymenus(\XoopsObject $xoopsModule, $previousVersion)
      {
          if ($previousVersion < 151) {
              //if (!checkInfoTemplates($xoopsModule)) return false;
              if (!Updater::checkInfoTable($xoopsModule)) {
      Severity: Minor
      Found in include/onupdate.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function methods has 209 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var methods = (function () {
              // private properties and methods go here
              var c = {
                      bcClass: 'sf-breadcrumb',
                      menuClass: 'sf-js-enabled',
      Severity: Major
      Found in assets/js/superfish.js - About 1 day to fix

        Function methods has 209 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var methods = (function () {
                // private properties and methods go here
                var c = {
                        bcClass: 'sf-breadcrumb',
                        menuClass: 'sf-js-enabled',
        Severity: Major
        Found in assets/js/superfish1.7.10/js/superfish.js - About 1 day to fix

          Function truncateHtml has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true)
              {
                  if ($considerHtml) {
                      // if the plain text is shorter than the maximum length, return the whole text
                      if (mb_strlen(\preg_replace('/<.*?' . '>/', '', $text)) <= $length) {
          Severity: Minor
          Found in class/Common/SysUtility.php - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _mouseDrag has 119 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _mouseDrag: function (event) {
          
                      //Compute the helpers position
                      this.position = this._generatePosition(event);
                      this.positionAbs = this._convertPositionTo("absolute");
          Severity: Major
          Found in assets/js/nestedSortable.js - About 4 hrs to fix

            Function listBlocks has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
            Open

                public function listBlocks()
                : void
                {
                    global $xoopsModule, $pathIcon16;
                    require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
            Severity: Minor
            Found in class/Common/Blocksadmin.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method render has 97 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function render(?array $block = null)
                {
                    \xoops_load('XoopsFormLoader');
                    \xoops_loadLanguage('common', $this->moduleDirNameUpper);
            
            
            Severity: Major
            Found in class/Common/Blocksadmin.php - About 3 hrs to fix

              Method mymenus_block_show has 95 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function mymenus_block_show($options)
              {
                  global $xoopsTpl, $xoopsLogger;
              
                  if (!class_exists(Helper::class)) {
              Severity: Major
              Found in blocks/mymenus_block.php - About 3 hrs to fix

                File nestedSortable.js has 311 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*
                 * jQuery UI Nested Sortable
                 * v 1.3.5 / 21 jun 2012
                 * http://mjsarfatti.com/code/nestedSortable
                 *
                Severity: Minor
                Found in assets/js/nestedSortable.js - About 3 hrs to fix

                  Function mymenus_block_show has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function mymenus_block_show($options)
                  {
                      global $xoopsTpl, $xoopsLogger;
                  
                      if (!class_exists(Helper::class)) {
                  Severity: Minor
                  Found in blocks/mymenus_block.php - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method editLink has 78 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function editLink($id = null, $pid = null, $mid = null)
                      {
                          $helper = Helper::getInstance();
                          //
                          // Disable xoops debugger in dialog window
                  Severity: Major
                  Found in class/LinksUtility.php - About 3 hrs to fix

                    Function createUpdateTable has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function createUpdateTable($table, $tablename, \XoopsObject $module)
                        {
                            if (!InfoTableExists($GLOBALS['xoopsDB']->prefix($module->getInfo('dirname')) . $tablename)) {
                                $sql = 'CREATE TABLE ' . $GLOBALS['xoopsDB']->prefix($module->getInfo('dirname')) . $tablename . ' (';
                                foreach ($table as $s => $w) {
                    Severity: Minor
                    Found in class/Updater.php - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function updateBlock has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function updateBlock(int $bid, string $btitle, string $bside, string $bweight, string $bvisible, string $bcachetime, ?array $bmodule, ?array $options, ?array $groups)
                        : void {
                            $myblock = new \XoopsBlock($bid);
                            $myblock->setVar('title', $btitle);
                            $myblock->setVar('weight', $bweight);
                    Severity: Minor
                    Found in class/Common/Blocksadmin.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function orderBlock has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function orderBlock(
                            array $bid,
                            array $oldtitle,
                            array $oldside,
                            array $oldweight,
                    Severity: Minor
                    Found in class/Common/Blocksadmin.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function checkVerModule has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function checkVerModule(\Xmf\Module\Helper $helper, ?string $source = 'github', ?string $default = 'master'): ?array
                        {
                            $moduleDirName      = \basename(\dirname(__DIR__, 2));
                            $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
                            $update             = '';
                    Severity: Minor
                    Found in class/Common/VersionChecks.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method mymenus_block_edit has 68 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function mymenus_block_edit($options)
                    {
                        /** @var \XoopsModules\Mymenus\Helper $helper */
                        $helper = Helper::getInstance();
                    
                    
                    Severity: Major
                    Found in blocks/mymenus_block.php - About 2 hrs to fix

                      Function getSkinInfo has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public static function getSkinInfo($moduleSkin = 'default', $useThemeSkin = false, $themeSkin = '')
                          {
                              //    require __DIR__ . '/common.php';
                              /** @var \XoopsModules\Mymenus\Helper $helper */
                              $helper = Helper::getInstance();
                      Severity: Minor
                      Found in class/Utility.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method truncateHtml has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true)
                          {
                              if ($considerHtml) {
                                  // if the plain text is shorter than the maximum length, return the whole text
                                  if (mb_strlen(\preg_replace('/<.*?' . '>/', '', $text)) <= $length) {
                      Severity: Major
                      Found in class/Common/SysUtility.php - About 2 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language