mambax7/publisher

View on GitHub
admin/item.php

Summary

Maintainability
F
4 days
Test Coverage

File item.php has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);
/*
 You may not change or alter any portion of this comment or credits
Severity: Minor
Found in admin/item.php - About 6 hrs to fix

    Method publisher_editItem has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
    {
        $helper = Helper::getInstance();
        global $publisherCurrentPage;
    
    
    Severity: Major
    Found in admin/item.php - About 4 hrs to fix

      Function publisher_editItem has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

      function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
      {
          $helper = Helper::getInstance();
          global $publisherCurrentPage;
      
      
      Severity: Minor
      Found in admin/item.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The function publisher_editItem() has an NPath complexity of 456. The configured NPath complexity threshold is 200.
      Open

      function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
      {
          $helper = Helper::getInstance();
          global $publisherCurrentPage;
      
      
      Severity: Minor
      Found in admin/item.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The function publisher_editItem() has 155 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

      function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
      {
          $helper = Helper::getInstance();
          global $publisherCurrentPage;
      
      
      Severity: Minor
      Found in admin/item.php by phpmd

      The function publisher_editItem() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
      Open

      function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
      {
          $helper = Helper::getInstance();
          global $publisherCurrentPage;
      
      
      Severity: Minor
      Found in admin/item.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method publisher_editItem has a boolean flag argument $showmenu, which is a certain sign of a Single Responsibility Principle violation.
      Open

      function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
      Severity: Minor
      Found in admin/item.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '543', column '27').
      Open

          $form->addElement(new \XoopsFormHidden('backto', $publisherCurrentPage));
      Severity: Minor
      Found in admin/item.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '526', column '17').
      Open

          $form = new \XoopsThemeForm(_CO_PUBLISHER_DELETEFILE, 'form_name', 'pw_delete_file.php');
      Severity: Minor
      Found in admin/item.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method publisher_editItem has a boolean flag argument $clone, which is a certain sign of a Single Responsibility Principle violation.
      Open

      function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
      Severity: Minor
      Found in admin/item.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '540', column '19').
      Open

          $submit = new \XoopsFormButton('', 'submit', _AM_PUBLISHER_BUTTON_DELETE, 'submit');
      Severity: Minor
      Found in admin/item.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '400', column '20').
      Open

          $formTpl = new \XoopsTpl();
      Severity: Minor
      Found in admin/item.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '528', column '24').
      Open

          $pWrapSelect = new \XoopsFormSelect(Utility::getUploadDir(true, 'content'), 'address');
      Severity: Minor
      Found in admin/item.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '539', column '27').
      Open

          $form->addElement(new \XoopsFormHidden('op', $delfile));
      Severity: Minor
      Found in admin/item.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_editItem'.
      Open

          $dir = Utility::getUploadDir(true, 'content');
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method publisher_editItem uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

          } else {
              // there's no parameter, so we're adding an item
              /** @var Item $itemObj */
              $itemObj = $helper->getHandler('Item')->create();
              $itemObj->setVarsFromRequest();
      Severity: Minor
      Found in admin/item.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\Xmf\Request' in method 'publisher_editItem'.
      Open

              $categoryObj->setVar('categoryid', Request::getInt('categoryid', 0, 'GET'));
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_editItem'.
      Open

              Utility::openCollapsableBar('createitemtable', 'createitemicon', _AM_PUBLISHER_ITEM_CREATING, _AM_PUBLISHER_ITEM_CREATING_DSC);
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_editItem'.
      Open

          Utility::closeCollapsableBar('edititemtable', 'edititemicon');
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_editItem'.
      Open

          Utility::closeCollapsableBar('pagewraptable', 'pagewrapicon');
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_editItem'.
      Open

          Utility::openCollapsableBar('pagewraptable', 'pagewrapicon', _AM_PUBLISHER_PAGEWRAP, _AM_PUBLISHER_PAGEWRAPDSC);
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Helper' in method 'publisher_editItem'.
      Open

          $helper = Helper::getInstance();
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_editItem'.
      Open

              Utility::openCollapsableBar('edititemtable', 'edititemicon', $pageTitle, $pageInfo);
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'publisher_editItem'.
      Open

          $pWrapSelect = new \XoopsFormSelect(Utility::getUploadDir(true, 'content'), 'address');
      Severity: Minor
      Found in admin/item.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid unused local variables such as '$breadcrumbAction2'.
      Open

                      $breadcrumbAction2 = _AM_PUBLISHER_APPROVING;
      Severity: Minor
      Found in admin/item.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$breadcrumbAction1'.
      Open

                      $breadcrumbAction1 = _CO_PUBLISHER_SUBMITTED;
      Severity: Minor
      Found in admin/item.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused parameters such as '$showmenu'.
      Open

      function publisher_editItem($showmenu = false, $itemId = 0, $clone = false)
      Severity: Minor
      Found in admin/item.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
      {
          private function bar($howdy)
          {
              // $howdy is not used
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      Avoid unused local variables such as '$newStatus'.
      Open

                      $newStatus         = Constants::PUBLISHER_STATUS_PUBLISHED;
      Severity: Minor
      Found in admin/item.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$buttonCaption'.
      Open

                      $buttonCaption     = _AM_PUBLISHER_APPROVE;
      Severity: Minor
      Found in admin/item.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ($totalitems > 0) {
                  for ($i = 0; $i < $totalItemsOnPage; ++$i) {
                      $categoryObj = $itemsObj[$i]->getCategory();
      
                      $modify = "<a href='item.php?op=mod&itemid=" . $itemsObj[$i]->itemid() . "'>" . $icons['edit'] . '</a>';
      Severity: Major
      Found in admin/item.php and 1 other location - About 1 day to fix
      admin/item.php on lines 246..270

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 312.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ($totalitems > 0) {
                  for ($i = 0; $i < $totalItemsOnPage; ++$i) {
                      $categoryObj = $itemsObj[$i]->getCategory();
      
                      $modify = "<a href='item.php?op=mod&itemid=" . $itemsObj[$i]->itemid() . "'>" . $icons['edit'] . '</a>';
      Severity: Major
      Found in admin/item.php and 1 other location - About 1 day to fix
      admin/item.php on lines 300..324

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 312.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 393 and the first side effect is on line 29.
      Open

      <?php
      Severity: Minor
      Found in admin/item.php by phpcodesniffer

      There must be one USE keyword per declaration
      Open

      use XoopsModules\Publisher\{Constants,
      Severity: Minor
      Found in admin/item.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status