mambax7/publisher

View on GitHub
class/Cloner.php

Summary

Maintainability
B
5 hrs
Test Coverage

createLogo accesses the super-global variable $GLOBALS.
Open

    public static function createLogo($dirname)
    {
        if (!\extension_loaded('gd')) {
            return false;
        }
Severity: Minor
Found in class/Cloner.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createLogo accesses the super-global variable $GLOBALS.
Open

    public static function createLogo($dirname)
    {
        if (!\extension_loaded('gd')) {
            return false;
        }
Severity: Minor
Found in class/Cloner.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createLogo accesses the super-global variable $GLOBALS.
Open

    public static function createLogo($dirname)
    {
        if (!\extension_loaded('gd')) {
            return false;
        }
Severity: Minor
Found in class/Cloner.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function cloneFileFolder has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public static function cloneFileFolder($path)
    {
        global $patKeys;
        global $patValues;

Severity: Minor
Found in class/Cloner.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createLogo has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function createLogo($dirname)
    {
        if (!\extension_loaded('gd')) {
            return false;
        }
Severity: Minor
Found in class/Cloner.php - About 1 hr to fix

    Method cloneFileFolder has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function cloneFileFolder($path)
        {
            global $patKeys;
            global $patValues;
    
    
    Severity: Minor
    Found in class/Cloner.php - About 1 hr to fix

      Function createLogo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function createLogo($dirname)
          {
              if (!\extension_loaded('gd')) {
                  return false;
              }
      Severity: Minor
      Found in class/Cloner.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '26', column '27').
      Open

                      throw new \RuntimeException(\sprintf('Directory "%s" was not created', $newPath));
      Severity: Minor
      Found in class/Cloner.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid assigning values to variables in if clauses and the like (line '81', column '30').
      Open

          public static function createLogo($dirname)
          {
              if (!\extension_loaded('gd')) {
                  return false;
              }
      Severity: Minor
      Found in class/Cloner.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid assigning values to variables in if clauses and the like (line '80', column '27').
      Open

          public static function createLogo($dirname)
          {
              if (!\extension_loaded('gd')) {
                  return false;
              }
      Severity: Minor
      Found in class/Cloner.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      The method cloneFileFolder uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      // file, read it
                      $content = file_get_contents($path);
                      $content = \str_replace($patKeys, $patValues, $content);
                      file_put_contents($newPath, $content);
      Severity: Minor
      Found in class/Cloner.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method cloneFileFolder uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $noChangeExtensions = ['jpeg', 'jpg', 'gif', 'png', 'zip', 'ttf'];
                  if (\in_array(\mb_strtolower(\pathinfo($path, \PATHINFO_EXTENSION)), $noChangeExtensions, true)) {
                      // image
                      \copy($path, $newPath);
      Severity: Minor
      Found in class/Cloner.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      There are no issues that match your filters.

      Category
      Status