mambax7/publisher

View on GitHub
class/Form/ItemForm.php

Summary

Maintainability
F
4 days
Test Coverage

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

createElements accesses the super-global variable $GLOBALS.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Minor
Found in class/Form/ItemForm.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method createElements has 408 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createElements($obj)
    {
        $helper     = Helper::getInstance();
        $timeoffset = null;
        $configurator = new Configurator();
Severity: Major
Found in class/Form/ItemForm.php - About 2 days to fix

    Function createElements has a Cognitive Complexity of 86 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createElements($obj)
        {
            $helper     = Helper::getInstance();
            $timeoffset = null;
            $configurator = new Configurator();
    Severity: Minor
    Found in class/Form/ItemForm.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ItemForm.php has 496 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    declare(strict_types=1);
    
    namespace XoopsModules\Publisher\Form;
    Severity: Minor
    Found in class/Form/ItemForm.php - About 7 hrs to fix

      The class ItemForm has an overall complexity of 75 which is very high. The configured complexity threshold is 50.
      Open

      class ItemForm extends ThemeTabForm
      {
          public $checkperm = true;
          public $tabs      = [
              \_CO_PUBLISHER_TAB_MAIN   => 'mainTab',
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      The method createElements() has 564 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      The method createElements() has an NPath complexity of 2532770467282944. The configured NPath complexity threshold is 200.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method createElements() has a Cyclomatic Complexity of 67. The configured cyclomatic complexity threshold is 10.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The class ItemForm has a coupling between objects value of 23. Consider to reduce the number of dependencies under 13.
      Open

      class ItemForm extends ThemeTabForm
      {
          public $checkperm = true;
          public $tabs      = [
              \_CO_PUBLISHER_TAB_MAIN   => 'mainTab',
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
          /**
           * @var \foo\bar\X
           */
          private $x = null;
      
          /**
           * @var \foo\bar\Y
           */
          private $y = null;
      
          /**
           * @var \foo\bar\Z
           */
          private $z = null;
      
          public function setFoo(\Foo $foo) {}
          public function setBar(\Bar $bar) {}
          public function setBaz(\Baz $baz) {}
      
          /**
           * @return \SplObjectStorage
           * @throws \OutOfRangeException
           * @throws \InvalidArgumentException
           * @throws \ErrorException
           */
          public function process(\Iterator $it) {}
      
          // ...
      }

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Missing class import via use statement (line '249', column '37').
      Open

                      $smiley_radio = new \XoopsFormRadioYN(\_CO_PUBLISHER_DOSMILEY, 'dosmiley', $obj->dosmiley(), _YES, _NO);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '442', column '56').
      Open

                      $criteria     = new \CriteriaCompo(new \Criteria('imgcat_id', '(' . \implode(',', $catids) . ')', 'IN'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '469', column '33').
      Open

                  $buttonremove = new \XoopsFormButton('', 'buttonremove', \_CO_PUBLISHER_REMOVE);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '692', column '28').
      Open

              $butt_cancel = new \XoopsFormButton('', '', \_CO_PUBLISHER_CANCEL, 'button');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '173', column '35').
      Open

                  $this->addElement(new \XoopsFormText(\_CO_PUBLISHER_SUBTITLE, 'subtitle', 50, 255, $obj->getVar('subtitle', 'e')));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '456', column '32').
      Open

                  $imageSelect = new \XoopsFormSelect('', 'image_notused', '', 5);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '668', column '38').
      Open

                  $addcomments_radio = new \XoopsFormRadioYN(\_CO_PUBLISHER_ALLOWCOMMENTS, 'allowcomments', $obj->cancomment(), _YES, _NO);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '163', column '35').
      Open

              $categoryFormSelect = new \XoopsFormSelect(\_CO_PUBLISHER_CATEGORY, 'categoryid', $obj->getVar('categoryid', 'e'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '245', column '34').
      Open

                      $htmlRadio = new \XoopsFormRadioYN(\_CO_PUBLISHER_DOHTML, 'dohtml', $obj->dohtml(), _YES, _NO);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '253', column '36').
      Open

                      $xcode_radio = new \XoopsFormRadioYN(\_CO_PUBLISHER_DOXCODE, 'doxcode', $obj->doxcode(), _YES, _NO);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '475', column '31').
      Open

                  $closetable = new \XoopsFormLabel('', '</td></tr></table>');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '652', column '39').
      Open

                  $text_meta_keywords = new \XoopsFormTextArea(\_CO_PUBLISHER_ITEM_META_KEYWORDS, 'item_meta_keywords', $obj->meta_keywords('e'), 7, 60);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '257', column '36').
      Open

                      $image_radio = new \XoopsFormRadioYN(\_CO_PUBLISHER_DOIMAGE, 'doimage', $obj->doimage(), _YES, _NO);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '442', column '37').
      Open

                      $criteria     = new \CriteriaCompo(new \Criteria('imgcat_id', '(' . \implode(',', $catids) . ')', 'IN'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '474', column '31').
      Open

                  $addbreak   = new \XoopsFormLabel('', '<br>');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '674', column '35').
      Open

                  $this->addElement(new \XoopsFormText(\_CO_PUBLISHER_WEIGHT, 'weight', 5, 5, $obj->weight()));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '472', column '31').
      Open

                  $opentable  = new \XoopsFormLabel('', '<table><tr><td>');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '478', column '29').
      Open

                  $js_data  = new \XoopsFormLabel(
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '698', column '23').
      Open

              $hidden = new \XoopsFormHidden('itemid', $obj->itemid());
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '567', column '33').
      Open

                  $imageSelect3 = new \XoopsFormSelect(\_CO_PUBLISHER_IMAGE_ITEM, 'image_featured', $imagename, 1);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '684', column '41').
      Open

                  $buttonTray->addElement(new \XoopsFormButton('', 'additem', \_CO_PUBLISHER_CREATE, 'submit'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '690', column '37').
      Open

              $buttonTray->addElement(new \XoopsFormButton('', 'preview', \_CO_PUBLISHER_PREVIEW, 'submit'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '178', column '33').
      Open

                  $textShortUrl = new \XoopsFormText(\_CO_PUBLISHER_ITEM_SHORT_URL, 'item_short_url', 50, 255, $obj->short_url('e'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '208', column '31').
      Open

                  $formEditor = new \XoopsFormSelectEditor($this, 'editor', $editor, $nohtml, $allowedEditors);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '261', column '40').
      Open

                      $linebreak_radio = new \XoopsFormRadioYN(\_CO_PUBLISHER_DOLINEBREAK, 'dolinebreak', $obj->dobr(), _YES, _NO);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '388', column '40').
      Open

                  $dateExpireYesNo     = new \XoopsFormRadioYN('', 'use_expire_yn', $dateexpire_opt);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '524', column '29').
      Open

                  $nicename = new \XoopsFormText('', 'image_nicename', 30, 30, \_CO_PUBLISHER_IMAGE_NICENAME);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '307', column '35').
      Open

                  $this->addElement(new \XoopsFormSelectUser(\_CO_PUBLISHER_UID, 'uid', false, $userUid, 1, false), false);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '523', column '29').
      Open

                  $button   = new \XoopsFormLabel('', "<div id='publisher_upload_button'>" . \_CO_PUBLISHER_IMAGE_UPLOAD_NEW . '</div>');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '535', column '36').
      Open

                  $imageUploadTray = new \XoopsFormElementTray(\_CO_PUBLISHER_IMAGE_UPLOAD, '');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '169', column '31').
      Open

              $this->addElement(new \XoopsFormText(\_CO_PUBLISHER_TITLE, 'title', 50, 255, $obj->getVar('title', 'e')), true);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '234', column '39').
      Open

              $bodyText               = new \XoopsFormEditor(\_CO_PUBLISHER_BODY, $editor, $editorConfigs, $nohtml, $onfailure = null);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '443', column '36').
      Open

                      $criteria->add(new \Criteria('image_display', 1));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '595', column '33').
      Open

                  $statusSelect = new \XoopsFormRadioYN(\_CO_PUBLISHER_FILE_STATUS, 'item_file_status', 1); //1 - active
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '681', column '27').
      Open

              $buttonTray = new \XoopsFormElementTray('', '');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '685', column '41').
      Open

                  $buttonTray->addElement(new \XoopsFormButton('', '', \_CO_PUBLISHER_CLEAR, 'reset'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '395', column '35').
      Open

                  $dateExpireTray = new \XoopsFormElementTray(\_CO_PUBLISHER_DATEEXPIRE, '');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '466', column '30').
      Open

                  $buttonadd = new \XoopsFormButton('', 'buttonadd', \_CO_PUBLISHER_ADD);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '522', column '29').
      Open

                  $messages = new \XoopsFormLabel('', "<div id='publisher_upload_message'></div>");
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '547', column '30').
      Open

                  $imageTray = new \XoopsFormElementTray(\_CO_PUBLISHER_IMAGE_ITEMS, '');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '294', column '35').
      Open

                  $votetypeSelect = new \XoopsFormSelect(\_MI_PUBLISHER_RATINGBARS, 'votetype', $obj->getVar('votetype'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '309', column '35').
      Open

                  $this->addElement(new \XoopsFormHidden('uid', $userUid));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '473', column '31').
      Open

                  $addcol     = new \XoopsFormLabel('', '</td><td>');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '532', column '29').
      Open

                  $imagecat = new \XoopsFormSelect('', 'imgcat_id', '', 1);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '273', column '39').
      Open

                  $availableWrapPages = new \XoopsFormLabel(\_CO_PUBLISHER_AVAILABLE_PAGE_WRAP, \implode(', ', $availableWrapPagesText));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '390', column '40').
      Open

                  $dateexpire_datetime = new \XoopsFormDateTime('', 'dateexpire', $size = 15, $dateexpire, true);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '573', column '34').
      Open

                  $image_preview = new \XoopsFormLabel(\_CO_PUBLISHER_IMAGE_PREVIEW, "<img src='" . XOOPS_URL . '/uploads/' . $imageforpath . "' name='image_display' id='image_display' alt=''>");
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '659', column '42').
      Open

                  $text_meta_description = new \XoopsFormTextArea(\_CO_PUBLISHER_ITEM_META_DESCRIPTION, 'item_meta_description', $obj->meta_description('e'), 7, 60);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '226', column '43').
      Open

                  $summaryText            = new \XoopsFormEditor(\_CO_PUBLISHER_SUMMARY, $editor, $editorConfigs, $nohtml, $onfailure = null);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '354', column '33').
      Open

                  $statusSelect = new \XoopsFormSelect(\_CO_PUBLISHER_STATUS, 'status', $obj->getVar('status'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '687', column '41').
      Open

                  $buttonTray->addElement(new \XoopsFormButton('', 'additem', _SUBMIT, 'submit')); //orclone
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '404', column '33').
      Open

                  $notify_radio = new \XoopsFormRadioYN(\_CO_PUBLISHER_NOTIFY, 'notify', $obj->notifypub(), _YES, _NO);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '462', column '33').
      Open

                  $imageSelect2 = new \XoopsFormSelect('', 'image_item', '', 5, true);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '600', column '28').
      Open

                  $fileBox = new \XoopsFormFile(\_CO_PUBLISHER_ITEM_UPLOAD_FILE, 'item_upload_file', 0);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '638', column '38').
      Open

                          $files_box = new \XoopsFormLabel(\_CO_PUBLISHER_FILES_LINKED, $table);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '340', column '28').
      Open

                  $element = new \XoopsFormText(\_CO_PUBLISHER_AUTHOR_ALIAS, 'author_alias', 50, 255, $obj->getVar('author_alias', 'e'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '584', column '29').
      Open

                  $nameText = new \XoopsFormText(\_CO_PUBLISHER_FILENAME, 'item_file_name', 50, 255, '');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '590', column '36').
      Open

                  $descriptionText = new \XoopsFormTextArea(\_CO_PUBLISHER_FILE_DESCRIPTION, 'item_file_description', '');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $buttonTray->addElement(new \XoopsFormButton('', 'additem', _SUBMIT, 'submit')); //orclone
              }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $this->addElement(new \XoopsFormHidden('uid', $userUid));
              }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'createElements'.
      Open

                      $editor = Utility::getCookieVar('publisher_editor');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      $datesub = (0 == $obj->getVar('datesub')) ? \time() : $obj->getVar('datesub');
                  }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      $editor = Utility::getCookieVar('publisher_editor');
                      if (empty($editor) && \is_object($GLOBALS['xoopsUser'])) {
                          //                    $editor = @ $GLOBALS['xoopsUser']->getVar('publisher_editor'); // Need set through user profile
                          $editor = $GLOBALS['xoopsUser']->getVar('publisher_editor') ?? ''; // Need set through user profile
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsModules\Publisher\Helper' in method 'createElements'.
      Open

              $helper     = Helper::getInstance();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'createElements'.
      Open

              $allowedEditors = Utility::getEditors($helper->getHandler('Permission')->getGrantedItems('editors'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsLists' in method 'createElements'.
      Open

                  $wrapPages              = \XoopsLists::getHtmlListAsArray(Utility::getUploadDir(true, 'content'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\XoopsModules\Publisher\Helper' in method 'isGranted'.
      Open

              $helper = Helper::getInstance();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      $dateexpire_opt = 1;
                      $dateexpire     = $obj->getVar('dateexpire');
                  }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\Xmf\Request' in method 'createElements'.
      Open

                  $editor = Request::getString('editor', '', 'POST');
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      $catlist = $imgcatHandler->getList($group, 'imgcat_read', 1);
                  }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $group      = [XOOPS_GROUP_ANONYMOUS];
                  $currentUid = 0;
              }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'createElements'.
      Open

                      Utility::setCookieVar('publisher_editor', $editor);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      // compare selected in options with readable of user
                      $catlist = \array_intersect($catlist, $imgcatConfig);
                      $catids  = \array_keys($catlist);
                  }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method createElements uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $editor = $helper->getConfig('submit_editor');
              }
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'createElements'.
      Open

                  $wrapPages              = \XoopsLists::getHtmlListAsArray(Utility::getUploadDir(true, 'content'));
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid unused local variables such as '$onfailure'.
      Open

                  $summaryText            = new \XoopsFormEditor(\_CO_PUBLISHER_SUMMARY, $editor, $editorConfigs, $nohtml, $onfailure = null);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid unused local variables such as '$size'.
      Open

                  $datesub_datetime = new FormDateTime(\_CO_PUBLISHER_DATESUB, 'datesub', $size = 15, $datesub, true, true);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid excessively long variable names like $availableWrapPagesText. Keep variable name length under 20.
      Open

                  $availableWrapPagesText = [];
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
          protected $reallyLongIntName = -3; // VIOLATION - Field
          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
              $otherReallyLongName = -5; // VIOLATION - Local
              for ($interestingIntIndex = 0; // VIOLATION - For
                   $interestingIntIndex < 10;
                   $interestingIntIndex++ ) {
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $text_meta_description. Keep variable name length under 20.
      Open

                  $text_meta_description = new \XoopsFormTextArea(\_CO_PUBLISHER_ITEM_META_DESCRIPTION, 'item_meta_description', $obj->meta_description('e'), 7, 60);
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
          protected $reallyLongIntName = -3; // VIOLATION - Field
          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
              $otherReallyLongName = -5; // VIOLATION - Local
              for ($interestingIntIndex = 0; // VIOLATION - For
                   $interestingIntIndex < 10;
                   $interestingIntIndex++ ) {
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#longvariable

      A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 49 and the first side effect is on line 38.
      Open

      <?php
      Severity: Minor
      Found in class/Form/ItemForm.php by phpcodesniffer

      There must be one USE keyword per declaration
      Open

      use XoopsModules\Publisher\{Constants,
      Severity: Minor
      Found in class/Form/ItemForm.php by phpcodesniffer

      Only one argument is allowed per line in a multi-line function call
      Open

                      '', '
      Severity: Minor
      Found in class/Form/ItemForm.php by phpcodesniffer

      The variable $image_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $notify_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $objimage_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_opt is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $files_box is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $addcomments_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $xcode_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_opt is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $objimage_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $datesub_datetime is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $objimage_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $text_meta_keywords is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $linebreak_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_opt is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_datetime is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $files_box is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_datetime is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $js_data is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $smiley_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_datetime is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $text_meta_description is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $butt_cancel is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $files_box is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $text_meta_description is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $xcode_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_opt is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_preview is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_preview is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $not_visible is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $text_meta_description is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $addcomments_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $text_meta_keywords is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $datesub_datetime is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $datesub_datetime is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $notify_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $js_data is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $not_visible is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $butt_cancel is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $butt_cancel is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $smiley_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $objimage_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $objimage_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $text_meta_keywords is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $linebreak_radio is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $dateexpire_opt is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $image_array is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $not_visible is not named in camelCase.
      Open

          public function createElements($obj)
          {
              $helper     = Helper::getInstance();
              $timeoffset = null;
              $configurator = new Configurator();
      Severity: Minor
      Found in class/Form/ItemForm.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      There are no issues that match your filters.

      Category
      Status