Sign upLogin

mambax7/publisher

View on GitHub
Star
include/onuninstall.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'xoops_module_uninstall_publisher'.
Open

    Utility::cleanCache();
Severity: Minor
Found in include/onuninstall.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\XoopsModules\Publisher\Utility' in method 'xoops_module_uninstall_publisher'.
Open

    $success = Utility::renameUploadFolder();
Severity: Minor
Found in include/onuninstall.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$module'.
Open

function xoops_module_pre_uninstall_publisher(\XoopsModule $module): bool
Severity: Minor
Found in include/onuninstall.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$module'.
Open

function xoops_module_uninstall_publisher(\XoopsModule $module): bool
Severity: Minor
Found in include/onuninstall.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There must be one blank line after the last USE statement; 0 found;
Open

use XoopsModules\Publisher\{
Severity: Minor
Found in include/onuninstall.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Publisher\{
Severity: Minor
Found in include/onuninstall.php by phpcodesniffer

There are no issues that match your filters.

Category
Status