mambax7/publisher

View on GitHub

Showing 3,032 of 3,032 total issues

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 35 and the first side effect is on line 28.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in blocks/latest_news.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 39 and the first side effect is on line 24.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in include/search.inc.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 33 and the first side effect is on line 26.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in blocks/latest_files.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 404 and the first side effect is on line 26.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in admin/item.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 28 and the first side effect is on line 23.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/Session.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 36 and the first side effect is on line 24.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in include/onupdate.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 37 and the first side effect is on line 31.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/Form/CategoryForm.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 33 and the first side effect is on line 26.
Open

<?php declare(strict_types=1);

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 43 and the first side effect is on line 32.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/Form/ItemForm.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 38 and the first side effect is on line 29.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/Form/FileForm.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 31 and the first side effect is on line 23.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/Form/ThemeTabForm.php by phpcodesniffer

Avoid variables with short names like $ip. Configured minimum length is 3.
Open

        $ip                    = \getenv('REMOTE_ADDR');
Severity: Minor
Found in class/VoteHandler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 30 and the first side effect is on line 23.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/BlockForm.php by phpcodesniffer

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 41 and the first side effect is on line 24.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in admin/pw_upload_file.php by phpcodesniffer

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                case '|': // Match start with value followed by optional hyphen
                    checkFunction = function (e) {
                        return (e.getAttribute(attrName).match(new RegExp('^' + attrValue + '-?')));
                    };
                    break;
Severity: Minor
Found in assets/js/behavior.js and 1 other location - About 50 mins to fix
assets/js/behavior.js on lines 199..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                case '~': // Match one of space seperated words
                    checkFunction = function (e) {
                        return (e.getAttribute(attrName).match(new RegExp('\\b' + attrValue + '\\b')));
                    };
                    break;
Severity: Minor
Found in assets/js/behavior.js and 1 other location - About 50 mins to fix
assets/js/behavior.js on lines 204..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function easeInOutBack has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        easeInOutBack: function (x, t, b, c, d, s) {
Severity: Minor
Found in assets/js/jquery.easing.js - About 45 mins to fix

    Function easeInBack has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            easeInBack: function (x, t, b, c, d, s) {
    Severity: Minor
    Found in assets/js/jquery.easing.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if (file_exists($filename)) {
                          if (copy($filename, $GLOBALS['xoops']->path('uploads/publisher/' . $arrFile['filerealname']))) {
                              /** @var File $fileObj */
                              $fileObj = $helper->getHandler('File')
                                                ->create();
      Severity: Major
      Found in admin/import/xnews.php - About 45 mins to fix

        Function easeOutBack has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                easeOutBack: function (x, t, b, c, d, s) {
        Severity: Minor
        Found in assets/js/jquery.easing.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language