Sign upLogin

mambax7/publisher

View on GitHub
Star

Showing 3,032 of 3,032 total issues

Missing class import via use statement (line '365', column '38').
Open

            $criteriaExpire->add(new \Criteria('dateexpire', '0'), 'OR');
Severity: Minor
Found in class/ItemHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '423', column '33').
Open

        $otherCriteria->add(new \Criteria('datesub', \time(), '<='));
Severity: Minor
Found in class/ItemHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getAllRejected has a boolean flag argument $asObject, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getAllRejected($limit = 0, $start = 0, $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asObject = true, $idKey = 'none')
Severity: Minor
Found in class/ItemHandler.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '727', column '36').
Open

        $criteriaItemsStatus = new \CriteriaCompo();
Severity: Minor
Found in class/ItemHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method displayFlash has a boolean flag argument $height, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function displayFlash($url, $width = false, $height = false)
Severity: Minor
Found in class/MyTextSanitizerExtension.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '66', column '33').
Open

            $criteria     = new \Criteria('image_id', $itemObj->getVar('image'));
Severity: Minor
Found in class/Jsonld.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method create has a boolean flag argument $isNew, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function create($isNew = true)
Severity: Minor
Found in class/RatingsHandler.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '205', column '29').
Open

            $criteria = new \CriteriaCompo();
Severity: Minor
Found in class/RatingsHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getCountsByCat has a boolean flag argument $inSubCat, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getCountsByCat($catId, $status, $inSubCat = false)
Severity: Minor
Found in class/ItemHandler.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getObjects has a boolean flag argument $id_as_key, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function &getObjects($criteria = null, $id_as_key = false, $as_object = true) //&getObjects($criteria = null)
Severity: Minor
Found in class/MimetypeHandler.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '202', column '27').
Open

                throw new \RuntimeException('no need for join...');
Severity: Minor
Found in class/MimetypeHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '106', column '17').
Open

            new \Criteria(
Severity: Minor
Found in class/PermissionHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getItemLink has a boolean flag argument $class, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getItemLink($class = false, $maxsize = 0)
Severity: Minor
Found in class/Item.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method insert has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function insert(\XoopsObject $item, $force = false)  //insert(&$item, $force = false)
Severity: Minor
Found in class/ItemHandler.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '364', column '35').
Open

            $criteriaExpire = new \CriteriaCompo();
Severity: Minor
Found in class/ItemHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '366', column '38').
Open

            $criteriaExpire->add(new \Criteria('dateexpire', \time(), '>='), 'OR');
Severity: Minor
Found in class/ItemHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '724', column '40').
Open

            $grantedCategories   = new \Criteria('categoryid', '(' . \implode(',', $categories) . ')', 'IN');
Severity: Minor
Found in class/ItemHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method selectQuery has a boolean flag argument $join, which is a certain sign of a Single Responsibility Principle violation.
Open

    private function selectQuery($criteria = null, $join = false)
Severity: Minor
Found in class/MimetypeHandler.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method displayFlash has a boolean flag argument $width, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function displayFlash($url, $width = false, $height = false)
Severity: Minor
Found in class/MyTextSanitizerExtension.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '67', column '28').
Open

        $criteria->add(new \Criteria('gperm_itemid', $id));
Severity: Minor
Found in class/PermissionHandler.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language