Sign upLogin

mambax7/smartfaq

View on GitHub
Star

Showing 649 of 649 total issues

Similar blocks of code found in 13 locations. Consider refactoring.
Open

            if (ar[i] == STATUS) {
                eval(pf + "status='" + escSglQuote(ar[++i]) + "'");
                continue;
            }
Severity: Major
Found in assets/js/overlib/mini/overlib_mini.js and 12 other locations - About 30 mins to fix
assets/js/overlib/mini/overlib_mini.js on lines 582..585
assets/js/overlib/mini/overlib_mini.js on lines 646..649
assets/js/overlib/mini/overlib_mini.js on lines 704..707
assets/js/overlib/mini/overlib_mini.js on lines 708..711
assets/js/overlib/mini/overlib_mini.js on lines 712..715
assets/js/overlib/mini/overlib_mini.js on lines 774..777
assets/js/overlib/overlib.js on lines 789..792
assets/js/overlib/overlib.js on lines 837..840
assets/js/overlib/overlib.js on lines 911..914
assets/js/overlib/overlib.js on lines 915..918
assets/js/overlib/overlib.js on lines 919..922
assets/js/overlib/overlib.js on lines 981..984

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

            if (ar[i] == CAPTIONFONT) {
                eval(pf + "captionfont='" + escSglQuote(ar[++i]) + "'");
                continue;
            }
Severity: Major
Found in assets/js/overlib/mini/overlib_mini.js and 12 other locations - About 30 mins to fix
assets/js/overlib/mini/overlib_mini.js on lines 582..585
assets/js/overlib/mini/overlib_mini.js on lines 630..633
assets/js/overlib/mini/overlib_mini.js on lines 646..649
assets/js/overlib/mini/overlib_mini.js on lines 704..707
assets/js/overlib/mini/overlib_mini.js on lines 712..715
assets/js/overlib/mini/overlib_mini.js on lines 774..777
assets/js/overlib/overlib.js on lines 789..792
assets/js/overlib/overlib.js on lines 837..840
assets/js/overlib/overlib.js on lines 911..914
assets/js/overlib/overlib.js on lines 915..918
assets/js/overlib/overlib.js on lines 919..922
assets/js/overlib/overlib.js on lines 981..984

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

            if (ar[i] == TEXTFONT) {
                eval(pf + "textfont='" + escSglQuote(ar[++i]) + "'");
                continue;
            }
Severity: Major
Found in assets/js/overlib/overlib.js and 12 other locations - About 30 mins to fix
assets/js/overlib/mini/overlib_mini.js on lines 582..585
assets/js/overlib/mini/overlib_mini.js on lines 630..633
assets/js/overlib/mini/overlib_mini.js on lines 646..649
assets/js/overlib/mini/overlib_mini.js on lines 704..707
assets/js/overlib/mini/overlib_mini.js on lines 708..711
assets/js/overlib/mini/overlib_mini.js on lines 712..715
assets/js/overlib/mini/overlib_mini.js on lines 774..777
assets/js/overlib/overlib.js on lines 789..792
assets/js/overlib/overlib.js on lines 837..840
assets/js/overlib/overlib.js on lines 915..918
assets/js/overlib/overlib.js on lines 919..922
assets/js/overlib/overlib.js on lines 981..984

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

            if (ar[i] == CAPTIONFONT) {
                eval(pf + "captionfont='" + escSglQuote(ar[++i]) + "'");
                continue;
            }
Severity: Major
Found in assets/js/overlib/overlib.js and 12 other locations - About 30 mins to fix
assets/js/overlib/mini/overlib_mini.js on lines 582..585
assets/js/overlib/mini/overlib_mini.js on lines 630..633
assets/js/overlib/mini/overlib_mini.js on lines 646..649
assets/js/overlib/mini/overlib_mini.js on lines 704..707
assets/js/overlib/mini/overlib_mini.js on lines 708..711
assets/js/overlib/mini/overlib_mini.js on lines 712..715
assets/js/overlib/mini/overlib_mini.js on lines 774..777
assets/js/overlib/overlib.js on lines 789..792
assets/js/overlib/overlib.js on lines 837..840
assets/js/overlib/overlib.js on lines 911..914
assets/js/overlib/overlib.js on lines 919..922
assets/js/overlib/overlib.js on lines 981..984

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        if (($criteria instanceof \CriteriaCompo) || ($criteria instanceof \Criteria)) {
            $sql .= ' ' . $criteria->renderWhere();
            if ('' != $criteria->getSort()) {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
Severity: Minor
Found in class/CategoryHandler.php and 2 other locations - About 30 mins to fix
class/AnswerHandler.php on lines 201..208
class/CategoryHandler.php on lines 201..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        if (($criteria instanceof \CriteriaCompo) || ($criteria instanceof \Criteria)) {
            $sql .= ' ' . $criteria->renderWhere();
            if ('' != $criteria->getSort()) {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
Severity: Minor
Found in class/CategoryHandler.php and 2 other locations - About 30 mins to fix
class/AnswerHandler.php on lines 201..208
class/CategoryHandler.php on lines 308..315

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        if (($criteria instanceof \CriteriaCompo) || ($criteria instanceof \Criteria)) {
            $sql .= ' ' . $criteria->renderWhere();
            if ('' != $criteria->getSort()) {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
Severity: Minor
Found in class/AnswerHandler.php and 2 other locations - About 30 mins to fix
class/CategoryHandler.php on lines 201..208
class/CategoryHandler.php on lines 308..315

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function olMouseMove has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function olMouseMove(e) {
    var e = (e) ? e : event;
    if (e.pageX) {
        o3_x = e.pageX;
        o3_y = e.pageY;
Severity: Minor
Found in assets/js/overlib/mini/overlib_mini.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerPostParseFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function registerPostParseFunction(fn) {
    if (isFunction(fn)) {
        if (typeof postParse == 'undefined') postParse = new Array();
        if (typeof fn == 'object') {
            postParse = postParse.concat(fn);
Severity: Minor
Found in assets/js/overlib/overlib.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerCmdLineFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function registerCmdLineFunction(fn) {
    if (isFunction(fn)) {
        if (typeof cmdLine == 'undefined') cmdLine = new Array();
        if (typeof fn == 'object') {
            cmdLine = cmdLine.concat(fn);
Severity: Minor
Found in assets/js/overlib/mini/overlib_mini.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseCmdLine has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function parseCmdLine(pf, i, args) {
    if (typeof cmdLine != 'undefined' && cmdLine.length) {
        for (var k = 0; k < cmdLine.length; k++) {
            var j = cmdLine[k](pf, i, args);
            if (j > -1) {
Severity: Minor
Found in assets/js/overlib/mini/overlib_mini.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerRunTimeFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function registerRunTimeFunction(fn) {
    if (isFunction(fn)) {
        if (typeof runTime == 'undefined') runTime = new Array();
        if (typeof fn == 'object') {
            runTime = runTime.concat(fn);
Severity: Minor
Found in assets/js/overlib/mini/overlib_mini.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerPostParseFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function registerPostParseFunction(fn) {
    if (isFunction(fn)) {
        if (typeof postParse == 'undefined') postParse = new Array();
        if (typeof fn == 'object') {
            postParse = postParse.concat(fn);
Severity: Minor
Found in assets/js/overlib/mini/overlib_mini.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkAnchorObject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function checkAnchorObject() {
    var w = o3_anchor;
    if (w) {
        if (!(mrkObj = getAnchorObjectRef(w))) {
            if (o3_noanchorwarn) {
Severity: Minor
Found in assets/js/overlib/mini/overlib_anchor_mini.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseCmdLine has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function parseCmdLine(pf, i, args) {
    if (typeof cmdLine != 'undefined' && cmdLine.length) {
        for (var k = 0; k < cmdLine.length; k++) {
            var j = cmdLine[k](pf, i, args);
            if (j > -1) {
Severity: Minor
Found in assets/js/overlib/overlib.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerCmdLineFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function registerCmdLineFunction(fn) {
    if (isFunction(fn)) {
        if (typeof cmdLine == 'undefined') cmdLine = new Array();
        if (typeof fn == 'object') {
            cmdLine = cmdLine.concat(fn);
Severity: Minor
Found in assets/js/overlib/overlib.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function olMouseMove has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function olMouseMove(e) {
    var e = (e) ? e : event;

    if (e.pageX) {
        o3_x = e.pageX;
Severity: Minor
Found in assets/js/overlib/overlib.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function postParseChecks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function postParseChecks() {
    if (typeof postParse != 'undefined' && postParse.length) {
        for (var k = 0; k < postParse.length; k++) {
            if (postParse[k]()) continue;
            return false;  // end now since have an error
Severity: Minor
Found in assets/js/overlib/overlib.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function postParseChecks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function postParseChecks() {
    if (typeof postParse != 'undefined' && postParse.length) {
        for (var k = 0; k < postParse.length; k++) {
            if (postParse[k]()) continue;
            return false;
Severity: Minor
Found in assets/js/overlib/mini/overlib_mini.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerRunTimeFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function registerRunTimeFunction(fn) {
    if (isFunction(fn)) {
        if (typeof runTime == 'undefined') runTime = new Array();
        if (typeof fn == 'object') {
            runTime = runTime.concat(fn);
Severity: Minor
Found in assets/js/overlib/overlib.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language