Sign upLogin

mambax7/smartfaq

View on GitHub
Star
xoops_version.php

Summary

Maintainability
D
2 days
Test Coverage

File xoops_version.php has 930 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

/**
 * Module: SmartFAQ
 * Author: The SmartFactory <www.smartfactory.ca>
Severity: Major
Found in xoops_version.php - About 2 days to fix

    Consider simplifying this complex logical expression.
    Open

            if ($isAdmin
            || (isset($smartConfig['allowrequest']) && 1 == $smartConfig['allowrequest']
                && (is_object($xoopsUser)
                    || (isset($smartConfig['anonpost'])
                        && 1 == $smartConfig['anonpost'])))) {
    Severity: Major
    Found in xoops_version.php - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

              if ($isAdmin
            || (isset($smartConfig['allowsubmit']) && 1 == $smartConfig['allowsubmit']
                && (is_object($xoopsUser)
                    || (isset($smartConfig['anonpost'])
                        && 1 == $smartConfig['anonpost'])))) {
      Severity: Major
      Found in xoops_version.php - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($isAdmin
            || (isset($smartConfig['allowsubmit']) && 1 == $smartConfig['allowsubmit']
                && (is_object($xoopsUser)
                    || (isset($smartConfig['anonpost'])
                        && 1 == $smartConfig['anonpost'])))) {
        Severity: Major
        Found in xoops_version.php and 1 other location - About 1 hr to fix
        xoops_version.php on lines 149..156

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($isAdmin
            || (isset($smartConfig['allowrequest']) && 1 == $smartConfig['allowrequest']
                && (is_object($xoopsUser)
                    || (isset($smartConfig['anonpost'])
                        && 1 == $smartConfig['anonpost'])))) {
        Severity: Major
        Found in xoops_version.php and 1 other location - About 1 hr to fix
        xoops_version.php on lines 140..147

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status