Sign upLogin

mambax7/smartobject

View on GitHub
Star
class/Dbupdater.php

Summary

Maintainability
D
1 day
Test Coverage

Function upgradeObjectItem has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    public function upgradeObjectItem($module, $item)
    {
        $moduleHandler = xoops_getModuleHandler($item, $module);
        if (!$moduleHandler) {
            return false;
Severity: Minor
Found in class/Dbupdater.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method upgradeObjectItem has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function upgradeObjectItem($module, $item)
    {
        $moduleHandler = xoops_getModuleHandler($item, $module);
        if (!$moduleHandler) {
            return false;
Severity: Major
Found in class/Dbupdater.php - About 2 hrs to fix

    Method moduleUpgrade has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function moduleUpgrade(\XoopsModule $module)
    {
        $dirname = $module->getVar('dirname');

        ob_start();
    Severity: Minor
    Found in class/Dbupdater.php - About 1 hr to fix

      Function moduleUpgrade has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function moduleUpgrade(\XoopsModule $module)
    {
        $dirname = $module->getVar('dirname');

        ob_start();
      Severity: Minor
      Found in class/Dbupdater.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateTable has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updateTable($table)
    {
        global $xoopsDB;
        $ret = true;
        // If table has a structure, create the table
      Severity: Minor
      Found in class/Dbupdater.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateTable has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateTable($table)
    {
        global $xoopsDB;
        $ret = true;
        // If table has a structure, create the table
      Severity: Minor
      Found in class/Dbupdater.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status