Sign upLogin

mambax7/smartobject

View on GitHub
Star
class/ObjectController.php

Summary

Maintainability
F
4 days
Test Coverage

Function postDataToObject has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function postDataToObject(&$smartObj)
    {
        foreach (array_keys($smartObj->vars) as $key) {
            switch ($smartObj->vars[$key]['data_type']) {
                case XOBJ_DTYPE_IMAGE:
Severity: Minor
Found in class/ObjectController.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doStoreFromDefaultForm has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public function doStoreFromDefaultForm(
        &$smartObj,
        $objectid,
        $created_success_msg,
        $modified_success_msg,
Severity: Minor
Found in class/ObjectController.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ObjectController.php has 338 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace XoopsModules\Smartobject;

/**
 * Contains the basis classes for managing any objects derived from SmartObjects
 *
Severity: Minor
Found in class/ObjectController.php - About 4 hrs to fix

    Method postDataToObject has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function postDataToObject(&$smartObj)
    {
        foreach (array_keys($smartObj->vars) as $key) {
            switch ($smartObj->vars[$key]['data_type']) {
                case XOBJ_DTYPE_IMAGE:
    Severity: Major
    Found in class/ObjectController.php - About 2 hrs to fix

      Method doStoreFromDefaultForm has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function doStoreFromDefaultForm(
        &$smartObj,
        $objectid,
        $created_success_msg,
        $modified_success_msg,
      Severity: Major
      Found in class/ObjectController.php - About 2 hrs to fix

        Function storeFromDefaultForm has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function storeFromDefaultForm(
        $created_success_msg,
        $modified_success_msg,
        $redirect_page = false,
        $debug = false,
        Severity: Minor
        Found in class/ObjectController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method storeFromDefaultForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function storeFromDefaultForm(
        $created_success_msg,
        $modified_success_msg,
        $redirect_page = false,
        $debug = false,
        Severity: Minor
        Found in class/ObjectController.php - About 1 hr to fix

          Method handleObjectDeletion has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function handleObjectDeletion($confirm_msg = false, $op = 'del', $userSide = false)
    {
        global $smart_previous_page;

        $objectid = isset($_REQUEST[$this->handler->keyName]) ? (int)$_REQUEST[$this->handler->keyName] : 0;
          Severity: Minor
          Found in class/ObjectController.php - About 1 hr to fix

            Method handleObjectDeletionFromUserSide has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function handleObjectDeletionFromUserSide($confirm_msg = false, $op = 'del')
    {
        global $smart_previous_page, $xoopsTpl;

        $objectid = isset($_REQUEST[$this->handler->keyName]) ? (int)$_REQUEST[$this->handler->keyName] : 0;
            Severity: Minor
            Found in class/ObjectController.php - About 1 hr to fix

              Method doStoreFromDefaultForm has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      &$smartObj,
        $objectid,
        $created_success_msg,
        $modified_success_msg,
        $redirect_page = false,
              Severity: Minor
              Found in class/ObjectController.php - About 45 mins to fix

                Method storeFromDefaultForm has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        $created_success_msg,
        $modified_success_msg,
        $redirect_page = false,
        $debug = false,
        $x_param = false
                Severity: Minor
                Found in class/ObjectController.php - About 35 mins to fix

                  Function handleObjectDeletionFromUserSide has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function handleObjectDeletionFromUserSide($confirm_msg = false, $op = 'del')
    {
        global $smart_previous_page, $xoopsTpl;

        $objectid = isset($_REQUEST[$this->handler->keyName]) ? (int)$_REQUEST[$this->handler->keyName] : 0;
                  Severity: Minor
                  Found in class/ObjectController.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function handleObjectDeletion has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function handleObjectDeletion($confirm_msg = false, $op = 'del', $userSide = false)
    {
        global $smart_previous_page;

        $objectid = isset($_REQUEST[$this->handler->keyName]) ? (int)$_REQUEST[$this->handler->keyName] : 0;
                  Severity: Minor
                  Found in class/ObjectController.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getDeleteItemLink($smartObj, $onlyUrl = false, $withimage = true, $userSide = false)
    {
        $admin_side = $userSide ? '' : 'admin/';
        $ret        = $this->handler->_moduleUrl . $admin_side . $this->handler->_page . '?op=del&' . $this->handler->keyName . '=' . $smartObj->getVar($this->handler->keyName);
        if ($onlyUrl) {
                  Severity: Major
                  Found in class/ObjectController.php and 1 other location - About 5 hrs to fix
                  class/ObjectController.php on lines 467..478

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 186.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getEditItemLink($smartObj, $onlyUrl = false, $withimage = true, $userSide = false)
    {
        $admin_side = $userSide ? '' : 'admin/';
        $ret        = $this->handler->_moduleUrl . $admin_side . $this->handler->_page . '?op=mod&' . $this->handler->keyName . '=' . $smartObj->getVar($this->handler->keyName);
        if ($onlyUrl) {
                  Severity: Major
                  Found in class/ObjectController.php and 1 other location - About 5 hrs to fix
                  class/ObjectController.php on lines 487..498

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 186.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status