Sign upLogin

mambax7/smartobject

View on GitHub
Star
class/PersistableObjectHandler.php

Summary

Maintainability
F
6 days
Test Coverage

Function insert has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
Open

    public function insert(\XoopsObject $obj, $force = false, $checkObject = true, $debug = false)
    {
        if (false !== $checkObject) {
            if (!is_object($obj)) {
                return false;
Severity: Minor
Found in class/PersistableObjectHandler.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File PersistableObjectHandler.php has 583 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace XoopsModules\Smartobject;

/**
 * Contains the basis classes for managing any objects derived from SmartObjects
 *
Severity: Major
Found in class/PersistableObjectHandler.php - About 1 day to fix

    Method insert has 131 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function insert(\XoopsObject $obj, $force = false, $checkObject = true, $debug = false)
    {
        if (false !== $checkObject) {
            if (!is_object($obj)) {
                return false;
    Severity: Major
    Found in class/PersistableObjectHandler.php - About 5 hrs to fix

      PersistableObjectHandler has 31 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class PersistableObjectHandler extends \XoopsObjectHandler
{
    public $_itemname;

    /**
      Severity: Minor
      Found in class/PersistableObjectHandler.php - About 3 hrs to fix

        Function convertResultSet has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function convertResultSet($result, $id_as_key = false, $as_object = true)
    {
        $ret = [];
        while (false !== ($myrow = $this->db->fetchArray($result))) {
            $obj = $this->create(false);
        Severity: Minor
        Found in class/PersistableObjectHandler.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getCount has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getCount(CriteriaElement $criteria = null)
    {
        $field   = '';
        $groupby = false;
        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
        Severity: Minor
        Found in class/PersistableObjectHandler.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getCount has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getCount(CriteriaElement $criteria = null)
    {
        $field   = '';
        $groupby = false;
        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
        Severity: Minor
        Found in class/PersistableObjectHandler.php - About 1 hr to fix

          Method getList has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getList(CriteriaElement $criteria = null, $limit = 0, $start = 0, $debug = false)
    {
        $ret = [];
        if (null === $criteria) {
            $criteria = new \CriteriaCompo();
          Severity: Minor
          Found in class/PersistableObjectHandler.php - About 1 hr to fix

            Function get has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function get($id, $as_object = true, $debug = false, $criteria = false)
    {
        if (!$criteria) {
            $criteria = new \CriteriaCompo();
        }
            Severity: Minor
            Found in class/PersistableObjectHandler.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function executeEvent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function executeEvent($event, &$executeEventObj)
    {
        if (!in_array($event, $this->_disabledEvents)) {
            if (method_exists($this, $event)) {
                $ret = $this->$event($executeEventObj);
            Severity: Minor
            Found in class/PersistableObjectHandler.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function query has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function query($sql, $criteria, $force = false, $debug = false)
    {
        $ret = [];

        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
            Severity: Minor
            Found in class/PersistableObjectHandler.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method delete has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function delete(\XoopsObject $obj, $force = false)
    {
        $eventResult = $this->executeEvent('beforeDelete', $obj);
        if (!$eventResult) {
            $obj->setErrors('An error occured during the BeforeDelete event');
            Severity: Minor
            Found in class/PersistableObjectHandler.php - About 1 hr to fix

              Function getList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getList(CriteriaElement $criteria = null, $limit = 0, $start = 0, $debug = false)
    {
        $ret = [];
        if (null === $criteria) {
            $criteria = new \CriteriaCompo();
              Severity: Minor
              Found in class/PersistableObjectHandler.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function get($id, $as_object = true, $debug = false, $criteria = false)
    {
        if (!$criteria) {
            $criteria = new \CriteriaCompo();
        }
              Severity: Minor
              Found in class/PersistableObjectHandler.php - About 1 hr to fix

                Function delete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function delete(\XoopsObject $obj, $force = false)
    {
        $eventResult = $this->executeEvent('beforeDelete', $obj);
        if (!$eventResult) {
            $obj->setErrors('An error occured during the BeforeDelete event');
                Severity: Minor
                Found in class/PersistableObjectHandler.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct(\XoopsDatabase $db, $itemname, $keyname, $idenfierName, $summaryName, $modulename)
                Severity: Minor
                Found in class/PersistableObjectHandler.php - About 45 mins to fix

                  Function getObjects has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getObjects(
        \CriteriaElement $criteria = null,
        $id_as_key = false,
        $as_object = true,
        $sql = false,
                  Severity: Minor
                  Found in class/PersistableObjectHandler.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function updateAll has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function updateAll($fieldname, $fieldvalue, CriteriaElement $criteria = null, $force = false)
    {
        $set_clause = $fieldname . ' = ';
        if (is_numeric($fieldvalue)) {
            $set_clause .= $fieldvalue;
                  Severity: Minor
                  Found in class/PersistableObjectHandler.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method setUploaderConfig has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $_uploadPath = false,
        $_allowedMimeTypes = false,
        $_maxFileSize = false,
        $_maxWidth = false,
        $_maxHeight = false
                  Severity: Minor
                  Found in class/PersistableObjectHandler.php - About 35 mins to fix

                    Method getObjects has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            \CriteriaElement $criteria = null,
        $id_as_key = false,
        $as_object = true,
        $sql = false,
        $debug = false
                    Severity: Minor
                    Found in class/PersistableObjectHandler.php - About 35 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return false;
                      Severity: Major
                      Found in class/PersistableObjectHandler.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in class/PersistableObjectHandler.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return true;
                          Severity: Major
                          Found in class/PersistableObjectHandler.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return false;
                            Severity: Major
                            Found in class/PersistableObjectHandler.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return false;
                              Severity: Major
                              Found in class/PersistableObjectHandler.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return false;
                                Severity: Major
                                Found in class/PersistableObjectHandler.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                  return false;
                                  Severity: Major
                                  Found in class/PersistableObjectHandler.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return false;
                                    Severity: Major
                                    Found in class/PersistableObjectHandler.php - About 30 mins to fix

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                              if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
            if ('' !== $criteria->getSort()) {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
                                      Severity: Minor
                                      Found in class/PersistableObjectHandler.php and 1 other location - About 35 mins to fix
                                      class/PersistableObjectHandler.php on lines 543..550

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 92.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                              if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
            $sql .= ' ' . $criteria->renderWhere();
            if ('' !== $criteria->getSort()) {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
                                      Severity: Minor
                                      Found in class/PersistableObjectHandler.php and 1 other location - About 35 mins to fix
                                      class/PersistableObjectHandler.php on lines 374..381

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 92.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status