Sign upLogin

mambax7/smartpartner

View on GitHub
Star

Showing 2,297 of 2,297 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 *
 * Module: SmartPartner
Severity: Major
Found in blocks/random_partner.php and 1 other location - About 4 days to fix
blocks/moving_partner.php on lines 1..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 873.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 *
 * Module: SmartPartner
Severity: Major
Found in blocks/moving_partner.php and 1 other location - About 4 days to fix
blocks/random_partner.php on lines 1..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 873.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

if ('clone' === $op) {
    xoops_cp_header();
    $myblock = new \XoopsBlock($bid);

    $db      = \XoopsDatabaseFactory::getDatabaseConnection();
Severity: Major
Found in include/blocksadmin.inc.php and 1 other location - About 1 day to fix
include/blocksadmin.inc.php on lines 363..403

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 380.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

if ('edit' === $op) {
    xoops_cp_header();
    // edit_block($bid); GIJ imported from blocksadmin.php
    $myblock = new \XoopsBlock($bid);
Severity: Major
Found in include/blocksadmin.inc.php and 1 other location - About 1 day to fix
include/blocksadmin.inc.php on lines 405..442

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 380.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function b_recent_partners_edit($options)
{
    $form = "<table border='0'>";
    $form .= '<tr><td>' . _MB_SPARTNER_PARTNERS_PSPACE . '</td><td>';
    $chk  = '';
Severity: Major
Found in blocks/recent_partners.php and 2 other locations - About 1 day to fix
blocks/partners_list.php on lines 91..197
blocks/recent_offers.php on lines 69..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 310.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function b_partners_list_edit($options)
{
    $form = "<table border='0'>";
    $form .= '<tr><td>' . _MB_SPARTNER_PARTNERS_PSPACE . '</td><td>';
    $chk  = '';
Severity: Major
Found in blocks/partners_list.php and 2 other locations - About 1 day to fix
blocks/recent_offers.php on lines 69..175
blocks/recent_partners.php on lines 59..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 310.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function b_recent_offers_edit($options)
{
    $form = "<table border='0'>";
    $form .= '<tr><td>' . _MB_SPARTNER_PARTNERS_PSPACE . '</td><td>';
    $chk  = '';
Severity: Major
Found in blocks/recent_offers.php and 2 other locations - About 1 day to fix
blocks/partners_list.php on lines 91..197
blocks/recent_partners.php on lines 59..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 310.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function xoops_module_update_smartpartner has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

function xoops_module_update_smartpartner(\XoopsModule $module, $previousVersion = null)
{
    $moduleDirName = basename(dirname(__DIR__));
    $capsDirName   = strtoupper($moduleDirName);
Severity: Minor
Found in include/onupdate.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Partner.php has 498 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace XoopsModules\Smartpartner;

/**
 *
 * Module: SmartPartner
Severity: Minor
Found in class/Partner.php - About 7 hrs to fix

    File blocksadmin.inc.php has 482 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
    Severity: Minor
    Found in include/blocksadmin.inc.php - About 7 hrs to fix

      Method editpartner has 179 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function editpartner($showmenu = false, $id = 0)
{
    global $xoopsDB, $partnerHandler, $xoopsUser, $xoopsConfig,  $xoopsModule;
    /** @var Smartpartner\Helper $helper */
    $helper = Smartpartner\Helper::getInstance();
      Severity: Major
      Found in admin/partner.php - About 7 hrs to fix

        Function insert has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
        Open

            public function insert(\XoopsObject $obj, $force = false, $checkObject = true)
    {
        if (false !== $checkObject) {
            if (!is_object($obj)) {
                return false;
        Severity: Minor
        Found in class/PersistableObjectHandler.php - About 7 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File Utility.php has 445 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php namespace XoopsModules\Smartpartner;

use Xmf\Request;
use XoopsModules\Smartpartner;
use XoopsModules\Smartpartner\Common;
        Severity: Minor
        Found in class/Utility.php - About 6 hrs to fix

          File PartnerHandler.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php namespace XoopsModules\Smartpartner;

/**
 *
 * Module: SmartPartner
          Severity: Minor
          Found in class/PartnerHandler.php - About 6 hrs to fix

            File xoops_version.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php

/**
 *
 * Module: SmartPartner
            Severity: Minor
            Found in xoops_version.php - About 6 hrs to fix

              Function b_partners_list_show has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
              Open

              function b_partners_list_show($options)
{
    require_once XOOPS_ROOT_PATH . '/modules/smartpartner/include/common.php';

    // Creating the partner handler object
              Severity: Minor
              Found in blocks/partners_list.php - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File partner.php has 393 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

/**
 *
 * Module: SmartPartner
              Severity: Minor
              Found in admin/partner.php - About 5 hrs to fix

                Function xoops_module_update_smartpartner has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
                Open

                function xoops_module_update_smartpartner(\XoopsModule $module)
{
//    require_once XOOPS_ROOT_PATH . '/modules/' . $module->getVar('dirname') . '/include/functions.php';
//    require_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartdbupdater.php';
                Severity: Minor
                Found in include/onupdate.inc.php - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method xoops_module_update_smartpartner has 122 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function xoops_module_update_smartpartner(\XoopsModule $module)
{
//    require_once XOOPS_ROOT_PATH . '/modules/' . $module->getVar('dirname') . '/include/functions.php';
//    require_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartdbupdater.php';
                Severity: Major
                Found in include/onupdate.inc.php - About 4 hrs to fix

                  Partner has 37 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Partner extends Smartobject\BaseSmartObject
{
    public $_extendedInfo = null;

    /**
                  Severity: Minor
                  Found in class/Partner.php - About 4 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language