mambax7/smartpartner

View on GitHub

Showing 179 of 2,297 total issues

Function xoops_module_update_smartpartner has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

function xoops_module_update_smartpartner(\XoopsModule $module, $previousVersion = null)
{
    $moduleDirName = basename(dirname(__DIR__));
    $capsDirName   = strtoupper($moduleDirName);

Severity: Minor
Found in include/onupdate.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Partner.php has 498 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace XoopsModules\Smartpartner;

/**
 *
 * Module: SmartPartner
Severity: Minor
Found in class/Partner.php - About 7 hrs to fix

    File blocksadmin.inc.php has 482 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /*
     * You may not change or alter any portion of this comment or credits
     * of supporting developers from this source code or any supporting source code
     * which is considered copyrighted (c) material of the original comment or credit authors.
    Severity: Minor
    Found in include/blocksadmin.inc.php - About 7 hrs to fix

      Method editpartner has 179 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function editpartner($showmenu = false, $id = 0)
      {
          global $xoopsDB, $partnerHandler, $xoopsUser, $xoopsConfig,  $xoopsModule;
          /** @var Smartpartner\Helper $helper */
          $helper = Smartpartner\Helper::getInstance();
      Severity: Major
      Found in admin/partner.php - About 7 hrs to fix

        Function insert has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
        Open

            public function insert(\XoopsObject $obj, $force = false, $checkObject = true)
            {
                if (false !== $checkObject) {
                    if (!is_object($obj)) {
                        return false;
        Severity: Minor
        Found in class/PersistableObjectHandler.php - About 7 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File Utility.php has 445 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php namespace XoopsModules\Smartpartner;
        
        use Xmf\Request;
        use XoopsModules\Smartpartner;
        use XoopsModules\Smartpartner\Common;
        Severity: Minor
        Found in class/Utility.php - About 6 hrs to fix

          File PartnerHandler.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php namespace XoopsModules\Smartpartner;
          
          /**
           *
           * Module: SmartPartner
          Severity: Minor
          Found in class/PartnerHandler.php - About 6 hrs to fix

            File xoops_version.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /**
             *
             * Module: SmartPartner
            Severity: Minor
            Found in xoops_version.php - About 6 hrs to fix

              Function b_partners_list_show has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
              Open

              function b_partners_list_show($options)
              {
                  require_once XOOPS_ROOT_PATH . '/modules/smartpartner/include/common.php';
              
                  // Creating the partner handler object
              Severity: Minor
              Found in blocks/partners_list.php - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File partner.php has 393 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              /**
               *
               * Module: SmartPartner
              Severity: Minor
              Found in admin/partner.php - About 5 hrs to fix

                Function xoops_module_update_smartpartner has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
                Open

                function xoops_module_update_smartpartner(\XoopsModule $module)
                {
                //    require_once XOOPS_ROOT_PATH . '/modules/' . $module->getVar('dirname') . '/include/functions.php';
                //    require_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartdbupdater.php';
                
                
                Severity: Minor
                Found in include/onupdate.inc.php - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method xoops_module_update_smartpartner has 122 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function xoops_module_update_smartpartner(\XoopsModule $module)
                {
                //    require_once XOOPS_ROOT_PATH . '/modules/' . $module->getVar('dirname') . '/include/functions.php';
                //    require_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartdbupdater.php';
                
                
                Severity: Major
                Found in include/onupdate.inc.php - About 4 hrs to fix

                  Partner has 37 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Partner extends Smartobject\BaseSmartObject
                  {
                      public $_extendedInfo = null;
                  
                      /**
                  Severity: Minor
                  Found in class/Partner.php - About 4 hrs to fix

                    Function myblocksadmin_update_block has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function myblocksadmin_update_block(
                        $bid,
                        $bside,
                        $bweight,
                        $bvisible,
                    Severity: Minor
                    Found in include/blocksadmin.inc.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getObjectsForUserSide has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getObjectsForUserSide()
                        {
                            global  $categoryHandler, $partnerHandler, $xoopsUser;
                            /** @var Smartpartner\Helper $helper */
                            $helper = Smartpartner\Helper::getInstance();
                    Severity: Minor
                    Found in class/OfferHandler.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function smartpartner_createMetaTags has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function smartpartner_createMetaTags($title, $categoryPath = '', $description = '', $minChar = 4)
                    {
                        global $xoopsTpl, $xoopsModule;
                        /** @var Smartpartner\Helper $helper */
                        $helper = Smartpartner\Helper::getInstance();
                    Severity: Minor
                    Found in include/metagen.php - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method insert has 101 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function insert(\XoopsObject $partner, $force = false, $checkObject = true, $debug = false)
                        {
                            if (strtolower(get_class($partner)) != strtolower($this->className)) {
                                return false;
                            }
                    Severity: Major
                    Found in class/PartnerHandler.php - About 4 hrs to fix

                      Method editcat has 98 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function editcat($showmenu = false, $categoryid = 0, $nb_subcats = 4, $categoryObj = null)
                      {
                          global $xoopsDB, $categoryHandler, $xoopsUser, $myts, $xoopsConfig,  $xoopsModule;
                          /** @var Smartpartner\Helper $helper */
                          $helper = Smartpartner\Helper::getInstance();
                      Severity: Major
                      Found in admin/category.php - About 3 hrs to fix

                        Utility has 30 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class Utility
                        {
                            use Common\VersionChecks; //checkVerXoops, checkVerPhp Traits
                        
                            use Common\ServerStats; // getServerStats Trait
                        Severity: Minor
                        Found in class/Utility.php - About 3 hrs to fix

                          Function fetchMedia has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function fetchMedia($media_name, $index = null)
                              {
                                  global $_FILES;
                          
                                  if (!isset($_FILES[$media_name])) {
                          Severity: Minor
                          Found in class/Uploader.php - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language