Function songlist_tag_iteminfo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up

Method songlist_tag_iteminfo has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

Missing class import via use statement (line '25', column '48').

Open

    $items_obj = $item_handler->getObjects(new Criteria('sid', '(' . implode(', ', $items_id) . ')', 'IN'), true);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'MyTextSanitizer' in method 'songlist_tag_iteminfo'.

Open

    $myts = MyTextSanitizer::getInstance();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid assigning values to variables in if clauses and the like (line '77', column '10').

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

The method songlist_tag_synchronization uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

    else:
    $sql =  "    DELETE {$link_handler->table} FROM {$link_handler->table}" .
            "    LEFT JOIN {$item_handler->table} AS aa ON {$link_handler->table}.tag_itemid = aa.{$item_handler->keyName} " .
            '    WHERE ' .
            "        tag_modid = {$mid}" .

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid unused local variables such as '$result'.

Open

    if (!$result = $link_handler->db->queryF($sql)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first side effect is on line 2.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

Inline control structures are not allowed

Open

            if (is_object($item_obj))

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 126 characters

Open

            "    LEFT JOIN {$item_handler->table} AS aa ON {$link_handler->table}.tag_itemid = aa.{$item_handler->keyName} " .

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $items[$cat_id][$item_id] = [

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 126 characters

Open

                'link'    => 'index.php?op=item&fct=item&id=' . $item_obj->getVar('sid') . '&cid=' . $item_obj->getVar('cid'),

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

    if (version_compare(mysql_get_server_info(), '4.1.0', 'ge')):

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    $sql =  "    DELETE FROM {$link_handler->table}" .

• Exclude checks
  • Disable engine
  • Disable check

Closing brace must be on a line by itself

Open

if (!defined('XOOPS_ROOT_PATH')) { exit(); }

• Exclude checks
  • Disable engine
  • Disable check

A closing tag is not permitted at the end of a PHP file

Open

?>

• Exclude checks
  • Disable engine
  • Disable check

Newline required after opening brace

Open

if (!defined('XOOPS_ROOT_PATH')) { exit(); }

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after ELSE keyword; 0 found

Open

    else:

• Exclude checks
  • Disable engine
  • Disable check

Line indented incorrectly; expected at least 8 spaces, found 4

Open

    $sql =  "    DELETE {$link_handler->table} FROM {$link_handler->table}" .

• Exclude checks
  • Disable engine
  • Disable check

Whitespace found at end of line

Open

    unset($items_obj);    

• Exclude checks
  • Disable engine
  • Disable check

Whitespace found at end of line

Open

 * 

• Exclude checks
  • Disable engine
  • Disable check

The variable $cat_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $cat_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $cat_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $link_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $cat_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $items_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $link_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $link_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $items_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $items_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $link_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $link_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $items_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $items_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $link_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_handler is not named in camelCase.

Open

function songlist_tag_synchronization($mid)
{
    $item_handler =& xoops_getModuleHandler('songs', 'songlist');
    $link_handler =& xoops_getModuleHandler('link', 'tag');
        

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $cat_id is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $items_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $item_obj is not named in camelCase.

Open

function songlist_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}