mambax7/songlist

View on GitHub
admin/field.php

Summary

Maintainability
A
2 hrs
Test Coverage

File field.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

use Xmf\Module\Admin;
use Xmf\Request;
use XoopsModules\Songlist\Helper;
Severity: Minor
Found in admin/field.php - About 2 hrs to fix

    Space found before comma in function call
    Open

                    ,
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Space found before comma in function call
    Open

                    ,
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Space found before comma in function call
    Open

                    ,
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Space found before comma in function call
    Open

                    ,
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 129 characters
    Open

                    $fields       = $fieldHandler->getObjects(new \Criteria('field_id', '(' . implode(',', $ids) . ')', 'IN'), true);
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 235 characters
    Open

                    if ($oldweight[$field_id] != $weight[$field_id] || $oldcat[$field_id] != $category[$field_id] || count($oldcategories[$field_id]) != count(array_unique(array_merge($categories[$field_id], $oldcategories[$field_id])))) {
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 176 characters
    Open

                xoops_confirm(['ok' => 1, 'id' => $_REQUEST['id'], 'op' => 'delete'], $_SERVER['REQUEST_URI'], sprintf(_AM_SONGLIST_FIELDS_RUSUREDEL, $obj->getVar('field_title')));
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

                                $criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $removed_groups) . ')', 'IN'));
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 138 characters
    Open

    $op           = (!empty($_GET['op']) ? $_GET['op'] : (!empty($_POST['op']) ? $_POST['op'] : (!empty($_REQUEST['id']) ? 'edit' : 'list')));
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 123 characters
    Open

                        redirect_header('field.php', 2, sprintf(_AM_SONGLIST_FIELDS_SAVEDSUCCESS, _AM_SONGLIST_FIELDS_FIELDS));
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 145 characters
    Open

                        $categories[$category[$i]->getVar('cid')] = ['cid' => $category[$i]->getVar('cid'), 'name' => $category[$i]->getVar('name')];
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 132 characters
    Open

                if (!$obj->getVar('field_config') && !$obj->getVar('field_show') && !$obj->getVar('field_edit')) { //If no configs exist
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 128 characters
    Open

            if (!$obj->getVar('field_config') && !$obj->getVar('field_show') && !$obj->getVar('field_edit')) { //If no configs exist
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    Line exceeds 120 characters; contains 125 characters
    Open

                $fields[$i]['canEdit']   = $fields[$i]['field_config'] || $fields[$i]['field_show'] || $fields[$i]['field_edit'];
    Severity: Minor
    Found in admin/field.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status