mambax7/songlist

View on GitHub
class/SongsHandler.php

Summary

Maintainability
F
1 wk
Test Coverage

getTop accesses the super-global variable $GLOBALS.
Open

    public function getTop($limit = 1): array
    {
        $sql     = 'SELECT * FROM `' . $this->table . '` WHERE `rank`>=0 ORDER BY (`rank`/`votes`) DESC LIMIT ' . $limit;
        $results = $GLOBALS['xoopsDB']->queryF($sql);
        $ret     = [];
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getURL accesses the super-global variable $GLOBALS.
Open

    public function getURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            if (0 != $cid) {
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getSearchURL accesses the super-global variable $GLOBALS.
Open

    public function getSearchURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            return XOOPS_URL . '/' . $GLOBALS['songlistModuleConfig']['baseofurl'] . '/' . $file . '/' . $start . '-' . $op . '-' . $fct . '-' . $gid . '-' . ($_GET['cid'] ?? $cid) . '-' . $vcid . '/' . \urlencode($value) . $GLOBALS['songlistModuleConfig']['endofurl'];
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $GLOBALS.
Open

    public function __construct(\XoopsDatabase $db)
    {
        $moduleHandler                   = \xoops_getHandler('module');
        $configHandler                   = \xoops_getHandler('config');
        $GLOBALS['songlistModule']       = $moduleHandler->getByDirname('songlist');
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getURL accesses the super-global variable $GLOBALS.
Open

    public function getURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            if (0 != $cid) {
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getURL accesses the super-global variable $GLOBALS.
Open

    public function getURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            if (0 != $cid) {
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $GLOBALS.
Open

    public function __construct(\XoopsDatabase $db)
    {
        $moduleHandler                   = \xoops_getHandler('module');
        $configHandler                   = \xoops_getHandler('config');
        $GLOBALS['songlistModule']       = $moduleHandler->getByDirname('songlist');
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getSearchURL accesses the super-global variable $GLOBALS.
Open

    public function getSearchURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            return XOOPS_URL . '/' . $GLOBALS['songlistModuleConfig']['baseofurl'] . '/' . $file . '/' . $start . '-' . $op . '-' . $fct . '-' . $gid . '-' . ($_GET['cid'] ?? $cid) . '-' . $vcid . '/' . \urlencode($value) . $GLOBALS['songlistModuleConfig']['endofurl'];
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getSearchURL accesses the super-global variable $_GET.
Open

    public function getSearchURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            return XOOPS_URL . '/' . $GLOBALS['songlistModuleConfig']['baseofurl'] . '/' . $file . '/' . $start . '-' . $op . '-' . $fct . '-' . $gid . '-' . ($_GET['cid'] ?? $cid) . '-' . $vcid . '/' . \urlencode($value) . $GLOBALS['songlistModuleConfig']['endofurl'];
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getURL accesses the super-global variable $GLOBALS.
Open

    public function getURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            if (0 != $cid) {
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getSearchURL accesses the super-global variable $GLOBALS.
Open

    public function getSearchURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            return XOOPS_URL . '/' . $GLOBALS['songlistModuleConfig']['baseofurl'] . '/' . $file . '/' . $start . '-' . $op . '-' . $fct . '-' . $gid . '-' . ($_GET['cid'] ?? $cid) . '-' . $vcid . '/' . \urlencode($value) . $GLOBALS['songlistModuleConfig']['endofurl'];
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

get accesses the super-global variable $GLOBALS.
Open

    public function get($id = null, $fields = null): \XoopsObject//get($id, $fields = '*')
    {
        $fields = $fields ?: '*';
        if (!isset($this->_objects['object'][$id])) {
            $this->_objects['object'][$id] = parent::get($id, $fields);
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getURL accesses the super-global variable $GLOBALS.
Open

    public function getURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            if (0 != $cid) {
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

get accesses the super-global variable $GLOBALS.
Open

    public function get($id = null, $fields = null): \XoopsObject//get($id, $fields = '*')
    {
        $fields = $fields ?: '*';
        if (!isset($this->_objects['object'][$id])) {
            $this->_objects['object'][$id] = parent::get($id, $fields);
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getURL accesses the super-global variable $GLOBALS.
Open

    public function getURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            if (0 != $cid) {
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $GLOBALS.
Open

    public function __construct(\XoopsDatabase $db)
    {
        $moduleHandler                   = \xoops_getHandler('module');
        $configHandler                   = \xoops_getHandler('config');
        $GLOBALS['songlistModule']       = $moduleHandler->getByDirname('songlist');
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getURL accesses the super-global variable $GLOBALS.
Open

    public function getURL(): string
    {
        global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
        if ($GLOBALS['songlistModuleConfig']['htaccess']) {
            if (0 != $cid) {
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getTop accesses the super-global variable $GLOBALS.
Open

    public function getTop($limit = 1): array
    {
        $sql     = 'SELECT * FROM `' . $this->table . '` WHERE `rank`>=0 ORDER BY (`rank`/`votes`) DESC LIMIT ' . $limit;
        $results = $GLOBALS['xoopsDB']->queryF($sql);
        $ret     = [];
Severity: Minor
Found in class/SongsHandler.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function insert has a Cognitive Complexity of 170 (exceeds 5 allowed). Consider refactoring.
Open

    public function insert(\XoopsObject $obj, $force = true, $object = null)
    {
        if ($obj->isNew()) {
            $new = true;
            $old = $this->create();
Severity: Minor
Found in class/SongsHandler.php - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method insert has 177 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function insert(\XoopsObject $obj, $force = true, $object = null)
    {
        if ($obj->isNew()) {
            $new = true;
            $old = $this->create();
Severity: Major
Found in class/SongsHandler.php - About 7 hrs to fix

    File SongsHandler.php has 307 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php declare(strict_types=1);
    
    namespace XoopsModules\Songlist;
    
    require_once \dirname(__DIR__) . '/include/songlist.object.php';
    Severity: Minor
    Found in class/SongsHandler.php - About 3 hrs to fix

      The class SongsHandler has an overall complexity of 97 which is very high. The configured complexity threshold is 50.
      Open

      class SongsHandler extends \XoopsPersistableObjectHandler
      {
          /**
           * SongsHandler constructor.
           * @param \XoopsDatabase $db
      Severity: Minor
      Found in class/SongsHandler.php by phpmd

      Function getFilterCriteria has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getFilterCriteria($filter): \CriteriaCompo
          {
              $parts    = \explode('|', $filter);
              $criteria = new \CriteriaCompo();
              foreach ($parts as $part) {
      Severity: Minor
      Found in class/SongsHandler.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getURL has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getURL(): string
          {
              global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
              if ($GLOBALS['songlistModuleConfig']['htaccess']) {
                  if (0 != $cid) {
      Severity: Minor
      Found in class/SongsHandler.php - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                if (\is_object($voice)) {
                                    $voice->setVar('albums', $voice->getVar('albums') - 1);
                                    $voiceHandler->insert($voice, true, null);
                                }
        Severity: Major
        Found in class/SongsHandler.php - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (true === $new || (0 != $obj->vars['vcid']['value'])) {
                                          $voice = $voiceHandler->get($obj->vars['vcid']['value']);
                                          if (\is_object($voice)) {
                                              $voice->setVar('artists', $voice->getVar('artists') + 1);
                                              $voiceHandler->insert($voice, true, $obj);
          Severity: Major
          Found in class/SongsHandler.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (!$old->isNew() && $old->getVar('vcid') > 0) {
                                            $voice = $voiceHandler->get($old->vars['vcid']['value']);
                                            if (\is_object($voice)) {
                                                $voice->setVar('artists', $voice->getVar('artists') - 1);
                                                $voiceHandler->insert($voice, true, null);
            Severity: Major
            Found in class/SongsHandler.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (\is_object($voice)) {
                                          $voice->setVar('albums', $voice->getVar('albums') + 1);
                                          $voiceHandler->insert($voice, true, $obj);
                                      }
              Severity: Major
              Found in class/SongsHandler.php - About 45 mins to fix

                Method getFilterForm has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function getFilterForm($filter, $field, $sort = 'created', $op = 'dashboard', $fct = 'list'): string
                Severity: Minor
                Found in class/SongsHandler.php - About 35 mins to fix

                  Function getURL has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getURL(): string
                      {
                          global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
                          if ($GLOBALS['songlistModuleConfig']['htaccess']) {
                              if (0 != $cid) {
                  Severity: Minor
                  Found in class/SongsHandler.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  The method insert() has an NPath complexity of 4202522400. The configured NPath complexity threshold is 200.
                  Open

                      public function insert(\XoopsObject $obj, $force = true, $object = null)
                      {
                          if ($obj->isNew()) {
                              $new = true;
                              $old = $this->create();
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  NPathComplexity

                  Since: 0.1

                  The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                  Example

                  class Foo {
                      function bar() {
                          // lots of complicated code
                      }
                  }

                  Source https://phpmd.org/rules/codesize.html#npathcomplexity

                  The method insert() has 189 lines of code. Current threshold is set to 100. Avoid really long methods.
                  Open

                      public function insert(\XoopsObject $obj, $force = true, $object = null)
                      {
                          if ($obj->isNew()) {
                              $new = true;
                              $old = $this->create();
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  The method insert() has a Cyclomatic Complexity of 67. The configured cyclomatic complexity threshold is 10.
                  Open

                      public function insert(\XoopsObject $obj, $force = true, $object = null)
                      {
                          if ($obj->isNew()) {
                              $new = true;
                              $old = $this->create();
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  CyclomaticComplexity

                  Since: 0.1

                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                  Example

                  // Cyclomatic Complexity = 11
                  class Foo {
                  1   public function example() {
                  2       if ($a == $b) {
                  3           if ($a1 == $b1) {
                                  fiddle();
                  4           } elseif ($a2 == $b2) {
                                  fiddle();
                              } else {
                                  fiddle();
                              }
                  5       } elseif ($c == $d) {
                  6           while ($c == $d) {
                                  fiddle();
                              }
                  7        } elseif ($e == $f) {
                  8           for ($n = 0; $n < $h; $n++) {
                                  fiddle();
                              }
                          } else {
                              switch ($z) {
                  9               case 1:
                                      fiddle();
                                      break;
                  10              case 2:
                                      fiddle();
                                      break;
                  11              case 3:
                                      fiddle();
                                      break;
                                  default:
                                      fiddle();
                                      break;
                              }
                          }
                      }
                  }

                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                  The method getFilterCriteria() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                  Open

                      public function getFilterCriteria($filter): \CriteriaCompo
                      {
                          $parts    = \explode('|', $filter);
                          $criteria = new \CriteriaCompo();
                          foreach ($parts as $part) {
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  CyclomaticComplexity

                  Since: 0.1

                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                  Example

                  // Cyclomatic Complexity = 11
                  class Foo {
                  1   public function example() {
                  2       if ($a == $b) {
                  3           if ($a1 == $b1) {
                                  fiddle();
                  4           } elseif ($a2 == $b2) {
                                  fiddle();
                              } else {
                                  fiddle();
                              }
                  5       } elseif ($c == $d) {
                  6           while ($c == $d) {
                                  fiddle();
                              }
                  7        } elseif ($e == $f) {
                  8           for ($n = 0; $n < $h; $n++) {
                                  fiddle();
                              }
                          } else {
                              switch ($z) {
                  9               case 1:
                                      fiddle();
                                      break;
                  10              case 2:
                                      fiddle();
                                      break;
                  11              case 3:
                                      fiddle();
                                      break;
                                  default:
                                      fiddle();
                                      break;
                              }
                          }
                      }
                  }

                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                  Missing class import via use statement (line '56', column '40').
                  Open

                                      $criteria->add(new \Criteria('`' . $var[0] . '`', '%"' . $var[1] . '";%', ($var[2] ?? 'LIKE')));
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '43', column '25').
                  Open

                          $criteria = new \CriteriaCompo();
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '52', column '40').
                  Open

                                      $criteria->add(new \Criteria('`' . $var[0] . '`', $var[1], ($var[2] ?? '=')));
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  Missing class import via use statement (line '59', column '36').
                  Open

                                  $criteria->add(new \Criteria($var[0], $var[1]));
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method getObjects has a boolean flag argument $as_object, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true): array
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  The method getObjects has a boolean flag argument $id_as_key, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true): array
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '54', column '40').
                  Open

                                      $criteria->add(new \Criteria('`' . $var[0] . '`', $var[1], ($var[2] ?? '=')));
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method insert has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                  Open

                      public function insert(\XoopsObject $obj, $force = true, $object = null)
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  BooleanArgumentFlag

                  Since: 1.4.0

                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                  Example

                  class Foo {
                      public function bar($flag = true) {
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                  Missing class import via use statement (line '50', column '40').
                  Open

                                      $criteria->add(new \Criteria('`' . $var[0] . '`', '%' . $var[1] . '%', ($var[2] ?? 'LIKE')));
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  MissingImport

                  Since: 2.7.0

                  Importing all external classes in a file through use statements makes them clearly visible.

                  Example

                  function make() {
                      return new \stdClass();
                  }

                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                  The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                  Open

                          } else {
                              $new = false;
                              $old = $this->get($obj->getVar('sid'));
                              $obj->setVar('updated', \time());
                          }
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ElseExpression

                  Since: 1.4.0

                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                  Example

                  class Foo
                  {
                      public function bar($flag)
                      {
                          if ($flag) {
                              // one branch
                          } else {
                              // another branch
                          }
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                  Avoid using static access to class 'XoopsModules\Songlist\Utility' in method 'getFilterForm'.
                  Open

                          $ele = Utility::getFilterElement($filter, $field, $sort, $op, $fct);
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  StaticAccess

                  Since: 1.4.0

                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                  Example

                  class Foo
                  {
                      public function bar()
                      {
                          Bar::baz();
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                  Avoid unused local variables such as '$id'.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  UnusedLocalVariable

                  Since: 0.2

                  Detects when a local variable is declared and/or assigned, but not used.

                  Example

                  class Foo {
                      public function doSomething()
                      {
                          $i = 5; // Unused
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                  Avoid unused parameters such as '$object'.
                  Open

                      public function insert(\XoopsObject $obj, $force = true, $object = null)
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  UnusedFormalParameter

                  Since: 0.2

                  Avoid passing parameters to methods or constructors and then not using those parameters.

                  Example

                  class Foo
                  {
                      private function bar($howdy)
                      {
                          // $howdy is not used
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                  Avoid unused local variables such as '$limit'.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  UnusedLocalVariable

                  Since: 0.2

                  Detects when a local variable is declared and/or assigned, but not used.

                  Example

                  class Foo {
                      public function doSomething()
                      {
                          $i = 5; // Unused
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                  Avoid unused local variables such as '$vcid'.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  UnusedLocalVariable

                  Since: 0.2

                  Detects when a local variable is declared and/or assigned, but not used.

                  Example

                  class Foo {
                      public function doSomething()
                      {
                          $i = 5; // Unused
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                  Avoid unused local variables such as '$limit'.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  UnusedLocalVariable

                  Since: 0.2

                  Detects when a local variable is declared and/or assigned, but not used.

                  Example

                  class Foo {
                      public function doSomething()
                      {
                          $i = 5; // Unused
                      }
                  }

                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (true === ($obj->vars['gid']['changed']??false)) {
                              if ($new || (0 != $obj->vars['gid']['value'])) {
                                  $genre = $genreHandler->get($obj->vars['gid']['value']);
                                  if (\is_object($genre)) {
                                      $genre->setVar('songs', $genre->getVar('songs') + 1);
                  Severity: Major
                  Found in class/SongsHandler.php and 1 other location - About 5 hrs to fix
                  class/SongsHandler.php on lines 124..139

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 201.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (true === $obj->vars['vcid']['changed']) {
                              if ($new || (0 != $obj->vars['vcid']['value'])) {
                                  $voice = $voiceHandler->get($obj->vars['vcid']['value']);
                                  if (\is_object($voice)) {
                                      $voice->setVar('songs', $voice->getVar('songs') + 1);
                  Severity: Major
                  Found in class/SongsHandler.php and 1 other location - About 5 hrs to fix
                  class/SongsHandler.php on lines 107..122

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 201.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if (\is_object($album)) {
                                      $album->setVar('songs', $album->getVar('songs') + 1);
                                      $albumsHandler->insert($album, true, $obj);
                                      if (true === $new || (0 != $obj->vars['vcid']['value'])) {
                                          $voice = $voiceHandler->get($obj->vars['vcid']['value']);
                  Severity: Major
                  Found in class/SongsHandler.php and 1 other location - About 3 hrs to fix
                  class/SongsHandler.php on lines 185..195

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 157.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                          if (\is_object($artists)) {
                                              $artists->setVar('songs', $artists->getVar('songs') - 1);
                                              $artistsHandler->insert($artists, true, null);
                                              if (!$old->isNew() && $old->getVar('vcid') > 0) {
                                                  $voice = $voiceHandler->get($old->vars['vcid']['value']);
                  Severity: Major
                  Found in class/SongsHandler.php and 1 other location - About 3 hrs to fix
                  class/SongsHandler.php on lines 236..246

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 157.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                          if (\is_object($artists)) {
                                              $artists->setVar('songs', $artists->getVar('songs') + 1);
                                              $artistsHandler->insert($artists, true, $obj);
                                              if (true === $new || (0 != $obj->vars['vcid']['value'])) {
                                                  $voice = $voiceHandler->get($obj->vars['vcid']['value']);
                  Severity: Major
                  Found in class/SongsHandler.php and 1 other location - About 3 hrs to fix
                  class/SongsHandler.php on lines 222..232

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 157.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if (\is_object($album)) {
                                      $album->setVar('songs', $album->getVar('songs') - 1);
                                      $albumsHandler->insert($album, true, null);
                                      if (!$old->isNew() && $old->getVar('vcid') > 0) {
                                          $voice = $voiceHandler->get($old->vars['vcid']['value']);
                  Severity: Major
                  Found in class/SongsHandler.php and 1 other location - About 3 hrs to fix
                  class/SongsHandler.php on lines 203..213

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 157.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          if ($obj->isNew()) {
                              $new = true;
                              $old = $this->create();
                              $obj->setVar('created', \time());
                          } else {
                  Severity: Minor
                  Found in class/SongsHandler.php and 2 other locations - About 35 mins to fix
                  class/AlbumsHandler.php on lines 92..100
                  class/ArtistsHandler.php on lines 90..98

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 92.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  The parameter $id_as_key is not named in camelCase.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true): array
                      {
                          $ret = parent::getObjects($criteria, $id_as_key, $as_object);
                  
                          /*if (!isset($GLOBALS['songlistAdmin'])) {
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  CamelCaseParameterName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name parameters.

                  Example

                  class ClassName {
                      public function doSomething($user_name) {
                      }
                  }

                  Source

                  Avoid variables with short names like $id. Configured minimum length is 3.
                  Open

                      public function get($id = null, $fields = null): \XoopsObject//get($id, $fields = '*')
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  Avoid variables with short names like $id. Configured minimum length is 3.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  Avoid variables with short names like $id. Configured minimum length is 3.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  Avoid variables with short names like $op. Configured minimum length is 3.
                  Open

                      public function getFilterForm($filter, $field, $sort = 'created', $op = 'dashboard', $fct = 'list'): string
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  Avoid variables with short names like $op. Configured minimum length is 3.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  The parameter $as_object is not named in camelCase.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true): array
                      {
                          $ret = parent::getObjects($criteria, $id_as_key, $as_object);
                  
                          /*if (!isset($GLOBALS['songlistAdmin'])) {
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  CamelCaseParameterName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name parameters.

                  Example

                  class ClassName {
                      public function doSomething($user_name) {
                      }
                  }

                  Source

                  Avoid variables with short names like $db. Configured minimum length is 3.
                  Open

                      public function __construct(\XoopsDatabase $db)
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  Avoid variables with short names like $i. Configured minimum length is 3.
                  Open

                          $i       = 0;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  The property $_objects is not named in camelCase.
                  Open

                  class SongsHandler extends \XoopsPersistableObjectHandler
                  {
                      /**
                       * SongsHandler constructor.
                       * @param \XoopsDatabase $db
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  CamelCasePropertyName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name attributes.

                  Example

                  class ClassName {
                      protected $property_name;
                  }

                  Source

                  Avoid variables with short names like $op. Configured minimum length is 3.
                  Open

                          global $file, $op, $fct, $id, $value, $gid, $vid, $vcid, $cid, $start, $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  ShortVariable

                  Since: 0.2

                  Detects when a field, local, or parameter has a very short name.

                  Example

                  class Something {
                      private $q = 15; // VIOLATION - Field
                      public static function main( array $as ) { // VIOLATION - Formal
                          $r = 20 + $this->q; // VIOLATION - Local
                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                              $r += $this->q;
                          }
                      }
                  }

                  Source https://phpmd.org/rules/naming.html#shortvariable

                  A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 12 and the first side effect is on line 5.
                  Open

                  <?php declare(strict_types=1);
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Property name "$_objects" should not be prefixed with an underscore to indicate visibility
                  Open

                      public $_objects = ['object' => [], 'array' => []];
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  There must be a single space after the USE keyword
                  Open

                  use  XoopsModules\Songlist\Form\FormController;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 133 characters
                  Open

                                  } elseif (\in_array($object->vars[$var[0]]['data_type'], [\XOBJ_DTYPE_INT, \XOBJ_DTYPE_DECIMAL, XOBJ_DTYPE_FLOAT])) {
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 218 characters
                  Open

                          return XOOPS_URL . '/modules/songlist/' . $file . '.php?op=' . $op . '&fct=' . $fct . '&id=' . $id . '&value=' . \urlencode($value ?? '') . '&gid=' . $gid . '&vid=' . $vid . '&cid=' . $cid . '&start=' . $start;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 152 characters
                  Open

                          return ['sid', 'cid', 'mp3', 'gid', 'vcid', 'aids', 'abid', 'songid', 'title', 'lyrics', 'hits', 'rank', 'votes', 'tags', 'created', 'updated'];
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 253 characters
                  Open

                                  return XOOPS_URL . '/' . $GLOBALS['songlistModuleConfig']['baseofurl'] . '/' . $file . '/' . $start . '-' . $id . '-' . $op . '-' . $fct . '-' . $gid . '-' . $cid . '/' . \urlencode($value) . $GLOBALS['songlistModuleConfig']['endofurl'];
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 205 characters
                  Open

                          return XOOPS_URL . '/modules/songlist/' . $file . '.php?op=' . $op . '&fct=' . $fct . '&value=' . \urlencode($value ?? '') . '&cid=' . $cid . '&gid=' . $gid . '&vcid=' . $vcid . '&start=' . $start;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 269 characters
                  Open

                              return XOOPS_URL . '/' . $GLOBALS['songlistModuleConfig']['baseofurl'] . '/' . $file . '/' . $start . '-' . $op . '-' . $fct . '-' . $gid . '-' . ($_GET['cid'] ?? $cid) . '-' . $vcid . '/' . \urlencode($value) . $GLOBALS['songlistModuleConfig']['endofurl'];
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 162 characters
                  Open

                                  $sql = 'UPDATE `' . $this->table . '` set hits=hits+1 where `' . $this->keyName . '` = ' . $this->_objects['object'][$id]->getVar($this->keyName);
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 249 characters
                  Open

                              return XOOPS_URL . '/' . $GLOBALS['songlistModuleConfig']['baseofurl'] . '/' . $file . '/' . $start . '-' . $id . '-' . $op . '-' . $fct . '-' . $gid . '-' . $cid . '/' . \urlencode($value) . $GLOBALS['songlistModuleConfig']['endofurl'];
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  Line exceeds 120 characters; contains 121 characters
                  Open

                          $sql     = 'SELECT * FROM `' . $this->table . '` WHERE `rank`>=0 ORDER BY (`rank`/`votes`) DESC LIMIT ' . $limit;
                  Severity: Minor
                  Found in class/SongsHandler.php by phpcodesniffer

                  The variable $as_object is not named in camelCase.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true): array
                      {
                          $ret = parent::getObjects($criteria, $id_as_key, $as_object);
                  
                          /*if (!isset($GLOBALS['songlistAdmin'])) {
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  The variable $id_as_key is not named in camelCase.
                  Open

                      public function &getObjects($criteria = null, $id_as_key = false, $as_object = true): array
                      {
                          $ret = parent::getObjects($criteria, $id_as_key, $as_object);
                  
                          /*if (!isset($GLOBALS['songlistAdmin'])) {
                  Severity: Minor
                  Found in class/SongsHandler.php by phpmd

                  CamelCaseVariableName

                  Since: 0.2

                  It is considered best practice to use the camelCase notation to name variables.

                  Example

                  class ClassName {
                      public function doSomething() {
                          $data_module = new DataModule();
                      }
                  }

                  Source

                  There are no issues that match your filters.

                  Category
                  Status