Sign upLogin

mambax7/songlist

View on GitHub
Star
include/update.php

Summary

Maintainability
B
4 hrs
Test Coverage

xoops_module_update_songlist accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_songlist(&$module): bool
{
    $sql = [];

    $sql[] = 'CREATE TABLE `'
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_vs_executesql accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_vs_executesql accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_songlist accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_songlist(&$module): bool
{
    $sql = [];

    $sql[] = 'CREATE TABLE `'
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_songlist accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_songlist(&$module): bool
{
    $sql = [];

    $sql[] = 'CREATE TABLE `'
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_songlist accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_songlist(&$module): bool
{
    $sql = [];

    $sql[] = 'CREATE TABLE `'
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_vs_executesql accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_vs_executesql accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_vs_executesql accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

xoops_module_update_songlist accesses the super-global variable $GLOBALS.
Open

function xoops_module_update_songlist(&$module): bool
{
    $sql = [];

    $sql[] = 'CREATE TABLE `'
Severity: Minor
Found in include/update.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function xoops_module_update_vs_executesql has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
Severity: Minor
Found in include/update.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method xoops_module_update_vs_executesql has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
Severity: Minor
Found in include/update.php - About 1 hr to fix

    The function xoops_module_update_vs_executesql() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

    function xoops_module_update_vs_executesql($sql): bool
{
    if (is_string($sql)) {
        if ($GLOBALS['xoopsDB']->queryF($sql)) {
            xoops_error($sql, 'SQL Executed Successfully!!!');
    Severity: Minor
    Found in include/update.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    The method xoops_module_update_vs_executesql uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

        } else {
        return false;
    }
    Severity: Minor
    Found in include/update.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid unused parameters such as '$module'.
    Open

    function xoops_module_update_songlist(&$module): bool
    Severity: Minor
    Found in include/update.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Line exceeds 120 characters; contains 130 characters
    Open

        $sql[] = 'ALTER TABLE `' . $GLOBALS['xoopsDB']->prefix('songlist_songs') . "` ADD COLUMN `vcid` INT(12) UNSIGNED DEFAULT '0'";
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

        $sql[] = 'ALTER TABLE `' . $GLOBALS['xoopsDB']->prefix('songlist_songs') . "` ADD COLUMN `mp3` VARCHAR(500) DEFAULT ''";
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Line exceeds 120 characters; contains 504 characters
    Open

                 . "` (  `vcid` INT(10) UNSIGNED NOT NULL AUTO_INCREMENT,  `name` VARCHAR(128) DEFAULT NULL,  `artists` INT(12) UNSIGNED DEFAULT '0',  `albums` INT(12) UNSIGNED DEFAULT '0',  `songs` INT(12) UNSIGNED DEFAULT '0',  `rank` DECIMAL(10,3) UNSIGNED DEFAULT '0.000',  `votes` INT(10) UNSIGNED DEFAULT '0',  `created` INT(12) UNSIGNED DEFAULT '0',  `updated` INT(12) UNSIGNED DEFAULT '0',  PRIMARY KEY (`vcid`),  KEY `SORT` (`name`(32),`rank`,`votes`,`created`)) ENGINE=InnoDB DEFAULT CHARSET=utf8";
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

        $sql[] = 'ALTER TABLE `' . $GLOBALS['xoopsDB']->prefix('songlist_songs') . '` CHANGE COLUMN `lyrics` `lyrics` LONGTEXT';
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Line exceeds 120 characters; contains 153 characters
    Open

        $sql[] = 'ALTER TABLE `' . $GLOBALS['xoopsDB']->prefix('songlist_songs') . '` CHANGE COLUMN `traxid` `traxid` INT(4) UNSIGNED ZEROFILL DEFAULT NULL';
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Closing brace indented incorrectly; expected 16 spaces, found 12
    Open

                }
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Closing brace indented incorrectly; expected 12 spaces, found 16
    Open

                    } elseif ($GLOBALS['xoopsDB']->queryF($question)) {
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Line indented incorrectly; expected 16 spaces, found 20
    Open

                        if ($GLOBALS['xoopsDB']->queryF($question)) {
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Line indented incorrectly; expected 16 spaces, found 20
    Open

                        }
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    Line indented incorrectly; expected 12 spaces, found 16
    Open

                    } elseif ($GLOBALS['xoopsDB']->queryF($question)) {
    Severity: Minor
    Found in include/update.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status