Sign upLogin

mambax7/songlist

View on GitHub
Star

Showing 3,642 of 3,642 total issues

The variable $profile_groups is not named in camelCase.
Open

    public function getVisibleFields($profile_groups, $user_groups = []): array
    {
        $profile_groups[] = '0';
        $user_groups[]    = '0';
        $profile_groups[] = $user_groups[] = 0;
Severity: Minor
Found in class/VisibilityHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $field_ids is not named in camelCase.
Open

    public function getVisibleFields($profile_groups, $user_groups = []): array
    {
        $profile_groups[] = '0';
        $user_groups[]    = '0';
        $profile_groups[] = $user_groups[] = 0;
Severity: Minor
Found in class/VisibilityHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $as_array is not named in camelCase.
Open

    public function getForm($as_array = false)
    {
        return FormController::getFormVoice($this, $as_array);
    }
Severity: Minor
Found in class/Voice.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $profile_groups is not named in camelCase.
Open

    public function getVisibleFields($profile_groups, $user_groups = []): array
    {
        $profile_groups[] = '0';
        $user_groups[]    = '0';
        $profile_groups[] = $user_groups[] = 0;
Severity: Minor
Found in class/VisibilityHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $field_ids is not named in camelCase.
Open

    public function getVisibleFields($profile_groups, $user_groups = []): array
    {
        $profile_groups[] = '0';
        $user_groups[]    = '0';
        $profile_groups[] = $user_groups[] = 0;
Severity: Minor
Found in class/VisibilityHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $xml_array is not named in camelCase.
Open

    public static function xml2array($contents, $get_attributes = 1, $priority = 'tag')
    {
        if (!$contents) {
            return [];
        }
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_groups is not named in camelCase.
Open

    public function getVisibleFields($profile_groups, $user_groups = []): array
    {
        $profile_groups[] = '0';
        $user_groups[]    = '0';
        $profile_groups[] = $user_groups[] = 0;
Severity: Minor
Found in class/VisibilityHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $field_id is not named in camelCase.
Open

    public function getVisibleFields($profile_groups, $user_groups = []): array
    {
        $profile_groups[] = '0';
        $user_groups[]    = '0';
        $profile_groups[] = $user_groups[] = 0;
Severity: Minor
Found in class/VisibilityHandler.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $attributes_data is not named in camelCase.
Open

    public static function xml2array($contents, $get_attributes = 1, $priority = 'tag')
    {
        if (!$contents) {
            return [];
        }
Severity: Minor
Found in class/Utility.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $as_array is not named in camelCase.
Open

    public function getForm($as_array = false)
    {
        return FormController::votes_get_form($this, $as_array);
    }
Severity: Minor
Found in class/Votes.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _renderOptionTree is not named in camelCase.
Open

    public function _renderOptionTree(&$tree, $option, $prefix, $parentIds = []): void
    {
        if ($option['id'] > 0) :
            $tree .= $prefix . '<input type="checkbox" name="' . $this->getName() . '[groups][' . $this->_groupId . '][' . $option['id'] . ']" id="' . $this->getName() . '[groups][' . $this->_groupId . '][' . $option['id'] . ']" onclick="';
            foreach ($parentIds as $pid) {
Severity: Minor
Found in admin/permissions.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method GetCatAndSubCat is not named in camelCase.
Open

    public function GetCatAndSubCat($pid = 0)
    {
        $categories  = $this->getObjects(new \Criteria('pid', $pid), true);
        $langs_array = $this->TreeIDs([], $categories, -1);
Severity: Minor
Found in class/CategoryHandler.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method TreeIDs is not named in camelCase.
Open

    private function TreeIDs($langs_array, $categories, $level)
    {
        foreach ($categories as $catid => $category) {
            $langs_array[$catid] = $catid;
            $categoriesb         = $this->getObjects(new \Criteria('pid', $catid), true);
Severity: Minor
Found in class/CategoryHandler.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method name_value is not named in camelCase.
Open

    public function name_value($name, $value)
    {
        $encoded_value = $this->_encode($value);

        if ($this->isError($encoded_value)) {
Severity: Minor
Found in class/JSON.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _encode is not named in camelCase.
Open

    public function _encode($var)
    {
        switch (gettype($var)) {
            case 'boolean':
                return $var ? 'true' : 'false';
Severity: Minor
Found in class/JSON.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method reduce_string is not named in camelCase.
Open

    public function reduce_string($str): string
    {
        $str = preg_replace(
            [
                // eliminate single line comments in '// ...' form
Severity: Minor
Found in class/JSON.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _copyFile is not named in camelCase.
Open

    public function _copyFile($chmod): bool
    {
        $matched = [];
        if (!\preg_match('/\.([a-zA-Z0-9]+)$/', $this->mediaName, $matched)) {
            return false;
Severity: Minor
Found in class/Uploader.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

TODO found
Open

                \curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, true); //TODO: how to avoid an error when 'Peer's Certificate issuer is not recognized'
Severity: Minor
Found in class/Common/VersionChecks.php by fixme

TODO found
Open

            $ret[$id] = $object->toArray(true); //TODO mb why do we need toArray()?
Severity: Minor
Found in blocks/songlist_popular_artists.php by fixme

TODO found
Open

                \curl_setopt($curlHandle, \CURLOPT_SSL_VERIFYPEER, true); //TODO: how to avoid an error when 'Peer's Certificate issuer is not recognized'
Severity: Minor
Found in class/Utility.php by fixme
Severity
Category
Status
Source
Language