mambax7/tdmdownloads

View on GitHub
admin/category.php

Summary

Maintainability
D
2 days
Test Coverage

File category.php has 345 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

use Xmf\Module\Admin;
Severity: Minor
Found in admin/category.php - About 4 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (\Xmf\Request::hasVar('ok', 'REQUEST') && 1 == \Xmf\Request::getInt('ok', 0, 'REQUEST')) {
                if (!$GLOBALS['xoopsSecurity']->check()) {
                    redirect_header('category.php', 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
                }
                // supression des téléchargements de la catégorie
    Severity: Critical
    Found in admin/category.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (1 == $helper->getConfig('usetag') && class_exists(LinkHandler::class)) {
                          /** @var \XoopsModules\Tag\LinkHandler $linkHandler */
                          $linkHandler = TagHelper::getInstance()->getHandler('Link');
                          $criteria    = new \CriteriaCompo();
                          $criteria->add(new \Criteria('tag_itemid', $downloadsArray[$i]->getVar('lid')));
      Severity: Major
      Found in admin/category.php and 1 other location - About 4 hrs to fix
      admin/category.php on lines 222..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 167.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (1 == $helper->getConfig('usetag') && class_exists(LinkHandler::class)) {
                              /** @var \XoopsModules\Tag\LinkHandler $linkHandler */
                              $linkHandler = TagHelper::getInstance()->getHandler('Link');
                              $criteria    = new \CriteriaCompo();
                              $criteria->add(new \Criteria('tag_itemid', $downloadsArray[$j]->getVar('lid')));
      Severity: Major
      Found in admin/category.php and 1 other location - About 4 hrs to fix
      admin/category.php on lines 152..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 167.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          case 'new_cat':
              //Affichage de la partie haute de l'administration de Xoops
              xoops_cp_header();
              $adminObject = Admin::getInstance();
              $GLOBALS['xoopsTpl']->assign('navigation', $adminObject->displayNavigation(basename(__FILE__)));
      Severity: Major
      Found in admin/category.php and 1 other location - About 2 hrs to fix
      admin/field.php on lines 82..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 131.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
                  $uploader->setPrefix('downloads_');
                  $uploader->fetchMedia($_POST['xoops_upload_file'][0]);
                  if ($uploader->upload()) {
                      $obj->setVar('cat_imgurl', $uploader->getSavedFileName());
      Severity: Major
      Found in admin/category.php and 1 other location - About 2 hrs to fix
      admin/field.php on lines 186..197

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

      if (is_object($helper->getModule())) {
          $pathModIcon16 = $helper->getModule()->getInfo('modicons16');
          $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
          $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL . '/modules/' . $moduleDirName . '/' . $pathModIcon16);
          $GLOBALS['xoopsTpl']->assign('pathModIcon32', $pathModIcon32);
      Severity: Major
      Found in admin/category.php and 4 other locations - About 55 mins to fix
      admin/broken.php on lines 109..114
      admin/downloads.php on lines 774..779
      admin/field.php on lines 219..224
      admin/modified.php on lines 314..319

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status