Sign upLogin

mambax7/tdmdownloads

View on GitHub
Star
admin/import.php

Summary

Maintainability
F
3 days
Test Coverage

Function importWfdownloads has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

function importWfdownloads($shots = '', $catimg = '')
{
    $moduleDirName = basename(dirname(__DIR__));
    $ok            = \Xmf\Request::getInt('ok', 0, 'POST');
    global $xoopsDB;
Severity: Minor
Found in admin/import.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function importMydownloads has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

function importMydownloads($path = '', $imgurl = '')
{
    $moduleDirName = basename(dirname(__DIR__));
    $ok            = \Xmf\Request::getInt('ok', 0, 'POST');
    global $xoopsDB;
Severity: Minor
Found in admin/import.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method importMydownloads has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function importMydownloads($path = '', $imgurl = '')
{
    $moduleDirName = basename(dirname(__DIR__));
    $ok            = \Xmf\Request::getInt('ok', 0, 'POST');
    global $xoopsDB;
Severity: Major
Found in admin/import.php - About 4 hrs to fix

    File import.php has 324 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare(strict_types=1);

/**
    Severity: Minor
    Found in admin/import.php - About 3 hrs to fix

      Method importWfdownloads has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function importWfdownloads($shots = '', $catimg = '')
{
    $moduleDirName = basename(dirname(__DIR__));
    $ok            = \Xmf\Request::getInt('ok', 0, 'POST');
    global $xoopsDB;
      Severity: Major
      Found in admin/import.php - About 3 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($counter > 0) {
            $form->addElement(new \XoopsFormHidden('op', 'import_mydownloads'));
            $form->addElement(new \XoopsFormButtonTray('', _SUBMIT, 'submit', '', false));
        } else {
            $form->addElement(new \XoopsFormHidden('op', 'cancel'));
        Severity: Major
        Found in admin/import.php and 1 other location - About 1 hr to fix
        admin/import.php on lines 367..373

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($counter > 0) {
            $form->addElement(new \XoopsFormHidden('op', 'import_mydownloads'));
            $form->addElement(new \XoopsFormButtonTray('', _SUBMIT, 'submit', '', false));
        } else {
            $form->addElement(new \XoopsFormHidden('op', 'cancel'));
        Severity: Major
        Found in admin/import.php and 1 other location - About 1 hr to fix
        admin/import.php on lines 318..324

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        $insert = $xoopsDB->queryF(
                    'INSERT INTO '
                    . $xoopsDB->prefix('tdmdownloads_votedata')
                    . " (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp ) VALUES ('"
                    . $donnees['ratingid']
        Severity: Minor
        Found in admin/import.php and 1 other location - About 55 mins to fix
        admin/import.php on lines 239..255

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        $insert = $xoopsDB->queryF(
                    'INSERT INTO '
                    . $xoopsDB->prefix('tdmdownloads_votedata')
                    . " (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp ) VALUES ('"
                    . $donnees['ratingid']
        Severity: Minor
        Found in admin/import.php and 1 other location - About 55 mins to fix
        admin/import.php on lines 132..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status