Sign upLogin

mambax7/tdmdownloads

View on GitHub
Star
class/Common/FineimpuploadHandler.php

Summary

Maintainability
C
1 day
Test Coverage

Method storeUploadedFile has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function storeUploadedFile($target, $mimeType, $uid)
    {
        $moduleDirName      = \basename(\dirname(__DIR__, 2));
        $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
        require_once XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/header.php';
Severity: Major
Found in class/Common/FineimpuploadHandler.php - About 2 hrs to fix

    Function storeUploadedFile has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function storeUploadedFile($target, $mimeType, $uid)
    {
        $moduleDirName      = \basename(\dirname(__DIR__, 2));
        $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
        require_once XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/header.php';
    Severity: Minor
    Found in class/Common/FineimpuploadHandler.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleImageDB has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function handleImageDB()
    {
        $moduleDirName = \basename(\dirname(__DIR__, 2));
        require_once XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/header.php';
        global $xoopsUser;
    Severity: Minor
    Found in class/Common/FineimpuploadHandler.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return ['success' => true, 'uuid' => $uuid];
      Severity: Major
      Found in class/Common/FineimpuploadHandler.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return ['error' => \sprintf(\constant($moduleDirNameUpper . '_' . 'FAILSAVEWM_LARGE'), $this->imageNicename, $resWm)];
        Severity: Major
        Found in class/Common/FineimpuploadHandler.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return ['error' => \sprintf(\constant($moduleDirNameUpper . '_' . 'FAILSAVEWM_MEDIUM'), $this->imageNicename, $resWm)];
          Severity: Major
          Found in class/Common/FineimpuploadHandler.php - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ($wmTargetL) {
            $imgWm = $this->pathUpload . '/large/' . $this->imageNameLarge;
            $resWm = $watermarksHandler->watermarkImage($wmId, $imgWm, $imgWm);
            if (true !== $resWm) {
                return ['error' => \sprintf(\constant($moduleDirNameUpper . '_' . 'FAILSAVEWM_LARGE'), $this->imageNicename, $resWm)];
            Severity: Minor
            Found in class/Common/FineimpuploadHandler.php and 1 other location - About 40 mins to fix
            class/Common/FineimpuploadHandler.php on lines 193..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ($wmTargetM) {
            $imgWm = $this->pathUpload . '/medium/' . $this->imageName;
            $resWm = $watermarksHandler->watermarkImage($wmId, $imgWm, $imgWm);
            if (true !== $resWm) {
                return ['error' => \sprintf(\constant($moduleDirNameUpper . '_' . 'FAILSAVEWM_MEDIUM'), $this->imageNicename, $resWm)];
            Severity: Minor
            Found in class/Common/FineimpuploadHandler.php and 1 other location - About 40 mins to fix
            class/Common/FineimpuploadHandler.php on lines 185..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status