Sign upLogin

mambax7/tdmdownloads

View on GitHub
Star
submit.php

Summary

Maintainability
F
4 days
Test Coverage

File submit.php has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

use XoopsModules\Tag\{
    Helper as TagHelper,
    Tag,
Severity: Minor
Found in submit.php - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if (1 == $helper->getConfig('permission_download')) {
                        /** @var \XoopsGroupPermHandler $grouppermHandler */
                        $grouppermHandler = xoops_getHandler('groupperm');
                        $criteria         = new \CriteriaCompo();
                        $criteria->add(new \Criteria('gperm_itemid', $lidDownloads, '='));
    Severity: Major
    Found in submit.php - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (isset($_POST['xoops_upload_file'][0])) {
            $uploader = new \XoopsMediaUploader($uploaddir_downloads, $helper->getConfig('mimetypes'), $helper->getConfig('maxuploadsize'), null, null);
            if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
                if ($helper->getConfig('newnamedownload')) {
                    $uploader->setPrefix($helper->getConfig('prefixdownloads'));
      Severity: Major
      Found in submit.php and 1 other location - About 1 day to fix
      modfile.php on lines 148..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 329.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (isset($_POST['xoops_upload_file'][1])) {
            $uploader_2 = new \XoopsMediaUploader(
                $uploaddir_shots, [
                                    'image/gif',
                                    'image/jpeg',
      Severity: Major
      Found in submit.php and 1 other location - About 1 day to fix
      modfile.php on lines 177..209

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 308.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (1 == $helper->getConfig('permission_download')) {
                        /** @var \XoopsGroupPermHandler $grouppermHandler */
                        $grouppermHandler = xoops_getHandler('groupperm');
                        $criteria         = new \CriteriaCompo();
                        $criteria->add(new \Criteria('gperm_itemid', $lidDownloads, '='));
      Severity: Major
      Found in submit.php and 1 other location - About 4 hrs to fix
      admin/downloads.php on lines 721..734

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 170.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              if ('' == Xmf\Request::getString('sizeValue', '')) {
            if (0 == $mediaSize) {
                $obj->setVar('size', $utility::getFileSize(Xmf\Request::getUrl('url', '')));
            } else {
                $obj->setVar('size', $utility::convertFileSize($mediaSize));
      Severity: Major
      Found in submit.php and 2 other locations - About 1 hr to fix
      admin/downloads.php on lines 668..676
      modfile.php on lines 211..219

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (0 === $downloads_field[$i]->getVar('status_def')) {
                    $objdata   = $fielddataHandler->create();
                    $fieldName = 'champ' . $downloads_field[$i]->getVar('fid');
                    $objdata->setVar('data', \Xmf\Request::getString($fieldName, '', 'POST'));
                    $objdata->setVar('lid', $lidDownloads);
      Severity: Major
      Found in submit.php and 1 other location - About 1 hr to fix
      modfile.php on lines 235..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status