Sign upLogin

mambax7/wflinks

View on GitHub
Star

Showing 201 of 201 total issues

Method getBannerFromIdClient has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getBannerFromIdClient($client_id)
    {
        ###### Hack by www.stefanosilvestrini.com ######
        global $xoopsConfig;
        $db      = \XoopsDatabaseFactory::getDatabaseConnection();
Severity: Minor
Found in class/Utility.php - About 1 hr to fix

    Method getBannerFromIdBanner has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function getBannerFromIdBanner($banner_id)
    {
        ###### Hack by www.stefanosilvestrini.com ######
        global $xoopsConfig;
        $db      = \XoopsDatabaseFactory::getDatabaseConnection();
    Severity: Minor
    Found in class/Utility.php - About 1 hr to fix

      Method getFormFeedback has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getFormFeedback($action = false)
    {
        if (!$action) {
            $action = $_SERVER['REQUEST_URI'];
        }
      Severity: Minor
      Found in class/Common/ModuleFeedback.php - About 1 hr to fix

        Method updateBlock has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function updateBlock($bid, $btitle, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options, $groups)
    {
        $myblock = new XoopsBlock($bid);
        $myblock->setVar('title', $btitle);
        $myblock->setVar('weight', $bweight);
        Severity: Minor
        Found in admin/blocksadmin.php - About 1 hr to fix

          Function vcard_quoted_printable_encode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          function vcard_quoted_printable_encode($input, $line_max = 76)
{
    $hex       = ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F'];
    $lines     = \preg_split("/(?:\r\n|\r|\n)/", $input);
    $eol       = "\r\n";
          Severity: Minor
          Found in class/VCard.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method googleCh has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function googleCh($url, $length = null, $init = 0xE6359A60)
    {
        if (null === $length) {
            $length = \count($url);
        }
          Severity: Minor
          Found in class/Utility.php - About 1 hr to fix

            Method checkVerModule has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function checkVerModule($helper, $source = 'github', $default = 'master')
    {
        $moduleDirName      = \basename(dirname(__DIR__, 2));
        $moduleDirNameUpper = mb_strtoupper($moduleDirName);
        $update             = '';
            Severity: Minor
            Found in class/Common/VersionChecks.php - About 1 hr to fix

              Method makeTreeCheckTable has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function makeTreeCheckTable(Wflinks\Tree $xt, $itemid, $title, $checks)
{
    global $myts;

    echo "<div style='text-align: left;'>\n";
              Severity: Minor
              Found in admin/altcat.php - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ($imptotal == $impmade) {
                $newid = $db->genId($db->prefix('bannerfinish') . '_bid_seq');
                $sql   = \sprintf('INSERT INTO `%s` (bid, cid, impressions, clicks, datestart, dateend) VALUES (%u, %u, %u, %u, %u, %u)', $db->prefix('bannerfinish'), $newid, $cid, $impmade, $clicks, $date, \time());
                $db->queryF($sql);
                $db->queryF(\sprintf('DELETE FROM `%s` WHERE bid = %u', $db->prefix('banner'), $bid));
                Severity: Major
                Found in class/Utility.php and 1 other location - About 1 hr to fix
                class/Utility.php on lines 1579..1584

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ($imptotal == $impmade) {
                $newid = $db->genId($db->prefix('bannerfinish') . '_bid_seq');
                $sql   = \sprintf('INSERT INTO `%s` (bid, cid, impressions, clicks, datestart, dateend) VALUES (%u, %u, %u, %u, %u, %u)', $db->prefix('bannerfinish'), $newid, $cid, $impmade, $clicks, $date, \time());
                $db->queryF($sql);
                $db->queryF(\sprintf('DELETE FROM `%s` WHERE bid = %u', $db->prefix('banner'), $bid));
                Severity: Major
                Found in class/Utility.php and 1 other location - About 1 hr to fix
                class/Utility.php on lines 1518..1523

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method b_wflinks_banner_show has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function b_wflinks_banner_show($options)
{
    $moduleDirName = basename(__DIR__);
    global $xoopsDB;
                Severity: Minor
                Found in blocks/wflinks_banner.php - About 1 hr to fix

                  Method getListTypeAsArray has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function getListTypeAsArray($dirname, $type = '', $prefix = '', $noselection = 1)
    {
        $filelist = [];
        switch (\trim($type)) {
            case 'images':
                  Severity: Minor
                  Found in class/Lists.php - About 1 hr to fix

                    Function b_wflinks_top_show has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function b_wflinks_top_show($options)
{
    $moduleDirName = basename(dirname(__DIR__));
    global $xoopsDB;
                    Severity: Minor
                    Found in blocks/wflinks_top.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function loadTableFromArrayWithReplace has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function loadTableFromArrayWithReplace($table, $data, $search, $replace)
{
    /** @var \XoopsMySQLDatabase $db */
    $db = \XoopsDatabaseFactory::getDatabaseConnection();
                    Severity: Minor
                    Found in testdata/index.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method convertHtml2text has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function convertHtml2text($document)
    {
        $search = [
            "'<script[^>]*?>.*?</script>'si", // Strip out javascript
            "'<img.*?>'si", // Strip out img tags
                    Severity: Minor
                    Found in class/Utility.php - About 1 hr to fix

                      Method getLinkListBody has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static function getLinkListBody($published)
    {
        global $myts, $imageArray, $xoopsModule;
        /** @var Wflinks\Helper $helper */
        $helper = Wflinks\Helper::getInstance();
                      Severity: Minor
                      Found in class/Utility.php - About 1 hr to fix

                        Method editBlock has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function editBlock($bid)
    {
        require_once __DIR__ . '/admin_header.php';
        //require_once __DIR__ . '/admin_header.php';
        xoops_cp_header();
                        Severity: Minor
                        Found in admin/blocksadmin.php - About 1 hr to fix

                          Method wflinks_notify_iteminfo has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function wflinks_notify_iteminfo($category, $item_id)
{
    $moduleDirName = basename(dirname(__DIR__));
    global $xoopsModule, $xoopsModuleConfig, $xoopsConfig;
                          Severity: Minor
                          Found in include/notification.inc.php - About 1 hr to fix

                            Method displayIcons has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public static function displayIcons($time, $status = 0, $counter = 0)
    {
        global $xoopsModule;
        /** @var Wflinks\Helper $helper */
        $helper = Wflinks\Helper::getInstance();
                            Severity: Minor
                            Found in class/Utility.php - About 1 hr to fix

                              Method cloneBlock has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  function cloneBlock($bid)
    {
        require_once __DIR__ . '/admin_header.php';
        //require_once __DIR__ . '/admin_header.php';
        xoops_cp_header();
                              Severity: Minor
                              Found in admin/blocksadmin.php - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language