Sign upLogin

mambax7/xfaq

View on GitHub
Star
class/faq.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method getForm has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getForm($action = false)
    {
        global $xoopsDB, $xoopsModuleConfig;

        if ($action === false) {
Severity: Major
Found in class/faq.php - About 2 hrs to fix

    Method getanswereForm has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getanswereForm($action = false)
    {
        global $xoopsDB, $xoopsModuleConfig;

        if ($action === false) {
    Severity: Minor
    Found in class/faq.php - About 1 hr to fix

      Method getUserForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getUserForm($action = false)
    {
        global $xoopsDB;

        if ($action === false) {
      Severity: Minor
      Found in class/faq.php - About 1 hr to fix

        Method getprivacyForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getprivacyForm($action = false)
    {
        global $xoopsDB;

        if ($action === false) {
        Severity: Minor
        Found in class/faq.php - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function XFAQ_CleanVars(&$global, $key, $default = '', $type = 'int')
    {
        switch ($type) {
            case 'string':
                $ret = isset($global[$key]) ? filter_var($global[$key], FILTER_SANITIZE_MAGIC_QUOTES) : $default;
          Severity: Major
          Found in class/faq.php and 1 other location - About 1 hr to fix
          include/functions.php on lines 68..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status