Sign upLogin

mambax7/xfaq

View on GitHub
Star

Showing 48 of 48 total issues

Method checkVerXoops has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function checkVerXoops(XoopsModule $module = null, $requiredVer = null)
    {
        $moduleDirName = basename(dirname(__DIR__));
        if (null === $module) {
            $module = XoopsModule::getByDirname($moduleDirName);
Severity: Minor
Found in class/utility.php - About 1 hr to fix

    Function xfaq_tag_iteminfo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function xfaq_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
    Severity: Minor
    Found in extra/tag/xfaq.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method convertResultSet has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function convertResultSet($result, $id_as_key = false, $as_object = true)
    {
        $ret = [];
        while ($myrow = $this->db->fetchArray($result)) {
            $obj = $this->create(false);
    Severity: Minor
    Found in class/object.php - About 1 hr to fix

      Method getUserForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getUserForm($action = false)
    {
        global $xoopsDB;

        if ($action === false) {
      Severity: Minor
      Found in class/faq.php - About 1 hr to fix

        Method getprivacyForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getprivacyForm($action = false)
    {
        global $xoopsDB;

        if ($action === false) {
        Severity: Minor
        Found in class/faq.php - About 1 hr to fix

          Method getList has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getList($criteria = null, $limit = 0, $start = 0)
    {
        $ret = [];
        if ($criteria == null) {
            $criteria = new CriteriaCompo();
          Severity: Minor
          Found in class/object.php - About 1 hr to fix

            Method getCount has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getCount($criteria = null)
    {
        $field   = '';
        $groupby = false;
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
            Severity: Minor
            Found in class/object.php - About 1 hr to fix

              Method xoops_module_install_xfaq has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function xoops_module_install_xfaq()
{
    global $xoopsModule, $xoopsConfig;

    //Create directory /xfaq
              Severity: Minor
              Found in include/install.php - About 1 hr to fix

                Method xfaq_search has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function xfaq_search($queryarray, $andor, $limit, $offset, $userid)
{
    global $xoopsDB;

    global $xoopsDB;
                Severity: Minor
                Found in include/search.inc.php - About 1 hr to fix

                  Method xfaq_tag_iteminfo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function xfaq_tag_iteminfo(&$items)
{
    if (empty($items) || !is_array($items)) {
        return false;
    }
                  Severity: Minor
                  Found in extra/tag/xfaq.php - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    echo "    <td style=\"text-align: center; width: 10%;\">\n"
                     . "      <a href=\"topic.php?op=edit_topic&amp;topic_id="
                     . $topic_arr[$i]->getVar('topic_id')
                     . "\"><img src=\"../assets/images/icons/edit.png\" alt=\""
                     . _AM_XFAQ_EDIT
                    Severity: Minor
                    Found in admin/topic.php and 1 other location - About 55 mins to fix
                    admin/faq.php on lines 233..249

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 99.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    echo "    <td style=\"text-align: center; width: 10%;\">\n"
                     . "      <a href=\"faq.php?op=edit_faq&amp;faq_id="
                     . $faq_arr[$i]->getVar('faq_id')
                     . "\"><img src=\"../assets/images/icons/edit.png\" alt=\""
                     . _AM_XFAQ_EDIT
                    Severity: Minor
                    Found in admin/faq.php and 1 other location - About 55 mins to fix
                    admin/topic.php on lines 289..305

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 99.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function getList has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getList($criteria = null, $limit = 0, $start = 0)
    {
        $ret = [];
        if ($criteria == null) {
            $criteria = new CriteriaCompo();
                    Severity: Minor
                    Found in class/object.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function updateAll has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function updateAll($fieldname, $fieldvalue, $criteria = null, $force = false)
    {
        $set_clause = $fieldname . ' = ';
        if (is_numeric($fieldvalue)) {
            $set_clause .= $fieldvalue;
                    Severity: Minor
                    Found in class/object.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method addItem has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function addItem($id, $link = '', $icon = '', $name = '', $extra = '', $alt = '')
                    Severity: Minor
                    Found in class/menu.php - About 45 mins to fix

                      Function recurseCopy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public static function recurseCopy($src, $dst)
    {
        $dir = opendir($src);
        //    @mkdir($dst);
        while (false !== ($file = readdir($dir))) {
                      Severity: Minor
                      Found in class/utility.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method xfaq_search has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function xfaq_search($queryarray, $andor, $limit, $offset, $userid)
                      Severity: Minor
                      Found in include/search.inc.php - About 35 mins to fix

                        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function __construct(XoopsDatabase $db, $tablename, $classname, $keyname, $idenfierName = false)
                        Severity: Minor
                        Found in class/object.php - About 35 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
                          Severity: Minor
                          Found in class/object.php and 1 other location - About 35 mins to fix
                          class/object.php on lines 115..122

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
                          Severity: Minor
                          Found in class/object.php and 1 other location - About 35 mins to fix
                          class/object.php on lines 200..207

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language