Sign upLogin

mambax7/xnewsletter

View on GitHub
Star
include/html2text/html2text.php

Summary

Maintainability
C
1 day
Test Coverage

Method iterate_over_node has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function iterate_over_node($node)
{
    if ($node instanceof DOMText) {
        return preg_replace('/\\s+/im', ' ', $node->wholeText);
    }
Severity: Major
Found in include/html2text/html2text.php - About 3 hrs to fix

    Function iterate_over_node has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    function iterate_over_node($node)
{
    if ($node instanceof DOMText) {
        return preg_replace('/\\s+/im', ' ', $node->wholeText);
    }
    Severity: Minor
    Found in include/html2text/html2text.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return '';
    Severity: Major
    Found in include/html2text/html2text.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return $output;
      Severity: Major
      Found in include/html2text/html2text.php - About 30 mins to fix

        Function next_child_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function next_child_name($node)
{
    // get the next child
    $nextNode = $node->nextSibling;
    while (null !== $nextNode) {
        Severity: Minor
        Found in include/html2text/html2text.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prev_child_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function prev_child_name($node)
{
    // get the previous child
    $nextNode = $node->previousSibling;
    while (null !== $nextNode) {
        Severity: Minor
        Found in include/html2text/html2text.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function next_child_name($node)
{
    // get the next child
    $nextNode = $node->nextSibling;
    while (null !== $nextNode) {
        Severity: Minor
        Found in include/html2text/html2text.php and 1 other location - About 55 mins to fix
        include/html2text/html2text.php on lines 96..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function prev_child_name($node)
{
    // get the previous child
    $nextNode = $node->previousSibling;
    while (null !== $nextNode) {
        Severity: Minor
        Found in include/html2text/html2text.php and 1 other location - About 55 mins to fix
        include/html2text/html2text.php on lines 73..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status