mambax7/xnewsletter

View on GitHub
include/onupdate.php

Summary

Maintainability
D
1 day
Test Coverage

Method xoops_module_update_xnewsletter_130 has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function xoops_module_update_xnewsletter_130()
{
    // change module dirname to lowercase
    $path    = dirname(__DIR__);
    $dirname = basename(dirname(__DIR__));
Severity: Major
Found in include/onupdate.php - About 3 hrs to fix

    File onupdate.php has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * ****************************************************************************
     *  - A Project by Developers TEAM For Xoops - ( https://xoops.org )
     * ****************************************************************************
    Severity: Minor
    Found in include/onupdate.php - About 3 hrs to fix

      Method xoops_module_update_xnewsletter_141 has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function xoops_module_update_xnewsletter_141()
      {
          global $xoopsDB;
      
          $helper = \XoopsModules\Xnewsletter\Helper::getInstance();
      Severity: Major
      Found in include/onupdate.php - About 2 hrs to fix

        Function xoops_module_update_xnewsletter_130 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function xoops_module_update_xnewsletter_130()
        {
            // change module dirname to lowercase
            $path    = dirname(__DIR__);
            $dirname = basename(dirname(__DIR__));
        Severity: Minor
        Found in include/onupdate.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method xoops_module_update_xnewsletter_103 has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function xoops_module_update_xnewsletter_103()
        {
            global $xoopsDB;
        
            $sql    = sprintf('DROP TABLE IF EXISTS `' . $xoopsDB->prefix('mod_xnewsletter_import') . '`');
        Severity: Minor
        Found in include/onupdate.php - About 1 hr to fix

          Function xoops_module_update_xnewsletter_141 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          function xoops_module_update_xnewsletter_141()
          {
              global $xoopsDB;
          
              $helper = \XoopsModules\Xnewsletter\Helper::getInstance();
          Severity: Minor
          Found in include/onupdate.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status