mambax7/xnewsletter

View on GitHub

Showing 379 of 379 total issues

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in include/phpmailer/class.smtp.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return true;
    Severity: Major
    Found in include/mailinglist.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return $protocol_status;
      Severity: Major
      Found in include/task.inc.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return $this->mailSend($this->MIMEHeader, $this->MIMEBody);
        Severity: Major
        Found in include/phpmailer/class.phpmailer.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return false;
          Severity: Major
          Found in include/phpmailer/class.smtp.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return false;
            Severity: Major
            Found in include/phpmailer/class.smtp.php - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              function xnewsletter_plugin_getinfo_rmbulletin()
              {
                  global $xoopsDB;
              
                  $pluginInfo         = [];
              Severity: Minor
              Found in plugins/rmbulletin.php and 2 other locations - About 30 mins to fix
              plugins/evennews.php on lines 36..49
              plugins/simplenewsletter.php on lines 35..46

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this method.
              Open

                                  return false;
              Severity: Major
              Found in include/phpmailer/class.smtp.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return false;
                Severity: Major
                Found in include/phpmailer/class.smtp.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return null;
                  Severity: Major
                  Found in include/mailinglist.php - About 30 mins to fix

                    Function addAttachment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function addAttachment($path, $name = '', $encoding = 'base64', $type = '', $disposition = 'attachment')
                        {
                            try {
                                if (!@is_file($path)) {
                                    throw new phpmailerException($this->lang('file_access') . $path, self::STOP_CONTINUE);
                    Severity: Minor
                    Found in include/phpmailer/class.phpmailer.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function login($username = '', $password = '')
                        {
                            if (!$this->connected) {
                                $this->setError('Not connected to POP3 server');
                            }
                    Severity: Minor
                    Found in include/phpmailer/class.pop3.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function punyencodeAddress has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function punyencodeAddress($address)
                        {
                            // Verify we have required functions, CharSet, and at-sign.
                            if ($this->idnSupported() and !empty($this->CharSet) and false !== ($pos = mb_strrpos($address, '@'))) {
                                $domain = mb_substr($address, ++$pos);
                    Severity: Minor
                    Found in include/phpmailer/class.phpmailer.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function prev_child_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function prev_child_name($node)
                    {
                        // get the previous child
                        $nextNode = $node->previousSibling;
                        while (null !== $nextNode) {
                    Severity: Minor
                    Found in include/html2text/html2text.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function setFrom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function setFrom($address, $name = '', $auto = true)
                        {
                            $address = trim($address);
                            $name    = trim(preg_replace('/[\r\n]+/', '', $name)); //Strip breaks and trim
                            // Don't validate now addresses with IDN. Will be done in send().
                    Severity: Minor
                    Found in include/phpmailer/class.phpmailer.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function next_child_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function next_child_name($node)
                    {
                        // get the next child
                        $nextNode = $node->nextSibling;
                        while (null !== $nextNode) {
                    Severity: Minor
                    Found in include/html2text/html2text.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function xnewsletter_userAllowedCreateCat has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function xnewsletter_userAllowedCreateCat($cat_id = 0)
                    {
                        global $xoopsUser;
                        $grouppermHandler = xoops_getHandler('groupperm');
                        $memberHandler    = xoops_getHandler('member');
                    Severity: Minor
                    Found in include/functions.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function isParameter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function isParameter($currParameters, $varKey, $varValue)
                        {
                            foreach ($currParameters as $key => $value) {
                                if ($key == $varKey) {
                                    if ($value == $varValue) {
                    Severity: Minor
                    Found in include/phpmailer_bmh/class.phpmailer-bmh.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function xnewsletter_search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function xnewsletter_search($queryarray, $andor, $limit, $offset, $userid)
                    {
                        global $xoopsDB;
                    
                        $sql = 'SELECT cat_id, cat_name, cat_submitter, cat_created';
                    Severity: Minor
                    Found in include/search.inc.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language