mambax7/xoopsheadline

View on GitHub

Showing 59 of 59 total issues

File Blocksadmin.php has 593 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

namespace XoopsModules\Xoopsheadline\Common;

/**
Severity: Major
Found in class/Common/Blocksadmin.php - About 1 day to fix

    Function xoops_module_update_xoopsheadline has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
    Open

    function xoops_module_update_xoopsheadline(\XoopsModule $module, $previousVersion = null): bool
    {
        $moduleDirName      = \basename(\dirname(__DIR__));
        $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
    
    
    Severity: Minor
    Found in include/onupdate.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File main.php has 532 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php declare(strict_types=1);
    /*
     * You may not change or alter any portion of this comment or credits
     * of supporting developers from this source code or any supporting source code
     * which is considered copyrighted (c) material of the original comment or credit authors.
    Severity: Major
    Found in admin/main.php - About 1 day to fix

      Method listBlocks has 219 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function listBlocks(): void
          {
              global $xoopsModule, $pathIcon16;
              require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
              //        xoops_loadLanguage('admin', 'system');
      Severity: Major
      Found in class/Common/Blocksadmin.php - About 1 day to fix

        Function truncateHtml has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function truncateHtml(
                string $text,
                ?int $length = 100,
                string $ending = '...',
                bool $exact = false,
        Severity: Minor
        Found in class/Common/SysUtility.php - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function listBlocks has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

            public function listBlocks(): void
            {
                global $xoopsModule, $pathIcon16;
                require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
                //        xoops_loadLanguage('admin', 'system');
        Severity: Minor
        Found in class/Common/Blocksadmin.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkVerModule has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function checkVerModule(Helper $helper, ?string $source = 'github', ?string $default = 'master'): ?array
            {
                $moduleDirName      = \basename(\dirname(__DIR__, 2));
                $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
                $update             = '';
        Severity: Minor
        Found in class/Common/VersionChecks.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function renderFeed has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

            public function renderFeed(bool $force_update = false): bool
            {
                $retval = false;
                if ($force_update || $this->headline->cacheExpired()) {
                    if (!$this->updateCache()) {
        Severity: Minor
        Found in class/HeadlineRenderer.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method render has 95 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function render(?array $block = null): void
            {
                \xoops_load('XoopsFormLoader');
                \xoops_loadLanguage('common', $this->moduleDirNameUpper);
        
        
        Severity: Major
        Found in class/Common/Blocksadmin.php - About 3 hrs to fix

          Function updateBlock has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function updateBlock(int $bid, string $btitle, string $bside, string $bweight, string $bvisible, string $bcachetime, ?array $bmodule, ?array $options, ?array $groups): void
              {
                  $myblock = new \XoopsBlock($bid);
                  $myblock->setVar('title', $btitle);
                  $myblock->setVar('weight', $bweight);
          Severity: Minor
          Found in class/Common/Blocksadmin.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  $cachetimes = [
                      0       => _NOCACHE,
                      30      => \sprintf(_SECONDS, 30),
                      60      => _MINUTE,
                      300     => \sprintf(_MINUTES, 5),
          Severity: Major
          Found in class/Common/Blocksadmin.php and 1 other location - About 2 hrs to fix
          class/Common/Blocksadmin.php on lines 664..676

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 140.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  $cache_select->addOptionArray([
                                                    0       => _NOCACHE,
                                                    30      => \sprintf(_SECONDS, 30),
                                                    60      => _MINUTE,
                                                    300     => \sprintf(_MINUTES, 5),
          Severity: Major
          Found in class/Common/Blocksadmin.php and 1 other location - About 2 hrs to fix
          class/Common/Blocksadmin.php on lines 114..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 140.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function orderBlock has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function orderBlock(
                  array $bid,
                  array $oldtitle,
                  array $oldside,
                  array $oldweight,
          Severity: Minor
          Found in class/Common/Blocksadmin.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method xoops_module_update_xoopsheadline has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function xoops_module_update_xoopsheadline(\XoopsModule $module, $previousVersion = null): bool
          {
              $moduleDirName      = \basename(\dirname(__DIR__));
              $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
          
          
          Severity: Major
          Found in include/onupdate.php - About 2 hrs to fix

            Method renderFeed has 65 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function renderFeed(bool $force_update = false): bool
                {
                    $retval = false;
                    if ($force_update || $this->headline->cacheExpired()) {
                        if (!$this->updateCache()) {
            Severity: Major
            Found in class/HeadlineRenderer.php - About 2 hrs to fix

              Method truncateHtml has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function truncateHtml(
                      string $text,
                      ?int $length = 100,
                      string $ending = '...',
                      bool $exact = false,
              Severity: Major
              Found in class/Common/SysUtility.php - About 2 hrs to fix

                Function deleteDirectory has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function deleteDirectory(string $src): bool
                    {
                        // Only continue if user is a 'global' Admin
                        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
                            return false;
                Severity: Minor
                Found in class/Common/FilesManagement.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function b_xoopsheadline_show has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                function b_xoopsheadline_show(array $options)
                {
                    if (!class_exists(Helper::class)) {
                        return false;
                    }
                Severity: Minor
                Found in blocks/headline.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function updateCache has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function updateCache()
                    {
                        $helper = Helper::getInstance();
                        /**
                         * Update cache - first try using fopen and then cURL
                Severity: Minor
                Found in class/HeadlineRenderer.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function render has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function render(?array $block = null): void
                    {
                        \xoops_load('XoopsFormLoader');
                        \xoops_loadLanguage('common', $this->moduleDirNameUpper);
                
                
                Severity: Minor
                Found in class/Common/Blocksadmin.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language